staging: fbtft: fb_ra8875: replace udelay with usleep_range
Subsystems (3)
PATCH 1/1 staging: fbtft: fb_ra8875: replace udelay with usleep_range
udelay() busy-waits for the specified duration, consuming CPU cycles unnecessarily. usleep_range() is preferred for delays that can sleep, as it allows the scheduler to run other tasks during the wait.
Replace two instances of udelay(100) with usleep_range(100, 200) to use the preferred sleeping delay function.
--- drivers/staging/fbtft/fb_ra8875.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fb_ra8875.c +2 -2
@@ -210,7 +210,7 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...) } len--; -udelay (100 ); +usleep_range (100 ,200 );if (len) { buf = (u8 *)par->buf;
@@ -231,7 +231,7 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)/* restore user spi-speed */ par->fbtftops.write = fbtft_write_spi; -udelay (100 ); +usleep_range (100 ,200 ); }static int write_vmem16_bus8 (struct fbtft_par *par,size_t offset,size_t len)
---
base-commit: 64276d9bfe4d1fdd5cf2636f1065f7ea55c2defb
change-id: 20260716-staging-testing-b1b81d63d0d1
Best regards,
Signature · 1 line
Selby Mashiki <[email protected]>
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
Pre-existing issues:
- [Critical] Unconditional NULL Pointer Dereference on Big Endian Architectures
- [High] Missing State Restoration on Error Path
- [High] Unaligned Memory Access causing alignment faults
--
--- Patch [1]: [PATCH] staging: fbtft: fb_ra8875: replace udelay with usleep_range --- commit 0b662df2d1169732bcf1a8f82e3c8a0905497245
Author: Selby Mashiki <[email protected]>
staging: fbtft: fb_ra8875: replace udelay with usleep_range
udelay() busy-waits for the specified duration, consuming CPU cycles unnecessarily. usleep_range() is preferred for delays that can sleep, as it allows the scheduler to run other tasks during the wait.
Quoted 13 lines
drivers/staging/fbtft/fb_ra8875.c +1
-1@@ -210,7 +210,7 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...) } len--; -udelay (100 ); +usleep_range (100 ,200 );if (len) { buf = (u8 *)par->buf;
[ ... ]
drivers/staging/fbtft/fb_ra8875.c static void write_reg8_bus8(struct fbtft_par *par, int len, ...) · line 235
Quoted 7 lines
drivers/staging/fbtft/fb_ra8875.c +1
-1@@ -231,7 +231,7 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)/* restore user spi-speed */ par->fbtftops.write = fbtft_write_spi; -udelay (100 ); +usleep_range (100 ,200 ); }
[Severity: High]
This isn't a bug introduced by this patch, but I noticed the error paths in write_reg8_bus8() return early:
write_reg8_bus8() {
...
ret = par->fbtftops.write(par, par->buf, len + 1);
if (ret < 0) {
va_end(args);
dev_err(par->info->device,
"write() failed and returned %dn", ret);
return;
}
...
}Does this early return leave par->fbtftops.write pointing to the slower write_spi function, permanently degrading SPI performance? Should it restore fbtft_write_spi before returning?
drivers/staging/fbtft/fb_ra8875.c static void write_reg8_bus8(struct fbtft_par *par, int len, ...) · line 237
Quoted 2 lines
drivers/staging/fbtft/fb_ra8875.c +0
-0static int write_vmem16_bus8 (struct fbtft_par *par,size_t offset,size_t len)
[Severity: Critical]
This is a pre-existing issue, but does write_vmem16_bus8() unconditionally dereference par->txbuf.buf?
write_vmem16_bus8() {
...
*(u8 *)(par->txbuf.buf) = 0x00;
...
}If par->txbuf.buf is only dynamically allocated on Little Endian architectures or when txbuflen > 0, could this cause a kernel panic on Big Endian systems where it might be NULL?
[Severity: High]
Also a pre-existing issue in write_vmem16_bus8(): is there a risk of alignment faults on architectures that do not support unaligned memory access?
write_vmem16_bus8() {
...
txbuf16 = par->txbuf.buf + 1;
...
for (i = 0; i < to_copy; i++)
txbuf16[i] = cpu_to_be16(vmem16[i]);
...
}Since txbuf16 is cast from an odd byte offset (par->txbuf.buf + 1), does the 16-bit assignment in the loop cause an unaligned access?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 6 lines · On Thu, Jul 16, 2026 at 01:08:33PM +0200, Selby Mashiki via B4 Relay wrote:
udelay()busy-waits for the specified duration, consuming CPU cycles unnecessarily.usleep_range()is preferred for delays that can sleep, as it allows the scheduler to run other tasks during the wait.Replace two instances of udelay(100) with
usleep_range(100, 200)to use the preferred sleeping delay function.
NAK. Read mailing list archives why.
Signature · 2 lines
With Best Regards, Andy Shevchenko