pinctrl: fix unmet dependencies from missing GPIOLIB
Subsystems (2)
PATCH v2 1/1 pinctrl: fix unmet dependencies from missing GPIOLIB
These 4 options, PINCTRL_PIC32, PINCTRL_STMFX, PINCTRL_IPROC_GPIO, and PINCTRL_NSP_GPIO all select GPIOLIB_IRQCHIP without ensuring GPIOLIB is enabled, causing unmet dependencies, such as:
WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
Depends on [n]: GPIOLIB [=n]
Selected by [y]:
- PINCTRL_PIC32 [=y] && PINCTRL [=y] && OF [=y] && (MACH_PIC32 || COMPILE_TEST [=y])
Similar options in this subsystem select GPIOLIB, so let's do the same here.
These unmet dependency bugs were found by kconfirm, a static analysis tool for Kconfig.
---
Changes from v1:
- fix copy-paste mistake in commit message
--- drivers/pinctrl/Kconfig | 2 ++ drivers/pinctrl/bcm/Kconfig | 2 ++ 2 files changed, 4 insertions(+)
drivers/pinctrl/Kconfig +2 -0
@@ -486,6 +486,7 @@ config PINCTRL_PIC32 depends on MACH_PIC32 || COMPILE_TEST select PINMUX select GENERIC_PINCONF + select GPIOLIB select GPIOLIB_IRQCHIP help This is the pin controller and gpio driver for Microchip PIC32
@@ -562,6 +563,7 @@ config PINCTRL_STMFX depends on I2C depends on HAS_IOMEM select GENERIC_PINCONF + select GPIOLIB select GPIOLIB_IRQCHIP select MFD_STMFX help
drivers/pinctrl/bcm/Kconfig +2 -0
@@ -121,6 +121,7 @@ source "drivers/pinctrl/bcm/Kconfig.stb" config PINCTRL_IPROC_GPIO bool "Broadcom iProc GPIO (with PINCONF) driver" depends on ARCH_BCM_IPROC || COMPILE_TEST + select GPIOLIB select GPIOLIB_IRQCHIP select PINCONF select GENERIC_PINCONF
@@ -186,6 +187,7 @@ config PINCTRL_NS config PINCTRL_NSP_GPIO bool "Broadcom NSP GPIO (with PINCONF) driver" depends on ARCH_BCM_NSP || COMPILE_TEST + select GPIOLIB select GPIOLIB_IRQCHIP select PINCONF select GENERIC_PINCONF
Signature · 1 line
2.54.0
Quoted 16 lines · Julian Braha
These 4 options,
PINCTRL_PIC32,PINCTRL_STMFX,PINCTRL_IPROC_GPIO, andPINCTRL_NSP_GPIOall selectGPIOLIB_IRQCHIPwithout ensuring GPIOLIB is enabled, causing unmet dependencies, such as:WARNING: unmet direct dependencies detected for
GPIOLIB_IRQCHIP
Depends on [n]: GPIOLIB [=n]
Selected by [y]:
-PINCTRL_PIC32[=y] && PINCTRL [=y] && OF [=y] && (MACH_PIC32||COMPILE_TEST[=y])Similar options in this subsystem select GPIOLIB, so let's do the same here.
These unmet dependency bugs were found by kconfirm, a static analysis tool for
Kconfig.Fixes 2ba384e6c381 ("pinctrl: pinctrl-pic32: Add PIC32 pin control
Quoted 8 lines
driver")
Fixes 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIOdriver")
Fixes b64333ce769c ("pinctrl: cygnus: add gpio/pinconf driver")Fixes 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support forBroadcom NSP SoC")
Signed-off-by Julian Braha <[email protected]>---