blk-throttle: remove dead field last_check_time from throtl_grp
Subsystems (2)
PATCH 1/1 blk-throttle: remove dead field last_check_time from throtl_grp
From: Tao Cui <[email protected]>
The last_check_time field in throtl_grp was used by the CONFIG_BLK_DEV_THROTTLING_LOW mechanism (in throtl_upgrade_check() and the downgrade logic) to timestamp the last upgrade/downgrade check.
Commit bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW") removed all five of its uses in blk-throttle.c and the surrounding LOW fields (latency_target, last_finish_time, checked_last_finish_time, avg_idletime, idletime_threshold, bio_cnt, bad_bio_cnt, bio_cnt_reset_time), but missed the field definition itself.
It has been a dead field since then: zero references in blk-throttle.c and the whole tree. Remove it.
--- block/blk-throttle.h | 2 -- 1 file changed, 2 deletions(-)
block/blk-throttle.h +0 -2
@@ -120,8 +120,6 @@ struct throtl_grp {int64_t bytes_disp[2 ];int io_disp[2 ]; -unsigned long last_check_time; -/* When did we start a new slice */ unsigned long slice_start[2 ];unsigned long slice_end[2 ];
Signature · 1 line
2.43.0
Quoted 25 lines · Tao Cui
From: Tao Cui <[email protected]>
The
last_check_timefield inthrotl_grpwas used by theCONFIG_BLK_DEV_THROTTLING_LOWmechanism (inthrotl_upgrade_check()and the downgrade logic) to timestamp the last upgrade/downgrade check.Commit
bf20ab538c81("blk-throttle: removeCONFIG_BLK_DEV_THROTTLING_LOW") removed all five of its uses inblk-throttle.cand the surrounding LOW fields (latency_target,last_finish_time,checked_last_finish_time,avg_idletime,idletime_threshold,bio_cnt,bad_bio_cnt,bio_cnt_reset_time), but missed the field definition itself.It has been a dead field since then: zero references in
blk-throttle.cand the whole tree. Remove it.Signed-off-by Tao Cui <[email protected]>--- block/blk-throttle.h | 2 -- 1 file changed, 2 deletions(-)block/blk-throttle.h +0
-0
block/blk-throttle.h struct throtl_grp { · line 125
Quoted 8 lines
block/blk-throttle.h +0
-2@@ -120,8 +120,6 @@ struct throtl_grp {int64_t bytes_disp[2 ];int io_disp[2 ]; -unsigned long last_check_time; -/* When did we start a new slice */ unsigned long slice_start[2 ];unsigned long slice_end[2 ];
Signature · 2 lines
Best Regards, Yi
Quoted 12 lines · Tao Cui
From: Tao Cui<[email protected]>
The
last_check_timefield inthrotl_grpwas used by theCONFIG_BLK_DEV_THROTTLING_LOWmechanism (inthrotl_upgrade_check()and the downgrade logic) to timestamp the last upgrade/downgrade check.Commit
bf20ab538c81("blk-throttle: removeCONFIG_BLK_DEV_THROTTLING_LOW") removed all five of its uses inblk-throttle.cand the surrounding LOW fields (latency_target,last_finish_time,checked_last_finish_time,avg_idletime,idletime_threshold,bio_cnt,bad_bio_cnt,bio_cnt_reset_time), but missed the field definition itself.
Quoted 7 lines
It has been a dead field since then: zero references in
blk-throttle.cand the whole tree. Remove it.Signed-off-by Tao Cui<[email protected]>--- block/blk-throttle.h | 2 -- 1 file changed, 2 deletions(-)
Signature · 2 lines
Thanks, Kuai
Quoted 11 lines · Tao Cui
The
last_check_timefield inthrotl_grpwas used by theCONFIG_BLK_DEV_THROTTLING_LOWmechanism (inthrotl_upgrade_check()and the downgrade logic) to timestamp the last upgrade/downgrade check.Commit
bf20ab538c81("blk-throttle: removeCONFIG_BLK_DEV_THROTTLING_LOW") removed all five of its uses inblk-throttle.cand the surrounding LOW fields (latency_target,last_finish_time,checked_last_finish_time,avg_idletime,idletime_threshold,bio_cnt,bad_bio_cnt,bio_cnt_reset_time), but missed the field definition itself.[...]
Applied, thanks!
[1/1] blk-throttle: remove dead field last_check_time from throtl_grp
(no commit info)
Best regards,
Signature · 1 line
Jens Axboe