Skip to contentSkip to conversation

hugemmap/hugemmap38: migrate libhugetlbfs test truncate_reserve_wraparound.c

PATCH In review Pavithra 3 participants 3 messages Jul 18 – Aug 4

lore
Share & tools
lore

Pavithra

author
#0 lore raw

PATCH 1/1 hugemmap/hugemmap38: migrate libhugetlbfs test truncate_reserve_wraparound.c

This test verifies that the kernel correctly maintains hugepage reservation accounting when truncating a hugetlbfs file. It ensures that reserved hugepages are properly tracked through the complete lifecycle

---
 runtest/hugetlb                               |   1 +
 testcases/kernel/mem/.gitignore               |   1 +
 .../kernel/mem/hugetlb/hugemmap/hugemmap38.c  | 127 ++++++++++++++++++
 3 files changed, 129 insertions(+)
 create mode 100644 testcases/kernel/mem/hugetlb/hugemmap/hugemmap38.c
runtest/hugetlb +1 -0
index 8ee0e6f82..9dbee8555 100644
@@ -37,6 +37,7 @@ hugemmap31 hugemmap31
 hugemmap32 hugemmap32
 hugemmap34 hugemmap34
 hugemmap35 hugemmap35
+hugemmap38 hugemmap38
 hugemmap05_1 hugemmap05 -m
 hugemmap05_2 hugemmap05 -s
 hugemmap05_3 hugemmap05 -s -m
testcases/kernel/mem/.gitignore +1 -0
index 0e59035df..0e9547d99 100644
@@ -37,6 +37,7 @@
 /hugetlb/hugemmap/hugemmap32
 /hugetlb/hugemmap/hugemmap34
 /hugetlb/hugemmap/hugemmap35
+/hugetlb/hugemmap/hugemmap38
 /hugetlb/hugeshmat/hugeshmat01
 /hugetlb/hugeshmat/hugeshmat02
 /hugetlb/hugeshmat/hugeshmat03
testcases/kernel/mem/hugetlb/hugemmap/hugemmap38.c new file +127 -0

127 lines not on this page · raw message

Signature · 5 lines
2.55.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Pavithra,

Quoted 4 lines · Pavithra

hugemmap/hugemmap38: migrate libhugetlbfs test truncate_reserve_wraparound.c

It ensures that reserved hugepages are properly tracked through the complete lifecycle

The sentence ends without a period and "the complete lifecycle" is left unspecified. The doc comment inside the file describes the sequence as:
mmap (reserves page), touch (instantiates page), truncate (releases page), and attempted access (triggers SIGBUS). Should the commit body spell that out as well?

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
In reply to Pavithra

Hi!
Please add versions to the patch (git-format-patch with -v2, -v3, -v4) so that it's clear which patch is the latest one.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp