mm/damon/ops-common: use nr_accesses moving sum for quota score
Subsystems (3)
SJ Park
maintainerRFC PATCH 1/1 mm/damon/ops-common: use nr_accesses moving sum for quota score
Since commit 42f994b71404 ("mm/damon/core: implement scheme-specific apply interval"), DAMOS scheme can be applied at any time. At that time, nr_accesses may not be fully aggregated. But the quota prioritization score is calculated using the not fully aggregated count. As a result, the performance of DAMOS could be degraded. Fix by using damon_nr_accesses_mvsum() instead.
The user impact is suboptimum DAMOS performance under certain setups. The issue was there from the beginning of the setup availability. Hence it was the baseline for the setup. Probably that's why people didn't notice the suboptimality so far.
---
Given the user impact, this is not an urgent hotfix in my opinion. This is rather a good improvement that is better to eventually be merged into stable kernels, though.
mm/damon/ops-common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
mm/damon/ops-common.c +3 -2
@@ -111,8 +111,9 @@ int damon_hot_score(struct damon_ctx *c, struct damon_region *r,unsigned int age_weight = s->quota.weight_age;int hotness; - freq_subscore = r->nr_accesses *DAMON_MAX_SUBSCORE / -damon_nr_samples_per_aggr (&c->attrs); + freq_subscore =mult_frac (damon_nr_accesses_mvsum (r, c), +DAMON_MAX_SUBSCORE , +damon_nr_samples_per_aggr (&c->attrs)); age_in_sec = (unsigned long )r->age * c->attrs.aggr_interval /1000000 ;if (age_in_sec)
base-commit: 6f1af14da2daf85f73375ffcabcf82255970e2b5
Signature · 1 line
2.47.3