iio: dac: ad3552r-hs: fix scnprintf() buffer bound in data source show
Subsystems (2)
PATCH v3 1/1 iio: dac: ad3552r-hs: fix scnprintf() buffer bound in data source show
ad3552r_hs_show_data_source_avail() formats the available data source names into a 128-byte stack buffer, but bounds each scnprintf() with PAGE_SIZE instead of the buffer size, so the bound does not protect the destination at all.
This cannot overflow today - dbgfs_attr_source[] has two entries, "normal" and "ramp-16bit", 18 bytes formatted - but the bound stops protecting the stack the day the table grows. Use sizeof(buf) so the bound matches the destination.
Found by smatch:
drivers/iio/dac/ad3552r-hs.c:593 ad3552r_hs_show_data_source_avail()
error: scnprintf() 'buf[len]' too small (128 vs 4096)
---
v3:
- Return to the v1 fix: bound scnprintf() with sizeof(buf) instead of switching to sysfs_emit_at(). As Andy noticed in the v2 review, this is a custom debugfs read handler formatting a kernel buffer for simple_read_from_buffer(), not a sysfs show callback, so sysfs_emit_at() does not apply here:
https://lore.kernel.org/r/[email protected]
- Dropped Suggested-by and restored the v1 title; the diff is identical to v1.
v2: https://lore.kernel.org/r/[email protected]
v1: https://lore.kernel.org/r/[email protected]
drivers/iio/dac/ad3552r-hs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/dac/ad3552r-hs.c +1 -1
@@ -590,7 +590,7 @@ static ssize_t ad3552r_hs_show_data_source_avail(struct file *f,int i;for (i =0 ; i <ARRAY_SIZE (dbgfs_attr_source); i++) { - len +=scnprintf (buf + len,PAGE_SIZE - len,"%s " , + len +=scnprintf (buf + len,sizeof (buf) - len,"%s " , dbgfs_attr_source[i]); } buf[len -1 ] ='\n' ;
base-commit: fce2dfa773ced15f27dd27cd0b482a7473cdcf2a
Signature · 1 line
2.43.0
Jonathan Cameron
AppliedQuoted 10 lines · On Sat, 18 Jul 2026 18:22:36 +0000 Babanpreet Singh <[email protected]>…
ad3552r_hs_show_data_source_avail()formats the available data source names into a 128-byte stack buffer, but bounds eachscnprintf()withPAGE_SIZEinstead of the buffer size, so the bound does not protect the destination at all.This cannot overflow today - dbgfs_attr_source[] has two entries, "normal" and "ramp-16bit", 18 bytes formatted - but the bound stops protecting the stack the day the table grows. Use sizeof(buf) so the bound matches the destination.
Quoted 8 lines
Found by smatch:
drivers/iio/dac/ad3552r-hs.c:593ad3552r_hs_show_data_source_avail()
error:scnprintf()'buf[len]' too small (128 vs 4096)Fixes b1c5d68ea66e ("iio: dac: ad3552r-hs: add support for internal ramp")Assisted-by Claude:claude-sonnet-5Signed-off-by Babanpreet Singh <[email protected]>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
Quoted 32 lines
---
v3:
- Return to the v1 fix: boundscnprintf()with sizeof(buf) instead of switching tosysfs_emit_at(). As Andy noticed in the v2 review, this is a custom debugfs read handler formatting a kernel buffer forsimple_read_from_buffer(), not a sysfs show callback, sosysfs_emit_at()does not apply here:
https://lore.kernel.org/r/[email protected]
- Dropped Suggested-by and restored the v1 title; the diff is identical to v1.v2: https://lore.kernel.org/r/[email protected]
v1: https://lore.kernel.org/r/[email protected]drivers/iio/dac/ad3552r-hs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/dac/ad3552r-hs.c +1
-1@@ -590,7 +590,7 @@ static ssize_t ad3552r_hs_show_data_source_avail(struct file *f,int i;for (i =0 ; i <ARRAY_SIZE (dbgfs_attr_source); i++) { - len +=scnprintf (buf + len,PAGE_SIZE - len,"%s " , + len +=scnprintf (buf + len,sizeof (buf) - len,"%s " , dbgfs_attr_source[i]); } buf[len -1 ] ='\n' ;base-commit:
fce2dfa773ced15f27dd27cd0b482a7473cdcf2a