soc: qcom: fix unmet dependency for QCOM_PDR_MSG
Subsystems (4)
PATCH 1/1 soc: qcom: fix unmet dependency for QCOM_PDR_MSG
QCOM_PDR_MSG is defined in an 'if QCOM_SOC..endif', so its selectors QCOM_PDR_HELPERS and SLIM_QCOM_NGD_CTRL also need to ensure QCOM_SOC is enabled. Otherwise, QCOM_PDR_MSG has an unmet dependency, such as:
WARNING: unmet direct dependencies detected for QCOM_PDR_MSG
Depends on [n]: QCOM_SOC [=n]
Selected by [y]:
- QCOM_PDR_HELPERS [=y] && ARCH_QCOM [=y] && NET [=y]
This unmet dependency was found by kconfirm, a static analysis tool for Kconfig.
--- drivers/slimbus/Kconfig | 2 +- drivers/soc/qcom/Kconfig | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/slimbus/Kconfig +1 -1
@@ -17,7 +17,7 @@ config SLIM_QCOM_NGD_CTRL tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" depends on HAS_IOMEM && DMA_ENGINE && NET depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) - depends on ARCH_QCOM || COMPILE_TEST + depends on QCOM_SOC && (ARCH_QCOM || COMPILE_TEST) select QCOM_QMI_HELPERS select QCOM_PDR_HELPERS help
drivers/soc/qcom/Kconfig +2 -1
@@ -292,7 +292,7 @@ config QCOM_PBS This module provides the APIs to the client drivers that wants to send the PBS trigger event to the PBS RAM. -endif +endif # QCOM_SOC # Options selected by other drivers from different subsystems must be outside # of the menuconfig if-block:
@@ -314,6 +314,7 @@ config QCOM_PDR_HELPERS select QCOM_QMI_HELPERS select QCOM_PDR_MSG depends on NET + depends on QCOM_SOC config QCOM_QMI_HELPERS tristate
Signature · 1 line
2.54.0
Quoted 9 lines · Julian Braha
QCOM_PDR_MSGis defined in an 'if QCOM_SOC..endif', so its selectorsQCOM_PDR_HELPERSandSLIM_QCOM_NGD_CTRLalso need to ensureQCOM_SOCis enabled. Otherwise,QCOM_PDR_MSGhas an unmet dependency, such as:WARNING: unmet direct dependencies detected for
QCOM_PDR_MSG
Depends on [n]:QCOM_SOC[=n]
Selected by [y]:
-QCOM_PDR_HELPERS[=y] &&ARCH_QCOM[=y] && NET [=y]
Quoted 4 lines
This unmet dependency was found by kconfirm, a static analysis tool for
Kconfig.Fixes f2866e6a27f7 ("soc: qcom: Hide all drivers behind selectable menu")
I don't see this commit in linux-next
Quoted 11 lines
Signed-off-by Julian Braha <[email protected]>--- drivers/slimbus/Kconfig | 2 +- drivers/soc/qcom/Kconfig | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)drivers/slimbus/Kconfig +0
-0
drivers/slimbus/Kconfig config SLIM_QCOM_NGD_CTRL · line 20
Quoted 5 lines
drivers/slimbus/Kconfig +1
-1@@ -17,7 +17,7 @@ config SLIM_QCOM_NGD_CTRL tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" depends on HAS_IOMEM && DMA_ENGINE && NET depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) - depends on ARCH_QCOM || COMPILE_TEST + depends on QCOM_SOC && (ARCH_QCOM || COMPILE_TEST)
This defeats the purpose of COMPILE_TEST.
Quoted 3 lines
drivers/slimbus/Kconfig +0
-0select QCOM_QMI_HELPERS select QCOM_PDR_HELPERS help
Signature · 2 lines
With best wishes Dmitry
Quoted 4 lines · Dmitry Baryshkov
Quoted 4 lines
drivers/slimbus/Kconfig +0
-0
Quoted 8 lines
drivers/slimbus/Kconfig config SLIM_QCOM_NGD_CTRL · line 20
Quoted 6 lines
drivers/slimbus/Kconfig +1
-1@@ -17,7 +17,7 @@ config SLIM_QCOM_NGD_CTRL tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" depends on HAS_IOMEM && DMA_ENGINE && NET depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) - depends on ARCH_QCOM || COMPILE_TEST + depends on QCOM_SOC && (ARCH_QCOM || COMPILE_TEST)This defeats the purpose of
COMPILE_TEST.
The '(ARCH_QCOM || COMPILE_TEST)' is probably not even helpful here because QCOM_SOC also depends on that.
Arnd
Quoted 2 lines · Arnd Bergmann
The '(
ARCH_QCOM||COMPILE_TEST)' is probably not even helpful here becauseQCOM_SOCalso depends on that.
Nice catch, thanks Arnd. Will send a v2.
- Julian Braha
Hi Dmitry,
Quoted 1 line · Dmitry Baryshkov
I don't see this commit in linux-next
You can see it here:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=f2866e6a27f7cc26111ce195ddf00d4050bb27e5
- Julian Braha