Skip to contentSkip to conversation

dt-bindings: rtc: Convert to DT schema

PATCH Applied Eduard Bostina 5 participants 10 messages Jul 19 – Aug 31

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover dt-bindings: rtc: Convert to DT schema

This series converts the Texas Instruments Palmas RTC bindings to DT schema and resolves a node name compliance issue.

Patch 1 converts the text binding to DT schema.

Patch 2 updates the tps659038_rtc nodes across the AM57xx device trees to use the generic 'rtc' node name.

Eduard Bostina (2):
dt-bindings: rtc: Convert TI Palmas RTC to DT schema
ARM: dts: ti: omap: Fix Palmas RTC node names

 .../devicetree/bindings/rtc/rtc-palmas.txt    | 32 -----------
 .../bindings/rtc/ti,palmas-rtc.yaml           | 57 +++++++++++++++++++
 .../boot/dts/ti/omap/am5729-beagleboneai.dts  |  2 +-
 .../dts/ti/omap/am57xx-beagle-x15-common.dtsi |  2 +-
 .../boot/dts/ti/omap/am57xx-idk-common.dtsi   |  2 +-
 5 files changed, 60 insertions(+), 35 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/2 dt-bindings: rtc: Convert TI Palmas RTC to DT schema

Convert the Texas Instruments Palmas RTC controller bindings to DT schema.

As part of the conversion, declare 'wakeup-source: true'. This documents the Palmas PMIC's capability to wake the system.

---
 .../devicetree/bindings/rtc/rtc-palmas.txt    | 32 -----------
 .../bindings/rtc/ti,palmas-rtc.yaml           | 57 +++++++++++++++++++
 2 files changed, 57 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
Documentation/devicetree/bindings/rtc/rtc-palmas.txt deleted +0 -32
deleted file mode 100644
index c6cf37758a77..000000000000
@@ -1,32 +0,0 @@
-Palmas RTC controller bindings
-
-Required properties:
-- compatible:
-  - "ti,palmas-rtc" for palma series of the RTC controller
-- interrupts: Interrupt number of RTC submodule on device.
-
-Optional properties:
-
-- ti,backup-battery-chargeable: The Palmas series device like TPS65913 or
-	TPS80036 supports the backup battery for powering the RTC when main
-	battery is removed or in very low power state. The backup battery
-	can be chargeable or non-chargeable. This flag will tells whether
-	battery is chargeable or not. If charging battery then driver can
-	enable the charging.
-- ti,backup-battery-charge-high-current: Enable high current charging in
-	backup battery. Device supports the < 100uA and > 100uA charging.
-	The high current will be > 100uA. Absence of this property will
-	charge battery to lower current i.e. < 100uA.
-
-Example:
-	palmas: tps65913@58 {
-		...
-		palmas_rtc: rtc {
-			compatible = "ti,palmas-rtc";
-			interrupt-parent = <&palmas>;
-			interrupts = <8 0>;
-			ti,backup-battery-chargeable;
-			ti,backup-battery-charge-high-current;
-		};
-		...
-	};
Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml new file +57 -0

57 lines not on this page · raw message

Signature · 1 line
2.43.0
#2 lore raw

Re: [PATCH 1/2] dt-bindings: rtc: Convert TI Palmas RTC to DT schema

Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines

Convert the Texas Instruments Palmas RTC controller bindings to DT schema.

As part of the conversion, declare 'wakeup-source: true'. This documents the Palmas PMIC's capability to wake the system.

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#3 lore raw

Re: [PATCH 1/2] dt-bindings: rtc: Convert TI Palmas RTC to DT schema

In reply to Eduard Bostina
Quoted 78 lines · Eduard Bostina

Convert the Texas Instruments Palmas RTC controller bindings to DT schema.

As part of the conversion, declare 'wakeup-source: true'. This documents the Palmas PMIC's capability to wake the system.

---
 .../devicetree/bindings/rtc/rtc-palmas.txt    | 32 -----------
 .../bindings/rtc/ti,palmas-rtc.yaml           | 57 +++++++++++++++++++
 2 files changed, 57 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
Documentation/devicetree/bindings/rtc/rtc-palmas.txt deleted +0 -32
deleted file mode 100644
index c6cf37758a77..000000000000
@@ -1,32 +0,0 @@
-Palmas RTC controller bindings
-
-Required properties:
-- compatible:
-  - "ti,palmas-rtc" for palma series of the RTC controller
-- interrupts: Interrupt number of RTC submodule on device.
-
-Optional properties:
-
-- ti,backup-battery-chargeable: The Palmas series device like TPS65913 or
-	TPS80036 supports the backup battery for powering the RTC when main
-	battery is removed or in very low power state. The backup battery
-	can be chargeable or non-chargeable. This flag will tells whether
-	battery is chargeable or not. If charging battery then driver can
-	enable the charging.
-- ti,backup-battery-charge-high-current: Enable high current charging in
-	backup battery. Device supports the < 100uA and > 100uA charging.
-	The high current will be > 100uA. Absence of this property will
-	charge battery to lower current i.e. < 100uA.
-
-Example:
-	palmas: tps65913@58 {
-		...
-		palmas_rtc: rtc {
-			compatible = "ti,palmas-rtc";
-			interrupt-parent = <&palmas>;
-			interrupts = <8 0>;
-			ti,backup-battery-chargeable;
-			ti,backup-battery-charge-high-current;
-		};
-		...
-	};
Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml new file +20 -0
new file mode 100644
index 000000000000..ac64f0589c84
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/ti,palmas-rtc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas RTC
+
+maintainers:
+  - Eduard Bostina <[email protected]>
+
+allOf:
+  - $ref: /schemas/rtc/rtc.yaml#
+
+properties:
+  compatible:
+    const: ti,palmas-rtc
+
+  interrupts:
+    maxItems: 1

Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml line 30

Quoted 10 lines
Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml new file +10 -0
+
+  wakeup-source: true
+
+  ti,backup-battery-chargeable:
+    type: boolean
+    description:
+      The backup battery can be chargeable or non-chargeable. This flag
+      indicates whether the battery is chargeable. If present, the driver
+      can enable charging.
+

It would be great to convert to the genric proeprty which is aux-voltage-chargeable from rtc.yaml

Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml line 37

Quoted 7 lines
Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml new file +7 -0
+  ti,backup-battery-charge-high-current:
+    type: boolean
+    description:
+      Enable high current charging in the backup battery.
+      Device supports the < 100uA and > 100uA charging. The high current will
+      be > 100uA. Absence of this property will charge battery to lower
+      current i.e. < 100uA.

I guess we could make trickle-resistor-ohms fit or get a new generic property for this.

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
maintainer
#4 lore raw

Re: [PATCH 1/2] dt-bindings: rtc: Convert TI Palmas RTC to DT schema

Quoted 102 lines · Alexandre Belloni
Quoted 78 lines · Eduard Bostina

Convert the Texas Instruments Palmas RTC controller bindings to DT schema.

As part of the conversion, declare 'wakeup-source: true'. This documents the Palmas PMIC's capability to wake the system.

---
 .../devicetree/bindings/rtc/rtc-palmas.txt    | 32 -----------
 .../bindings/rtc/ti,palmas-rtc.yaml           | 57 +++++++++++++++++++
 2 files changed, 57 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
Documentation/devicetree/bindings/rtc/rtc-palmas.txt deleted +0 -32
deleted file mode 100644
index c6cf37758a77..000000000000
@@ -1,32 +0,0 @@
-Palmas RTC controller bindings
-
-Required properties:
-- compatible:
-  - "ti,palmas-rtc" for palma series of the RTC controller
-- interrupts: Interrupt number of RTC submodule on device.
-
-Optional properties:
-
-- ti,backup-battery-chargeable: The Palmas series device like TPS65913 or
-	TPS80036 supports the backup battery for powering the RTC when main
-	battery is removed or in very low power state. The backup battery
-	can be chargeable or non-chargeable. This flag will tells whether
-	battery is chargeable or not. If charging battery then driver can
-	enable the charging.
-- ti,backup-battery-charge-high-current: Enable high current charging in
-	backup battery. Device supports the < 100uA and > 100uA charging.
-	The high current will be > 100uA. Absence of this property will
-	charge battery to lower current i.e. < 100uA.
-
-Example:
-	palmas: tps65913@58 {
-		...
-		palmas_rtc: rtc {
-			compatible = "ti,palmas-rtc";
-			interrupt-parent = <&palmas>;
-			interrupts = <8 0>;
-			ti,backup-battery-chargeable;
-			ti,backup-battery-charge-high-current;
-		};
-		...
-	};
Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml new file +20 -0
new file mode 100644
index 000000000000..ac64f0589c84
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/ti,palmas-rtc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas RTC
+
+maintainers:
+  - Eduard Bostina <[email protected]>
+
+allOf:
+  - $ref: /schemas/rtc/rtc.yaml#
+
+properties:
+  compatible:
+    const: ti,palmas-rtc
+
+  interrupts:
+    maxItems: 1

Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml line 30

Quoted 10 lines
Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml new file +10 -0
+
+  wakeup-source: true
+
+  ti,backup-battery-chargeable:
+    type: boolean
+    description:
+      The backup battery can be chargeable or non-chargeable. This flag
+      indicates whether the battery is chargeable. If present, the driver
+      can enable charging.
+

It would be great to convert to the genric proeprty which is aux-voltage-chargeable from rtc.yaml

Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml line 37

Quoted 7 lines
Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml new file +7 -0
+  ti,backup-battery-charge-high-current:
+    type: boolean
+    description:
+      Enable high current charging in the backup battery.
+      Device supports the < 100uA and > 100uA charging. The high current will
+      be > 100uA. Absence of this property will charge battery to lower
+      current i.e. < 100uA.
Quoted 2 lines

I guess we could make trickle-resistor-ohms fit or get a new generic property for this.

Would be nice, but this is an existing binding on old h/w. We're stuck with it.

Rob

maintainer Reviewed-by on v1 1/2
#5 lore raw

Re: [PATCH 1/2] dt-bindings: rtc: Convert TI Palmas RTC to DT schema

In reply to Eduard Bostina
Quoted 6 lines · Eduard Bostina

Convert the Texas Instruments Palmas RTC controller bindings to DT schema.

As part of the conversion, declare 'wakeup-source: true'. This documents the Palmas PMIC's capability to wake the system.

Quoted 8 lines
---
 .../devicetree/bindings/rtc/rtc-palmas.txt    | 32 -----------
 .../bindings/rtc/ti,palmas-rtc.yaml           | 57 +++++++++++++++++++
 2 files changed, 57 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
maintainer Applied
#6 lore raw

Re: (subset) [PATCH 1/2] dt-bindings: rtc: Convert TI Palmas RTC to DT schema

In reply to Eduard Bostina
Quoted 8 lines · Eduard Bostina

Convert the Texas Instruments Palmas RTC controller bindings to DT schema.

As part of the conversion, declare 'wakeup-source: true'. This documents the Palmas PMIC's capability to wake the system.

[...]

Applied, thanks!

[1/2] dt-bindings: rtc: Convert TI Palmas RTC to DT schema

      https://git.kernel.org/abelloni/c/4d31434fea51

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#7 lore raw

PATCH 2/2 ARM: dts: ti: omap: Fix Palmas RTC node names

In reply to Eduard Bostina

The core RTC Device Tree schema expects RTC nodes to be named generically ('rtc' or 'rtc@...').

Update the tps659038_rtc nodes across the AM57xx device trees to use the generic 'rtc' node name to resolve dtbs_check warnings.

---
 arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts       | 2 +-
 arch/arm/boot/dts/ti/omap/am57xx-beagle-x15-common.dtsi | 2 +-
 arch/arm/boot/dts/ti/omap/am57xx-idk-common.dtsi        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts +1 -1
index 76bfb364777e..46270ed87377 100644
@@ -386,7 +386,7 @@ regen2: regen2 {
 			};
 		};
 
-		tps659038_rtc: tps659038_rtc {
+		tps659038_rtc: rtc {
 			compatible = "ti,palmas-rtc";
 			interrupt-parent = <&tps659038>;
 			interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
arch/arm/boot/dts/ti/omap/am57xx-beagle-x15-common.dtsi +1 -1
index 87b61a98d5e9..e7c186941c23 100644
@@ -360,7 +360,7 @@ regen1: regen1 {
 			};
 		};
 
-		tps659038_rtc: tps659038_rtc {
+		tps659038_rtc: rtc {
 			compatible = "ti,palmas-rtc";
 			interrupt-parent = <&tps659038>;
 			interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
arch/arm/boot/dts/ti/omap/am57xx-idk-common.dtsi +1 -1
index 5eccff3bb4b6..a2a654ef4ef9 100644
@@ -405,7 +405,7 @@ regen2: regen2 {
 			};
 		};
 
-		tps659038_rtc: tps659038_rtc {
+		tps659038_rtc: rtc {
 			compatible = "ti,palmas-rtc";
 			interrupt-parent = <&tps659038>;
 			interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
Signature · 1 line
2.43.0
#8 lore raw

Re: [PATCH 2/2] ARM: dts: ti: omap: Fix Palmas RTC node names

Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines

The core RTC Device Tree schema expects RTC nodes to be named generically ('rtc' or 'rtc@...').

Update the tps659038_rtc nodes across the AM57xx device trees to use the generic 'rtc' node name to resolve dtbs_check warnings.

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
maintainer Applied
#9 lore raw

Re: (subset) [PATCH 0/2] dt-bindings: rtc: Convert to DT schema

In reply to Eduard Bostina
Quoted 9 lines · Eduard Bostina

This series converts the Texas Instruments Palmas RTC bindings to DT schema and resolves a node name compliance issue.

Patch 1 converts the text binding to DT schema.

Patch 2 updates the tps659038_rtc nodes across the AM57xx device trees to use the generic 'rtc' node name.

[...]

Applied, thanks!

[2/2] ARM: dts: ti: omap: Fix Palmas RTC node names

      commit: eaeb86b1194ef162254059ba6a2c5145d1ed7ef1

Best regards,

Signature · 1 line
Kevin Hilman (TI) <[email protected]>