Skip to contentSkip to conversation

media: i2c: ov9282: restore flash duration calculation

PATCH New Richard Leitner 1 participant 1 message Jul 20

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: i2c: ov9282: restore flash duration calculation

The migration to CCI helpers made V4L2_CID_FLASH_DURATION write the requested duration directly to OV9282_REG_STROBE_FRAME_SPAN, dropping the conversion from microseconds to the register value.

This made flash strobes too long and produced overly bright frames. Restore the missing calculation so flash duration is programmed correctly again.

Fixes 273f52f3cbec ("media: i2c: ov9282: Convert to CCI register access helpers")
Cc Xiaolei Wang <[email protected]>
---
 drivers/media/i2c/ov9282.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/i2c/ov9282.c +2 -1
index 5b6f897a74fcd..5abe51d21f89c 100644
@@ -648,7 +648,8 @@ static int ov9282_set_ctrl(struct v4l2_ctrl *ctrl)
 				      ctrl->val ? OV9282_OUTPUT_ENABLE6_STROBE : 0, NULL);
 		break;
 	case V4L2_CID_FLASH_DURATION:
-		ret = cci_write(ov9282->regmap, OV9282_REG_STROBE_FRAME_SPAN, ctrl->val, NULL);
+		ret = cci_write(ov9282->regmap, OV9282_REG_STROBE_FRAME_SPAN,
+				ov9282_us_to_flash_duration(ov9282, ctrl->val), NULL);
 		break;
 	default:
 		dev_err(ov9282->dev, "Invalid control %d", ctrl->id);

---
base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f
change-id: 20260720-ov9282-fix-ece641dc7a88

Best regards,

Signature · 1 line
Richard Leitner <[email protected]>