Skip to contentSkip to conversation

ARM: select HAVE_POSIX_CPU_TIMERS_TASK_WORK

PATCH In review Karl Mehltretter 3 participants 3 messages Jul 18 – Jul 20

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: select HAVE_POSIX_CPU_TIMERS_TASK_WORK

Commit c6e61c06d606 ("ARM: 9463/1: Allow to enable RT") enabled PREEMPT_RT on ARM but did not select HAVE_POSIX_CPU_TIMERS_TASK_WORK. This leaves CONFIG_POSIX_CPU_TIMERS_TASK_WORK disabled, so CPU timers expire in hard IRQ context.

On PREEMPT_RT this makes run_posix_cpu_timers() take the sleeping sighand->siglock:

  BUG: sleeping function called from invalid context at spinlock_rt.c:48
    rt_spin_lock from lock_task_sighand
    lock_task_sighand from run_posix_cpu_timers
    run_posix_cpu_timers from update_process_times

ARM handles TIF_NOTIFY_RESUME on all return-to-user paths, including v7-M. ARM32 KVM host support was removed by commit 541ad0150ca4 ("arm: Remove 32bit KVM host support"), so the select need not be conditional on KVM.

Select it to defer POSIX CPU timer expiry to task context.

Reproduced with setrlimit(RLIMIT_CPU, ...) and a busy loop. The same path is used by setitimer(ITIMER_PROF or ITIMER_VIRTUAL) and POSIX CPU timers created with timer_create().

Fixes c6e61c06d606 ("ARM: 9463/1: Allow to enable RT")
Assisted-by Claude:claude-fable-5

---
Found with a self-hosted syzkaller instance patched to fuzz kernels on QEMU's versatilepb machine (ARM926EJ-S, ARMv5TE). Runtime-tested before and after the change on that setup, and compile-tested mps2_defconfig with PREEMPT_RT (NOMMU, CPU_V7M).

 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +1 -0
index 9187240a02db..f073b5102d4e 100644
@@ -133,6 +133,7 @@ config ARM
 	select HAVE_PERF_EVENTS
 	select HAVE_PERF_REGS
 	select HAVE_PERF_USER_STACK_DUMP
+	select HAVE_POSIX_CPU_TIMERS_TASK_WORK
 	select MMU_GATHER_RCU_TABLE_FREE if SMP && ARM_LPAE
 	select HAVE_REGS_AND_STACK_ACCESS_API
 	select HAVE_RSEQ
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Karl Mehltretter

Commit c6e61c06d606 ("ARM: 9463/1: Allow to enable RT") enabled PREEMPT_RT on ARM but did not select HAVE_POSIX_CPU_TIMERS_TASK_WORK. This leaves CONFIG_POSIX_CPU_TIMERS_TASK_WORK disabled, so CPU timers expire in hard IRQ context.

On PREEMPT_RT this makes run_posix_cpu_timers() take the sleeping sighand->siglock:

  BUG: sleeping function called from invalid context at spinlock_rt.c:48
    rt_spin_lock from lock_task_sighand
    lock_task_sighand from run_posix_cpu_timers
    run_posix_cpu_timers from update_process_times

ARM handles TIF_NOTIFY_RESUME on all return-to-user paths, including v7-M. ARM32 KVM host support was removed by commit 541ad0150ca4 ("arm: Remove 32bit KVM host support"), so the select need not be conditional on KVM.

Select it to defer POSIX CPU timer expiry to task context.

Quoted 7 lines

Reproduced with setrlimit(RLIMIT_CPU, ...) and a busy loop. The same path is used by setitimer(ITIMER_PROF or ITIMER_VIRTUAL) and POSIX CPU timers created with timer_create().

Fixes c6e61c06d606 ("ARM: 9463/1: Allow to enable RT")
Assisted-by Claude:claude-fable-5

Indeed selecting HAVE_POSIX_CPU_TIMERS_TASK_WORK was previously part of the RT patch [1] set but got lost during one of the updates before the patch got merged.

Quoted 3 lines

Found with a self-hosted syzkaller instance patched to fuzz kernels on QEMU's versatilepb machine (ARM926EJ-S, ARMv5TE). Runtime-tested before and after the change on that setup

Good to hear that this configuration works with your patch, I don't think many people have tested ARMv5 RT recently.

Arnd

[1] https://lore.kernel.org/all/[email protected]/

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Karl Mehltretter
Quoted 4 lines · Karl Mehltretter

Commit c6e61c06d606 ("ARM: 9463/1: Allow to enable RT") enabled PREEMPT_RT on ARM but did not select HAVE_POSIX_CPU_TIMERS_TASK_WORK. This leaves CONFIG_POSIX_CPU_TIMERS_TASK_WORK disabled, so CPU timers expire in hard IRQ context.

…

Quoted 3 lines
Fixes c6e61c06d606 ("ARM: 9463/1: Allow to enable RT")
Assisted-by Claude:claude-fable-5
Quoted 4 lines

Found with a self-hosted syzkaller instance patched to fuzz kernels on QEMU's versatilepb machine (ARM926EJ-S, ARMv5TE). Runtime-tested before and after the change on that setup, and compile-tested mps2_defconfig with PREEMPT_RT (NOMMU, CPU_V7M).

I obviously got the rules confused while dropping the KVM patches.

Sebastian