ASoC: stm: Drop redundant error message
Subsystems (4)
cover ASoC: stm: Drop redundant error message
From: bui duc phuc <[email protected]>
Hi all,
This series removes redundant error messages across multiple STM32 ASoC drivers. Since core functions already log failures internally, dropping these explicit dev_err() blocks prevents duplicate log messages and cleans up the code.
Compile-tested only.
Best regards,
Phuc
bui duc phuc (4):
ASoC: stm: stm32_adfsdm: Drop redundant error message
ASoC: stm: stm32_i2s: Drop redundant error messages
ASoC: stm: stm32_sai_sub: Drop redundant error messages
ASoC: stm: stm32_spdifrx: Drop redundant error messages
sound/soc/stm/stm32_adfsdm.c | 5 +---- sound/soc/stm/stm32_i2s.c | 6 ++---- sound/soc/stm/stm32_sai_sub.c | 8 ++------ sound/soc/stm/stm32_spdifrx.c | 6 ++---- 4 files changed, 7 insertions(+), 18 deletions(-)
Signature · 1 line
2.43.0
PATCH 1/4 ASoC: stm: stm32_adfsdm: Drop redundant error message
From: bui duc phuc <[email protected]>
devm_snd_soc_register_component() already logs the failure internally. Drop the redundant error message and return the original error directly.
--- sound/soc/stm/stm32_adfsdm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
sound/soc/stm/stm32_adfsdm.c +1 -4
@@ -360,11 +360,8 @@ static int stm32_adfsdm_probe(struct platform_device *pdev) ret =devm_snd_soc_register_component (&pdev->dev, &stm32_adfsdm_soc_platform,NULL ,0 ); -if (ret <0 ) { -dev_err (&pdev->dev,"%s: Failed to register PCM platform\n" , - __func__); +if (ret <0 )return ret; - }pm_runtime_enable (&pdev->dev);
Signature · 1 line
2.43.0
PATCH 2/4 ASoC: stm: stm32_i2s: Drop redundant error messages
In reply to [email protected]From: bui duc phuc <[email protected]>
Both devm_request_irq() and snd_dmaengine_pcm_register() already log failures internally. Drop the redundant error messages and return the original errors directly.
--- sound/soc/stm/stm32_i2s.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
sound/soc/stm/stm32_i2s.c +2 -4
@@ -1238,10 +1238,8 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev, ret =devm_request_irq (&pdev->dev, irq, stm32_i2s_isr,0 ,dev_name (&pdev->dev), i2s); -if (ret) { -dev_err (&pdev->dev,"irq request returned %d\n" , ret); +if (ret)return ret; - }/* Reset */ rst =devm_reset_control_get_optional_exclusive (&pdev->dev,NULL );
@@ -1295,7 +1293,7 @@ static int stm32_i2s_probe(struct platform_device *pdev) ret =snd_dmaengine_pcm_register (&pdev->dev, &stm32_i2s_pcm_config,0 );if (ret) -return dev_err_probe (&pdev->dev, ret,"PCM DMA register error\n" ); +return ret; ret =snd_soc_register_component (&pdev->dev, &stm32_i2s_component, i2s->dai_drv,1 );
Signature · 1 line
2.43.0
PATCH 3/4 ASoC: stm: stm32_sai_sub: Drop redundant error messages
In reply to [email protected]From: bui duc phuc <[email protected]>
Both devm_request_irq() and snd_dmaengine_pcm_register() already log failures internally. Drop the redundant error messages and return the original errors directly.
--- sound/soc/stm/stm32_sai_sub.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
sound/soc/stm/stm32_sai_sub.c +2 -6
@@ -1696,19 +1696,15 @@ static int stm32_sai_sub_probe(struct platform_device *pdev) ret =devm_request_irq (&pdev->dev, sai->pdata->irq, stm32_sai_isr,IRQF_SHARED ,dev_name (&pdev->dev), sai); -if (ret) { -dev_err (&pdev->dev,"IRQ request returned %d\n" , ret); +if (ret) goto err_unprepare_pclk; - }if (STM_SAI_PROTOCOL_IS_SPDIF (sai)) conf = &stm32_sai_pcm_config_spdif; ret =snd_dmaengine_pcm_register (&pdev->dev, conf,0 ); -if (ret) { - ret =dev_err_probe (&pdev->dev, ret,"Could not register pcm dma\n" ); +if (ret) goto err_unprepare_pclk; - } ret =snd_soc_register_component (&pdev->dev, &stm32_component, &sai->cpu_dai_drv,1 );
Signature · 1 line
2.43.0
PATCH 4/4 ASoC: stm: stm32_spdifrx: Drop redundant error messages
In reply to [email protected]From: bui duc phuc <[email protected]>
Both devm_request_irq() and snd_dmaengine_pcm_register() already log failures internally. Drop the redundant error messages and return the original errors directly.
--- sound/soc/stm/stm32_spdifrx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
sound/soc/stm/stm32_spdifrx.c +2 -4
@@ -970,10 +970,8 @@ static int stm32_spdifrx_probe(struct platform_device *pdev) ret =devm_request_irq (&pdev->dev, spdifrx->irq, stm32_spdifrx_isr,0 ,dev_name (&pdev->dev), spdifrx); -if (ret) { -dev_err (&pdev->dev,"IRQ request returned %d\n" , ret); +if (ret)return ret; - } rst =devm_reset_control_get_optional_exclusive (&pdev->dev,NULL );if (IS_ERR (rst))
@@ -987,7 +985,7 @@ static int stm32_spdifrx_probe(struct platform_device *pdev) pcm_config = &stm32_spdifrx_pcm_config; ret =snd_dmaengine_pcm_register (&pdev->dev, pcm_config,0 );if (ret) -return dev_err_probe (&pdev->dev, ret,"PCM DMA register error\n" ); +return ret; ret = snd_soc_register_component(&pdev->dev, &stm32_spdifrx_component,
Signature · 1 line
2.43.0
Mark Brown
maintainerQuoted 6 lines · On Mon, 20 Jul 2026 14:40:39 +0700, [email protected] wrote:
ASoC: stm: Drop redundant error message
From: bui duc phuc <[email protected]>
Hi all,
Quoted 7 lines
This series removes redundant error messages across multiple STM32 ASoC drivers. Since core functions already log failures internally, dropping these explicit
dev_err()blocks prevents duplicate log messages and cleans up the code.
Compile-tested only.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3
Thanks!
[1/4] ASoC: stm: stm32_adfsdm: Drop redundant error message
https://git.kernel.org/broonie/sound/c/30df43c14050 [2/4] ASoC: stm: stm32_i2s: Drop redundant error messages https://git.kernel.org/broonie/sound/c/a6cdfb623094 [3/4] ASoC: stm: stm32_sai_sub: Drop redundant error messages https://git.kernel.org/broonie/sound/c/e502adb1cdd6 [4/4] ASoC: stm: stm32_spdifrx: Drop redundant error messages https://git.kernel.org/broonie/sound/c/94495c842711
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark