thermal: spacemit: validate clamped trip thresholds
Subsystems (3)
PATCH 1/1 thermal: spacemit: validate clamped trip thresholds
From: surendra <[email protected]>
k1_tsensor_set_trips() checks the requested trip temperatures before converting them to the sensor register representation. Distinct out-of-range temperatures can clamp to the same hardware value, leaving the sensor with an invalid low/high threshold pair.
Validate the ordering after conversion and clamping.
Fixes 296a977f2bac ("thermal/drivers/spacemit/k1: Add thermal sensor support")
Signed-off-by surendra <[email protected]>
--- drivers/thermal/spacemit/k1_tsensor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/thermal/spacemit/k1_tsensor.c +2 -3
@@ -156,13 +156,12 @@ static int k1_tsensor_set_trips(struct thermal_zone_device *tz, int low, int higstruct k1_tsensor *ts = ch->ts;u32 val; -if (low >= high) -return -EINVAL ; - low =clamp_val (low /1000 +TEMPERATURE_OFFSET ,TEMPERATURE_OFFSET ,FIELD_MAX (K1_TSENSOR_THRSH_LOW_MASK )); high =clamp_val (high /1000 +TEMPERATURE_OFFSET ,TEMPERATURE_OFFSET ,FIELD_MAX (K1_TSENSOR_THRSH_HIGH_MASK )); +if (low >= high) +return -EINVAL ; val =readl (ts->base +K1_TSENSOR_THRSH_REG (ch->id));
Signature · 1 line
2.55.0