s390/maccess: use proper PTE accessors for copying old memory
Alexander Gordeev
maintainerPATCH 1/1 s390/maccess: use proper PTE accessors for copying old memory
Follow the pattern established by commit c33c794828f2 ("mm:ptep_get() conversion") and use proper PTE accessors instead of a direct pointer dereference in memcpy_real_iter().
--- arch/s390/mm/maccess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/mm/maccess.c +1 -1
@@ -96,7 +96,7 @@ size_t memcpy_real_iter(struct iov_iter *iter, unsigned long src, size_t count) pte =mk_pte_phys (phys,PAGE_KERNEL_RO );mutex_lock (&memcpy_real_mutex); -if (pte_val (pte) !=pte_val (*memcpy_real_ptep)) { +if (pte_val (pte) !=pte_val (ptep_get (memcpy_real_ptep))) {__ptep_ipte (__memcpy_real_area, memcpy_real_ptep,0 ,0 ,IPTE_GLOBAL );set_pte (memcpy_real_ptep, pte); }
Signature · 1 line
2.53.0
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 5 lines
Follow the pattern established by commit
c33c794828f2("mm:ptep_get()conversion") and use proper PTE accessors instead of a direct pointer dereference inmemcpy_real_iter().Signed-off-by Alexander Gordeev <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 8 lines · Alexander Gordeev
Follow the pattern established by commit
c33c794828f2("mm:ptep_get()conversion") and use proper PTE accessors instead of a direct pointer dereference inmemcpy_real_iter().Signed-off-by Alexander Gordeev <[email protected]>--- arch/s390/mm/maccess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch subject needs to be fixed. Upper case "Use". Besides that:
Quoted 8 lines · Alexander Gordeev
Follow the pattern established by commit
c33c794828f2("mm:ptep_get()conversion") and use proper PTE accessors instead of a direct pointer dereference inmemcpy_real_iter().Signed-off-by Alexander Gordeev <[email protected]>--- arch/s390/mm/maccess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thank you!