Skip to contentSkip to conversation

libsimplelog: upgrade 1.0.8 -> 1.1.0

PATCH In review Thuận Nguyễn-Thái 2 participants 2 messages Jul 20

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libsimplelog: upgrade 1.0.8 -> 1.1.0

Add note to answer from meta-openembedded maintainer: Khem Raj

And explain -D__LINUX__=1, -D_GNU_SOURCE=1 and musl (strictly POSIX)

---
 .../libsimplelog/libsimplelog_1.1.0.bb           | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
meta-oe/recipes-support/libsimplelog/libsimplelog_1.1.0.bb +13 -3
index 53c13d726b..7a385d537b 100644
@@ -3,17 +3,27 @@ SUMMARY = "simplelog-topc - Simple, STABLE, powerful of logging library in ANSI
 DESCRIPTION = "Async and Fast C/C++ multi-thread logger with topics. No external dependencies."
 HOMEPAGE = "https://github.com/thuanalg/simplelog-topic"
 LICENSE = "MIT"
+#The checksum of "LIC_FILES_CHKSUM" changed b/c I did change from "2024" to "2024-2026"
+#libsimplelog  is allways full "MIT license".
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=594fdc3cb85f0b684cf5d7b332a741be"
 
 SRC_URI = "git://github.com/thuanalg/simplelog-topic.git;branch=main;protocol=https;tag=v${PV}"
 
 SRCREV = "151e83902ca9755bcd285791d2f49de6fc30bfe6"
 
-S = "${WORKDIR}/git"
-
 inherit cmake
 
-# Specify any options you want to pass to cmake using EXTRA_OECMAKE:
 EXTRA_OECMAKE += "-DUNIX_LINUX=1 -D__LINUX__=1 -D_GNU_SOURCE=1"
 
+# From v.1.0.8 -> v1.1.0
+# Note for -D__LINUX__=1 -D_GNU_SOURCE=1
+# If don't use these flags, v.1.1.0 works like v1.0.8, and well adapt with musl (strictly POSIX)
+# If use 2 flags, they helps the source is more effective. Please test for 2 cases, you will see.
+# Please check "p->r = sched_getcpu();" in "simplelog.c"
+# You can use as below without any problem
+# EXTRA_OECMAKE += "-DUNIX_LINUX=1"
+
+# Drop 0001-allow-build-with-cmake-4.patch as it is now integrated upstream. 
+# Please see branch "main", commit "4827c4325063266f6d2a7e133a9d3a9050ff6a3c" by 
+# Author: Alper Ak <[email protected]>
 
Signature · 1 line
2.43.0
#1 lore raw

Second patch in this series needs similar fix. Please rework that as well and send v2

Quoted 71 lines · Thuận Nguyễn-Thái via lists.openembedded.org

Add note to answer from meta-openembedded maintainer: Khem Raj

And explain -D__LINUX__=1, -D_GNU_SOURCE=1 and musl (strictly POSIX)

---
 .../libsimplelog/libsimplelog_1.1.0.bb           | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
meta-oe/recipes-support/libsimplelog/libsimplelog_1.1.0.bb +0 -0
index 53c13d726b..7a385d537b 100644
@@ -3,17 +3,27 @@ SUMMARY = "simplelog-topc - Simple, STABLE, powerful of

logging library in ANSI
DESCRIPTION = "Async and Fast C/C++ multi-thread logger with topics. No
external dependencies."
HOMEPAGE = "https://github.com/thuanalg/simplelog-topic" LICENSE = "MIT"
+#The checksum of "LIC_FILES_CHKSUM" changed b/c I did change from "2024" to "2024-2026"
+#libsimplelog is allways full "MIT license".
LIC_FILES_CHKSUM =
"file://LICENSE.txt;md5=594fdc3cb85f0b684cf5d7b332a741be"

SRC_URI = "git://
github.com/thuanalg/simplelog-topic.git;branch=main;protocol=https;tag=v${PV}
<http://github.com/thuanalg/simplelog-topic.git;branch=main;protocol=https;tag=v$%7BPV%7D>
"

SRCREV = "151e83902ca9755bcd285791d2f49de6fc30bfe6"

meta-oe/recipes-support/libsimplelog/libsimplelog_1.1.0.bb +3 -3
-S = "${WORKDIR}/git"
-
 inherit cmake
 
-# Specify any options you want to pass to cmake using EXTRA_OECMAKE:
 EXTRA_OECMAKE += "-DUNIX_LINUX=1 -D__LINUX__=1 -D_GNU_SOURCE=1"
 
+# From v.1.0.8 -> v1.1.0
+# Note for -D__LINUX__=1 -D_GNU_SOURCE=1
+# If don't use these flags, v.1.1.0 works like v1.0.8, and well adapt

with musl (strictly POSIX)
+# If use 2 flags, they helps the source is more effective. Please test for 2 cases, you will see.

meta-oe/recipes-support/libsimplelog/libsimplelog_1.1.0.bb +5 -0
+# Please check "p->r = sched_getcpu();" in "simplelog.c"
+# You can use as below without any problem
+# EXTRA_OECMAKE += "-DUNIX_LINUX=1"
+
+# Drop 0001-allow-build-with-cmake-4.patch as it is now integrated

upstream.
+# Please see branch "main", commit
"4827c4325063266f6d2a7e133a9d3a9050ff6a3c" by
+# Author: Alper Ak <[email protected]>

--
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#128280):
https://lists.openembedded.org/g/openembedded-devel/message/128280
Mute This Topic: https://lists.openembedded.org/mt/120361632/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-