FAILED: patch "[PATCH] regulator: scmi: fix of_node refcount leak in" failed to apply to 5.15-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y
git checkout FETCH_HEAD
git cherry-pick -x fa11039d6cdff84584a3ef8cc1f5e1b56e045da2
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026071525-curtly-mothproof-9d7c@gregkh' --subject-prefix 'PATCH 5.15.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From fa11039d6cdff84584a3ef8cc1f5e1b56e045da2 Mon Sep 17 00:00:00 2001
From: Wentao Liang <[email protected]>
Date: Wed, 27 May 2026 10:48:50 +0000
Subject: [PATCH] regulator: scmi: fix of_node refcount leak in
scmi_regulator_probe()
scmi_regulator_probe() calls of_find_node_by_name() which takes a reference on the returned device node. On the error path where process_scmi_regulator_of_node() fails, the function returns without calling of_node_put() on the child node, leaking the reference.
Add of_node_put(np) on the error path to properly release the reference.
drivers/regulator/scmi-regulator.c +3 -1
@@ -345,8 +345,10 @@ static int scmi_regulator_probe(struct scmi_device *sdev)for_each_child_of_node_scoped (np, child) { ret =process_scmi_regulator_of_node (sdev, ph, child, rinfo);/* abort on any mem issue */ -if (ret == -ENOMEM ) +if (ret == -ENOMEM ) { +of_node_put (np);return ret; + } }of_node_put (np);/*
Sasha Levin
maintainerPATCH 1/1 regulator: scmi: fix of_node refcount leak in scmi_regulator_probe()
From: Wentao Liang <[email protected]>
[ Upstream commit fa11039d6cdff84584a3ef8cc1f5e1b56e045da2 ]
scmi_regulator_probe() calls of_find_node_by_name() which takes a reference on the returned device node. On the error path where process_scmi_regulator_of_node() fails, the function returns without calling of_node_put() on the child node, leaking the reference.
Add of_node_put(np) on the error path to properly release the reference.
--- drivers/regulator/scmi-regulator.c | 1 + 1 file changed, 1 insertion(+)
drivers/regulator/scmi-regulator.c +1 -0
@@ -350,6 +350,7 @@ static int scmi_regulator_probe(struct scmi_device *sdev)/* abort on any mem issue */ if (ret == -ENOMEM ) {of_node_put (child); +of_node_put (np);return ret; } }
Signature · 1 line
2.53.0