geneve: fix geneve_config leak on register_netdevice() failure
Subsystems (2)
PATCH 1/1 geneve: fix geneve_config leak on register_netdevice() failure
When geneve_configure() allocates a new geneve_config structure via geneve_config_alloc() and assigns it to geneve->cfg before calling register_netdevice(), if register_netdevice() fails early (for example, in dev_get_valid_name() due to an invalid or duplicate interface name), register_netdevice() exits without calling dev->priv_destructor.
The caller (e.g. rtnl_newlink()) subsequently calls free_netdev(), which frees the net_device structure directly via kvfree() because reg_state is NETREG_UNINITIALIZED, bypassing dev->priv_destructor (geneve_free_dev()). As a result, the newly allocated geneve_config and its per-CPU dst_cache are leaked.
Fix this by invoking geneve_free_dev(dev) directly on the error path of register_netdevice(). Since geneve_free_dev() sets geneve->cfg to NULL, this call is fully idempotent and safe even if register_netdevice() failed on a later error path that already ran dev->priv_destructor.
--- drivers/net/geneve.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/geneve.c +3 -1
@@ -2043,8 +2043,10 @@ static int geneve_configure(struct net *net, struct net_device *dev, } err =register_netdevice (dev); -if (err) +if (err) { +geneve_free_dev (dev);return err; + }list_add (&geneve->next, &gn->geneve_list);return 0 ;
Signature · 1 line
2.55.0.229.g6434b31f56-goog
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 6 lines · On Tue, 21 Jul 2026 16:39:50 +0000 you wrote:
When
geneve_configure()allocates a newgeneve_configstructure viageneve_config_alloc()and assigns it togeneve->cfgbefore callingregister_netdevice(), ifregister_netdevice()fails early (for example, indev_get_valid_name()due to an invalid or duplicate interface name),register_netdevice()exits without callingdev->priv_destructor.
Quoted 7 lines
The caller (e.g.
rtnl_newlink()) subsequently callsfree_netdev(), which frees thenet_devicestructure directly viakvfree()becausereg_stateisNETREG_UNINITIALIZED, bypassingdev->priv_destructor(geneve_free_dev()). As a result, the newly allocatedgeneve_configand its per-CPUdst_cacheare leaked.[...]
Here is the summary with links:
- [net-next] geneve: fix geneve_config leak on register_netdevice() failure
https://git.kernel.org/netdev/net-next/c/24d0af194bcc
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html