Skip to contentSkip to conversation

fsck.f2fs: flush device buffer before zone transition on zoned storage

PATCH In review Daeho Jeong 2 participants 3 messages Jul 21 – Jul 22

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fsck.f2fs: flush device buffer before zone transition on zoned storage

From: Daeho Jeong <[email protected]>

On zoned storage devices (F2FS_ZONED_HM), fsck.f2fs opens block devices with buffered I/O (O_RDWR). When a curseg fills up its current zone and moves to a new zone in find_next_free_block(), pending buffered writes to the previous zone may still reside in the OS page cache / I/O queue.

As a result, issuing a write to the newly allocated zone can happen before the device hardware finishes committing all blocks of the previous zone, causing the hardware to see an additional open zone request that exceeds the device's max open zone limit (e.g. open zones exceeded error).

Fix this by calling f2fs_fsync_device() right before allocating a new zone when crossing zone boundaries (!(segno % segs_per_zone)). This flushes all pending writes to physical media, ensuring the device hardware auto-closes (FULL) the previous zone before opening the new zone.

---
 fsck/mount.c | 3 +++
 1 file changed, 3 insertions(+)
fsck/mount.c +3 -0
index 6f640a0..3bd40fe 100644
@@ -3073,6 +3073,9 @@ int find_next_free_block(struct f2fs_sb_info *sbi, u64 *to, int left,
 			if (!(segno % segs_per_zone)) {
 				u64 new_blkaddr = SM_I(sbi)->main_blkaddr;
 
+				if (c.zoned_model == F2FS_ZONED_HM)
+					f2fs_fsync_device();
+
 				ret = find_next_free_block(sbi, &new_blkaddr, 0,
 						want_type, true);
 				if (ret)
Signature · 1 line
2.55.0.229.g6434b31f56-goog
#1 lore raw
Quoted 25 lines · Daeho Jeong

On zoned storage devices (F2FS_ZONED_HM), fsck.f2fs opens block devices with buffered I/O (O_RDWR). When a curseg fills up its current zone and moves to a new zone in find_next_free_block(), pending buffered writes to the previous zone may still reside in the OS page cache / I/O queue.

As a result, issuing a write to the newly allocated zone can happen before the device hardware finishes committing all blocks of the previous zone, causing the hardware to see an additional open zone request that exceeds the device's max open zone limit (e.g. open zones exceeded error).

Fix this by calling f2fs_fsync_device() right before allocating a new zone when crossing zone boundaries (!(segno % segs_per_zone)). This flushes all pending writes to physical media, ensuring the device hardware auto-closes (FULL) the previous zone before opening the new zone.

---
  fsck/mount.c | 3 +++
  1 file changed, 3 insertions(+)
fsck/mount.c +0 -0
index 6f640a0..3bd40fe 100644

fsck/mount.c int find_next_free_block(struct f2fs_sb_info *sbi, u64 *to, int left, · line 3081

Quoted 9 lines
fsck/mount.c +3 -0
@@ -3073,6 +3073,9 @@ int find_next_free_block(struct f2fs_sb_info *sbi, u64 *to, int left,
  			if (!(segno % segs_per_zone)) {
  				u64 new_blkaddr = SM_I(sbi)->main_blkaddr;
 
+				if (c.zoned_model == F2FS_ZONED_HM)
+					f2fs_fsync_device();
+
  				ret = find_next_free_block(sbi, &new_blkaddr, 0,
  						want_type, true);
  				if (ret)

Will this change make a difference on Android because the Android f2fs-tools already use O_DSYNC when opening a zoned block device? From lib/libf2fs.c:

                if (dev->zoned_model == F2FS_ZONED_HM)
                        flags |= O_DSYNC;

See also commit 10dad5ed7ce1 ("f2fs-tools: support zoned ufs devices").

Thanks,

Bart.

#2 lore raw
Quoted 41 lines · Bart Van Assche
Quoted 25 lines · Daeho Jeong

On zoned storage devices (F2FS_ZONED_HM), fsck.f2fs opens block devices with buffered I/O (O_RDWR). When a curseg fills up its current zone and moves to a new zone in find_next_free_block(), pending buffered writes to the previous zone may still reside in the OS page cache / I/O queue.

As a result, issuing a write to the newly allocated zone can happen before the device hardware finishes committing all blocks of the previous zone, causing the hardware to see an additional open zone request that exceeds the device's max open zone limit (e.g. open zones exceeded error).

Fix this by calling f2fs_fsync_device() right before allocating a new zone when crossing zone boundaries (!(segno % segs_per_zone)). This flushes all pending writes to physical media, ensuring the device hardware auto-closes (FULL) the previous zone before opening the new zone.

---
  fsck/mount.c | 3 +++
  1 file changed, 3 insertions(+)
fsck/mount.c +0 -0
index 6f640a0..3bd40fe 100644

fsck/mount.c int find_next_free_block(struct f2fs_sb_info *sbi, u64 *to, int left, · line 3081

Quoted 9 lines
fsck/mount.c +3 -0
@@ -3073,6 +3073,9 @@ int find_next_free_block(struct f2fs_sb_info *sbi, u64 *to, int left,
                      if (!(segno % segs_per_zone)) {
                              u64 new_blkaddr = SM_I(sbi)->main_blkaddr;
 
+                             if (c.zoned_model == F2FS_ZONED_HM)
+                                     f2fs_fsync_device();
+
                              ret = find_next_free_block(sbi, &new_blkaddr, 0,
                                              want_type, true);
                              if (ret)

Will this change make a difference on Android because the Android f2fs-tools already use O_DSYNC when opening a zoned block device?
From lib/libf2fs.c:

Quoted 4 lines
                 if (dev->zoned_model == F2FS_ZONED_HM)
                         flags |= O_DSYNC;

See also commit 10dad5ed7ce1 ("f2fs-tools: support zoned ufs devices").

Oops, we already have this patch upstream.
Plz, ignore this patch.

Bart, thanks for letting me know this.

Quoted 5 lines

Thanks,

Bart.