Skip to contentSkip to conversation

HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB

PATCH In review Stuart Hayhurst 3 participants 4 messages Jul 21 – Aug 3

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB

The ID appears to be given twice, remove the duplicate

---
 drivers/hid/hid-logitech-hidpp.c | 2 --
 1 file changed, 2 deletions(-)
drivers/hid/hid-logitech-hidpp.c +0 -2
index 90b0184df777..b1b1c5cb657c 100644
@@ -4659,8 +4659,6 @@ static const struct hid_device_id hidpp_devices[] = {
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
 	{ /* MX Vertical over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
-	{ /* Logitech G703 Hero Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
 	{ /* Logitech G903 Hero Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) },
 	{ /* Logitech G915 TKL Keyboard over USB */
Signature · 1 line
2.53.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Stuart Hayhurst

The ID appears to be given twice, remove the duplicate

Indeed, at line 4652:
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
{ /* Logitech G900 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) },
{ /* Logitech G903 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) },
{ /* Logitech G Pro Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
{ /* MX Vertical over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },

Benjamin, Jiri, is there not a way to detect duplicates like this?

In any case, looks good to me.

Quoted 19 lines

---
 drivers/hid/hid-logitech-hidpp.c | 2 --

 1 file changed, 2 deletions(-)
drivers/hid/hid- renamed from drivers/hid/hid-logitech-hidpp.c +0 -0

logitech-hidpp.c
index 90b0184df777..b1b1c5cb657c 100644

drivers/hid/hid-logitech-hidpp.c +0 -0
@@ -4659,8 +4659,6 @@ static const struct hid_device_id
 hidpp_devices[] = {
  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },

  { /* MX Vertical over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },

drivers/hid/hid-logitech-hidpp.c +0 -2
-	{ /* Logitech G703 Hero Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },

  { /* Logitech G903 Hero Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) }, { /* Logitech G915 TKL Keyboard over USB */

maintainer
#2 lore raw
Quoted 18 lines · Bastien Nocera
Quoted 3 lines

The ID appears to be given twice, remove the duplicate

Indeed, at line 4652:
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
{ /* Logitech G900 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) },
{ /* Logitech G903 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) },
{ /* Logitech G Pro Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
{ /* MX Vertical over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },

Quoted 1 line

Benjamin, Jiri, is there not a way to detect duplicates like this?

I think the modern way to do this is to ask some LLM to find all of them :)

Quoted 3 lines

In any case, looks good to me.

Thanks a lot, now queued.

Signature · 2 lines
Jiri Kosina
SUSE Labs
#3 lore raw
Quoted 20 lines · Jiri Kosina
Quoted 18 lines · Bastien Nocera
Quoted 3 lines

The ID appears to be given twice, remove the duplicate

Indeed, at line 4652:
        { /* Logitech G703 Hero Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, { /* Logitech G900 Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) }, { /* Logitech G903 Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) }, { /* Logitech G Pro Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, { /* MX Vertical over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) }, { /* Logitech G703 Hero Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },

Quoted 5 lines
Quoted 1 line

Benjamin, Jiri, is there not a way to detect duplicates like this?

I think the modern way to do this is to ask some LLM to find all of them
:)

I meant a deterministic way, so I guess that's a no.

Cheers

Quoted 6 lines
Quoted 4 lines

In any case, looks good to me.

Thanks a lot, now queued.