HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB
Subsystems (3)
PATCH 1/1 HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB
The ID appears to be given twice, remove the duplicate
--- drivers/hid/hid-logitech-hidpp.c | 2 -- 1 file changed, 2 deletions(-)
drivers/hid/hid-logitech-hidpp.c +0 -2
@@ -4659,8 +4659,6 @@ static const struct hid_device_id hidpp_devices[] = { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, {/* MX Vertical over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) }, - { /* Logitech G703 Hero Gaming Mouse over USB */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, { /* Logitech G903 Hero Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) }, { /* Logitech G915 TKL Keyboard over USB */
Signature · 1 line
2.53.0
Quoted 3 lines · Stuart Hayhurst
The ID appears to be given twice, remove the duplicate
Signed-off-by Stuart Hayhurst <[email protected]>
Indeed, at line 4652:
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
{ /* Logitech G900 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) },
{ /* Logitech G903 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) },
{ /* Logitech G Pro Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
{ /* MX Vertical over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
Benjamin, Jiri, is there not a way to detect duplicates like this?
In any case, looks good to me.
Quoted 19 lines
---
drivers/hid/hid-logitech-hidpp.c | 2 --1 file changed, 2 deletions(-)drivers/hid/hid- renamed from drivers/hid/hid-logitech-hidpp.c +0
-0
logitech-hidpp.c
index90b0184df777..b1b1c5cb657c100644drivers/hid/hid-logitech-hidpp.c +0
-0@@ -4659,8 +4659,6 @@ static const struct hid_device_id hidpp_devices[] = { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },{ /* MX Vertical over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A)},drivers/hid/hid-logitech-hidpp.c +0
-2- {/* Logitech G703 Hero Gaming Mouse over USB */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },{ /* Logitech G903 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091)}, { /* Logitech G915 TKL Keyboard over USB */
Jiri Kosina
maintainerQuoted 18 lines · Bastien Nocera
Quoted 3 lines
The ID appears to be given twice, remove the duplicate
Signed-off-by Stuart Hayhurst <[email protected]>Indeed, at line 4652:
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090)},
{ /* Logitech G900 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081)},
{ /* Logitech G903 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086)},
{ /* Logitech G Pro Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088)},
{ /* MX Vertical over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A)},
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090)},
Quoted 1 line
Benjamin, Jiri, is there not a way to detect duplicates like this?
I think the modern way to do this is to ask some LLM to find all of them :)
Quoted 3 lines
In any case, looks good to me.
Reviewed-by Bastien Nocera <[email protected]>
Thanks a lot, now queued.
Signature · 2 lines
Jiri Kosina SUSE Labs
Bastien Nocera
reviewerQuoted 20 lines · Jiri Kosina
Quoted 18 lines · Bastien Nocera
Quoted 3 lines
The ID appears to be given twice, remove the duplicate
Signed-off-by Stuart Hayhurst <[email protected]>Indeed, at line 4652:
{ /* Logitech G703 Hero Gaming Mouse over USB */HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090)}, { /* Logitech G900 Gaming Mouse over USB */HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081)}, { /* Logitech G903 Gaming Mouse over USB */HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086)}, { /* Logitech G Pro Gaming Mouse over USB */HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088)}, { /* MX Vertical over USB */HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A)}, { /* Logitech G703 Hero Gaming Mouse over USB */HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090)},
Quoted 5 lines
Quoted 1 line
Benjamin, Jiri, is there not a way to detect duplicates like this?
I think the modern way to do this is to ask some LLM to find all of them
:)
I meant a deterministic way, so I guess that's a no.
Cheers
Quoted 6 lines
Quoted 4 lines
In any case, looks good to me.
Reviewed-by Bastien Nocera <[email protected]>Thanks a lot, now queued.