Skip to contentSkip to conversation

iio: adc: at91_adc: use const char * for DT string property

PATCH In review Amin GATTOUT 3 participants 3 messages Jul 22 – Jul 25

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: at91_adc: use const char * for DT string property

Declare the local variable as const char * and remove the unnecessary cast when passing it to of_property_read_string().

---
 drivers/iio/adc/at91_adc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/at91_adc.c +2 -2
index f610ad729bf3..0ac74ad92fca 100644
@@ -988,7 +988,7 @@ static int at91_adc_probe(struct platform_device *pdev)
 	struct iio_dev *idev;
 	struct at91_adc_state *st;
 	u32 reg, prop;
-	char *s;
+	const char *s;
 
 	idev = devm_iio_device_alloc(&pdev->dev, sizeof(struct at91_adc_state));
 	if (!idev)
@@ -1023,7 +1023,7 @@ static int at91_adc_probe(struct platform_device *pdev)
 
 	st->res = st->caps->high_res_bits;
 	if (st->caps->low_res_bits &&
-	    !of_property_read_string(node, "atmel,adc-use-res", (const char **)&s)
+	    !of_property_read_string(node, "atmel,adc-use-res", &s)
 	    && !strcmp(s, "lowres"))
 		st->res = st->caps->low_res_bits;
 

---
base-commit: 248951ddc14de84de3910f9b13f51491a8cd91df
change-id: 20260722-master-23179d7c00c4

Best regards,

Signature · 1 line
Amin GATTOUT <[email protected]>
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 35 lines · Amin GATTOUT

Declare the local variable as const char * and remove the unnecessary cast when passing it to of_property_read_string().

---
 drivers/iio/adc/at91_adc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/at91_adc.c +2 -3
index f610ad729bf3..0ac74ad92fca 100644
@@ -988,7 +988,7 @@ static int at91_adc_probe(struct platform_device *pdev)
 	struct iio_dev *idev;
 	struct at91_adc_state *st;
 	u32 reg, prop;
-	char *s;
+	const char *s;
 
 	idev = devm_iio_device_alloc(&pdev->dev, sizeof(struct at91_adc_state));
 	if (!idev)
@@ -1023,7 +1023,7 @@ static int at91_adc_probe(struct platform_device *pdev)
 
 	st->res = st->caps->high_res_bits;
 	if (st->caps->low_res_bits &&
-	    !of_property_read_string(node, "atmel,adc-use-res", (const char **)&s)
+	    !of_property_read_string(node, "atmel,adc-use-res", &s)
 	    && !strcmp(s, "lowres"))
 		st->res = st->caps->low_res_bits;
 
 
---

base-commit: 248951ddc14de84de3910f9b13f51491a8cd91df
change-id: 20260722-master-23179d7c00c4

Quoted 1 line

Best regards,

Makes sense.

Although perhaps could be simplified instead by using of_property_match_string().

maintainer
#2 lore raw
Quoted 36 lines · On Wed, 22 Jul 2026 14:47:08 -0500 David Lechner <[email protected]> wrote:
Quoted 35 lines · Amin GATTOUT

Declare the local variable as const char * and remove the unnecessary cast when passing it to of_property_read_string().

---
 drivers/iio/adc/at91_adc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/at91_adc.c +2 -3
index f610ad729bf3..0ac74ad92fca 100644
@@ -988,7 +988,7 @@ static int at91_adc_probe(struct platform_device *pdev)
 	struct iio_dev *idev;
 	struct at91_adc_state *st;
 	u32 reg, prop;
-	char *s;
+	const char *s;
 
 	idev = devm_iio_device_alloc(&pdev->dev, sizeof(struct at91_adc_state));
 	if (!idev)
@@ -1023,7 +1023,7 @@ static int at91_adc_probe(struct platform_device *pdev)
 
 	st->res = st->caps->high_res_bits;
 	if (st->caps->low_res_bits &&
-	    !of_property_read_string(node, "atmel,adc-use-res", (const char **)&s)
+	    !of_property_read_string(node, "atmel,adc-use-res", &s)
 	    && !strcmp(s, "lowres"))
 		st->res = st->caps->low_res_bits;
 
 
---

base-commit: 248951ddc14de84de3910f9b13f51491a8cd91df
change-id: 20260722-master-23179d7c00c4

Quoted 8 lines
Quoted 1 line

Best regards,

Makes sense.

Although perhaps could be simplified instead by using of_property_match_string().

Whilst I would prefer that it 'might' break a bad device tree given the current code is a match against one of the two values. If we start matching explicitly against them any issues would become a probe failure.

So given it's ancient and I don't want to mess too much with it, applied this lower risk patch.

Jonathan