Skip to contentSkip to conversation

usb: enable sysfs module symlink for more built-in drivers

PATCH In review Shashank Balaji 5 participants 10 messages Jul 22 – Sep 10

Subsystems (10)
lore
Share & tools
lore
#0 lore raw

cover usb: enable sysfs module symlink for more built-in drivers

This is in continuation to [1].

struct device_driver's mod_name is not set by a number of bus' driver registration functions. Without that, built-in drivers don't have the module symlink in sysfs. We want this to go from unbound driver name -> module name -> kernel config name. This is useful on embedded platforms to minimize kernel config, reduce kernel size, and reduce boot time.

This patchset adds mod_name to usb-related drivers.

[1] https://lore.kernel.org/all/[email protected]/

---
Shashank Balaji (4):
usb: core: pass THIS_MODULE implicitly through a macro
usb: core: set mod_name in driver registration
usb: typec: set mod_name in driver registration
usb: ulpi: set mod_name in driver registration

 include/linux/ulpi/driver.h             |  4 ++--
 include/linux/usb.h                     |  6 ++++--
 include/linux/usb/typec_altmode.h       |  4 ++--
 drivers/net/usb/r8152.c                 |  2 +-
 drivers/usb/common/ulpi.c               |  4 +++-
 drivers/usb/core/driver.c               | 10 ++++++----
 drivers/usb/core/usb.c                  |  2 +-
 drivers/usb/misc/apple-mfi-fastcharge.c |  2 +-
 drivers/usb/misc/onboard_usb_dev.c      |  2 +-
 drivers/usb/typec/bus.c                 |  4 +++-
 drivers/usb/usbip/stub_main.c           |  2 +-
 11 files changed, 25 insertions(+), 17 deletions(-)

---
base-commit: 248951ddc14de84de3910f9b13f51491a8cd91df
change-id: 20260722-mod_name_usb-e3baf58e1e1e

Best regards,

Signature · 1 line
Shashank Balaji <[email protected]>
#1 lore raw

PATCH 1/4 usb: core: pass THIS_MODULE implicitly through a macro

Rename usb_register_device_driver() to __usb_register_device_driver() and replace it with a macro wrapper that passes THIS_MODULE implicitly. This is in line with what other buses do.

---
 include/linux/usb.h                     | 4 +++-
 drivers/net/usb/r8152.c                 | 2 +-
 drivers/usb/core/driver.c               | 6 +++---
 drivers/usb/core/usb.c                  | 2 +-
 drivers/usb/misc/apple-mfi-fastcharge.c | 2 +-
 drivers/usb/misc/onboard_usb_dev.c      | 2 +-
 drivers/usb/usbip/stub_main.c           | 2 +-
 7 files changed, 11 insertions(+), 9 deletions(-)
include/linux/usb.h +3 -1
index 1da4ad1610bc..2466183a45f0 100644
@@ -1368,7 +1368,9 @@ extern void usb_deregister(struct usb_driver *);
 	module_driver(__usb_driver, usb_register, \
 		       usb_deregister)
 
-extern int usb_register_device_driver(struct usb_device_driver *,
+#define usb_register_device_driver(new_udriver) \
+	__usb_register_device_driver(new_udriver, THIS_MODULE)
+extern int __usb_register_device_driver(struct usb_device_driver *,
 			struct module *);
 extern void usb_deregister_device_driver(struct usb_device_driver *);
 
drivers/net/usb/r8152.c +1 -1
index f61686433031..73b9b2af1ed2 100644
@@ -10495,7 +10495,7 @@ static int __init rtl8152_driver_init(void)
 {
 	int ret;
 
-	ret = usb_register_device_driver(&rtl8152_cfgselector_driver, THIS_MODULE);
+	ret = usb_register_device_driver(&rtl8152_cfgselector_driver);
 	if (ret)
 		return ret;
 
drivers/usb/core/driver.c +3 -3
index f63004417058..eac1ff468c08 100644
@@ -980,7 +980,7 @@ bool is_usb_device_driver(const struct device_driver *drv)
 }
 
 /**
- * usb_register_device_driver - register a USB device (not interface) driver
+ * __usb_register_device_driver - register a USB device (not interface) driver
  * @new_udriver: USB operations for the device driver
  * @owner: module owner of this driver.
  *
@@ -990,7 +990,7 @@ bool is_usb_device_driver(const struct device_driver *drv)
  *
  * Return: A negative error code on failure and 0 on success.
  */
-int usb_register_device_driver(struct usb_device_driver *new_udriver,
+int __usb_register_device_driver(struct usb_device_driver *new_udriver,
 		struct module *owner)
 {
 	int retval = 0;
@@ -1023,7 +1023,7 @@ int usb_register_device_driver(struct usb_device_driver *new_udriver,
 
 	return retval;
 }
-EXPORT_SYMBOL_GPL(usb_register_device_driver);
+EXPORT_SYMBOL_GPL(__usb_register_device_driver);
 
 /**
  * usb_deregister_device_driver - unregister a USB device (not interface) driver
drivers/usb/core/usb.c +1 -1
index df166cafe106..2559a180fdee 100644
@@ -1241,7 +1241,7 @@ static int __init usb_init(void)
 	retval = usb_hub_init();
 	if (retval)
 		goto hub_init_failed;
-	retval = usb_register_device_driver(&usb_generic_driver, THIS_MODULE);
+	retval = usb_register_device_driver(&usb_generic_driver);
 	if (!retval)
 		goto out;
 
drivers/usb/misc/apple-mfi-fastcharge.c +1 -1
index af266e19f2fd..02adec28d9e6 100644
@@ -245,7 +245,7 @@ static struct usb_device_driver mfi_fc_driver = {
 
 static int __init mfi_fc_driver_init(void)
 {
-	return usb_register_device_driver(&mfi_fc_driver, THIS_MODULE);
+	return usb_register_device_driver(&mfi_fc_driver);
 }
 
 static void __exit mfi_fc_driver_exit(void)
drivers/usb/misc/onboard_usb_dev.c +1 -1
index 11508ed4df25..c60406240416 100644
@@ -706,7 +706,7 @@ static int __init onboard_dev_init(void)
 {
 	int ret;
 
-	ret = usb_register_device_driver(&onboard_dev_usbdev_driver, THIS_MODULE);
+	ret = usb_register_device_driver(&onboard_dev_usbdev_driver);
 	if (ret)
 		return ret;
 
drivers/usb/usbip/stub_main.c +1 -1
index 79110a69d697..01452f7bdabb 100644
@@ -371,7 +371,7 @@ static int __init usbip_host_init(void)
 		return -ENOMEM;
 	}
 
-	ret = usb_register_device_driver(&stub_driver, THIS_MODULE);
+	ret = usb_register_device_driver(&stub_driver);
 	if (ret) {
 		pr_err("usb_register failed %d\n", ret);
 		goto err_usb_register;
Signature · 1 line
2.43.0
maintainer
#2 lore raw

Re: [PATCH 1/4] usb: core: pass THIS_MODULE implicitly through a macro

Quoted 5 lines · Shashank Balaji

Rename usb_register_device_driver() to __usb_register_device_driver() and replace
it with a macro wrapper that passes THIS_MODULE implicitly. This is in line with
what other buses do.

I found some examples by grepping for:
git grep 'THIS_MODULE)' include/ | grep driver

It could have been useful to mention some examples by name in the commit message.

Cheers

Quoted 143 lines

---
 include/linux/usb.h                     | 4 +++- drivers/net/usb/r8152.c                 | 2 +- drivers/usb/core/driver.c               | 6 +++--- drivers/usb/core/usb.c                  | 2 +- drivers/usb/misc/apple-mfi-fastcharge.c | 2 +- drivers/usb/misc/onboard_usb_dev.c      | 2 +- drivers/usb/usbip/stub_main.c           | 2 +-

 7 files changed, 11 insertions(+), 9 deletions(-)
include/linux/usb.h +0 -0
index 1da4ad1610bc..2466183a45f0 100644
@@ -1368,7 +1368,9 @@ extern void usb_deregister(struct usb_driver
 *);
  	module_driver(__usb_driver, usb_register, \
  		       usb_deregister)

include/linux/usb.h +3 -1
-extern int usb_register_device_driver(struct usb_device_driver *,
+#define usb_register_device_driver(new_udriver) \
+	__usb_register_device_driver(new_udriver, THIS_MODULE)
+extern int __usb_register_device_driver(struct usb_device_driver *,

  struct module *);
 extern void usb_deregister_device_driver(struct usb_device_driver *);

drivers/net/usb/r8152.c +0 -0
index f61686433031..73b9b2af1ed2 100644
@@ -10495,7 +10495,7 @@ static int __init rtl8152_driver_init(void)
  {
  	int ret;

drivers/net/usb/r8152.c +0 -1
-	ret =

usb_register_device_driver(&rtl8152_cfgselector_driver, THIS_MODULE);

drivers/net/usb/r8152.c +1 -0
+	ret =

usb_register_device_driver(&rtl8152_cfgselector_driver); if (ret)
  return ret;

drivers/usb/core/driver.c +0 -0
index f63004417058..eac1ff468c08 100644
@@ -980,7 +980,7 @@ bool is_usb_device_driver(const struct
 device_driver *drv)
  }


 /**
- * usb_register_device_driver - register a USB device (not interface) driver
+ * __usb_register_device_driver - register a USB device (not interface) driver
  * @new_udriver: USB operations for the device driver
  * @owner: module owner of this driver.
  *

drivers/usb/core/driver.c +1 -1
@@ -990,7 +990,7 @@ bool is_usb_device_driver(const struct
 device_driver *drv)
   *
   * Return: A negative error code on failure and 0 on success.
   */
-int usb_register_device_driver(struct usb_device_driver
 *new_udriver,
+int __usb_register_device_driver(struct usb_device_driver
 *new_udriver,

  struct module *owner)
 {
  int retval = 0;

drivers/usb/core/driver.c +0 -0
@@ -1023,7 +1023,7 @@ int usb_register_device_driver(struct
 usb_device_driver *new_udriver,


  return retval;
 }

drivers/usb/core/driver.c +1 -1
-EXPORT_SYMBOL_GPL(usb_register_device_driver);
+EXPORT_SYMBOL_GPL(__usb_register_device_driver);


 /**
  * usb_deregister_device_driver - unregister a USB device (not interface) driver

drivers/usb/core/usb.c +1 -1
index df166cafe106..2559a180fdee 100644
@@ -1241,7 +1241,7 @@ static int __init usb_init(void)
  	retval = usb_hub_init();
  	if (retval)
  		goto hub_init_failed;
-	retval = usb_register_device_driver(&usb_generic_driver,
 THIS_MODULE);
+	retval = usb_register_device_driver(&usb_generic_driver);
  	if (!retval)
  		goto out;

drivers/usb/misc/apple-mfi-fastcharge.c +0 -0
index af266e19f2fd..02adec28d9e6 100644
@@ -245,7 +245,7 @@ static struct usb_device_driver mfi_fc_driver = {


 static int __init mfi_fc_driver_init(void)
 {

drivers/usb/misc/apple-mfi-fastcharge.c +0 -1
-	return usb_register_device_driver(&mfi_fc_driver,

THIS_MODULE);

drivers/usb/misc/apple-mfi-fastcharge.c +1 -0
+	return usb_register_device_driver(&mfi_fc_driver);

 }

 static void __exit mfi_fc_driver_exit(void)

drivers/usb/misc/onboard_usb_dev.c +0 -0
index 11508ed4df25..c60406240416 100644
@@ -706,7 +706,7 @@ static int __init onboard_dev_init(void)
  {
  	int ret;

drivers/usb/misc/onboard_usb_dev.c +0 -1
-	ret = usb_register_device_driver(&onboard_dev_usbdev_driver,

THIS_MODULE);

drivers/usb/misc/onboard_usb_dev.c +1 -0
+	ret =

usb_register_device_driver(&onboard_dev_usbdev_driver); if (ret)
  return ret;

drivers/usb/usbip/stub_main.c +0 -0
index 79110a69d697..01452f7bdabb 100644
@@ -371,7 +371,7 @@ static int __init usbip_host_init(void)
  		return -ENOMEM;
  	}

drivers/usb/usbip/stub_main.c +1 -1
-	ret = usb_register_device_driver(&stub_driver, THIS_MODULE);
+	ret = usb_register_device_driver(&stub_driver);

  if (ret) {
  pr_err("usb_register failed %d\n", ret); goto err_usb_register;

#3 lore raw

PATCH 2/4 usb: core: set mod_name in driver registration

In reply to Shashank Balaji

The driver core only creates the sysfs "module" symlink for a built-in driver when its struct device_driver has mod_name set (see module_add_driver()). This registration path left mod_name unset, so built-in drivers using it had no such symlink.

Set mod_name to KBUILD_MODNAME during driver registration. Built-in drivers now gain the symlink, while loadable modules are unaffected.

---
 include/linux/usb.h       | 4 ++--
 drivers/usb/core/driver.c | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)
include/linux/usb.h +2 -2
index 2466183a45f0..6507c217bca7 100644
@@ -1369,9 +1369,9 @@ extern void usb_deregister(struct usb_driver *);
 		       usb_deregister)
 
 #define usb_register_device_driver(new_udriver) \
-	__usb_register_device_driver(new_udriver, THIS_MODULE)
+	__usb_register_device_driver(new_udriver, THIS_MODULE, KBUILD_MODNAME)
 extern int __usb_register_device_driver(struct usb_device_driver *,
-			struct module *);
+			struct module *, const char *);
 extern void usb_deregister_device_driver(struct usb_device_driver *);
 
 extern int usb_register_dev(struct usb_interface *intf,
drivers/usb/core/driver.c +3 -1
index eac1ff468c08..ab809cb6da26 100644
@@ -983,6 +983,7 @@ bool is_usb_device_driver(const struct device_driver *drv)
  * __usb_register_device_driver - register a USB device (not interface) driver
  * @new_udriver: USB operations for the device driver
  * @owner: module owner of this driver.
+ * @mod_name: module name string
  *
  * Registers a USB device driver with the USB core.  The list of
  * unattached devices will be rescanned whenever a new driver is
@@ -991,7 +992,7 @@ bool is_usb_device_driver(const struct device_driver *drv)
  * Return: A negative error code on failure and 0 on success.
  */
 int __usb_register_device_driver(struct usb_device_driver *new_udriver,
-		struct module *owner)
+		struct module *owner, const char *mod_name)
 {
 	int retval = 0;
 
@@ -1003,6 +1004,7 @@ int __usb_register_device_driver(struct usb_device_driver *new_udriver,
 	new_udriver->driver.probe = usb_probe_device;
 	new_udriver->driver.remove = usb_unbind_device;
 	new_udriver->driver.owner = owner;
+	new_udriver->driver.mod_name = mod_name;
 	new_udriver->driver.dev_groups = new_udriver->dev_groups;
 
 	retval = driver_register(&new_udriver->driver);
Signature · 1 line
2.43.0
#4 lore raw

Re: [PATCH 2/4] usb: core: set mod_name in driver registration

Quoted 21 lines · Shashank Balaji

The driver core only creates the sysfs "module" symlink for a built-in driver when its struct device_driver has mod_name set (see module_add_driver()). This registration path left mod_name unset, so built-in drivers using it had no such symlink.

Set mod_name to KBUILD_MODNAME during driver registration. Built-in drivers now gain the symlink, while loadable modules are unaffected.

---
 include/linux/usb.h       | 4 ++--
 drivers/usb/core/driver.c | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)
include/linux/usb.h +0 -0
index 2466183a45f0..6507c217bca7 100644

include/linux/usb.h extern void usb_deregister(struct usb_driver *); · line 1372

Quoted 5 lines
include/linux/usb.h +1 -1
@@ -1369,9 +1369,9 @@ extern void usb_deregister(struct usb_driver *);
 		       usb_deregister)
 
 #define usb_register_device_driver(new_udriver) \
-	__usb_register_device_driver(new_udriver, THIS_MODULE)
+	__usb_register_device_driver(new_udriver, THIS_MODULE, KBUILD_MODNAME)

It seems odd to me that struct module doesn't contain the name of the module, and you have to pass this around all the time...

Anyway, all now queued up, thanks!

greg k-h

#5 lore raw

PATCH 3/4 usb: typec: set mod_name in driver registration

In reply to Shashank Balaji

The driver core only creates the sysfs "module" symlink for a built-in driver when its struct device_driver has mod_name set (see module_add_driver()). This driver left mod_name unset, so its built-in form had no such symlink.

Set mod_name to KBUILD_MODNAME during driver registration. Built-in drivers now gain the symlink, while loadable modules are unaffected.

---
 include/linux/usb/typec_altmode.h | 4 ++--
 drivers/usb/typec/bus.c           | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)
include/linux/usb/typec_altmode.h +2 -2
index ef21ead551be..92309b569c3a 100644
@@ -227,9 +227,9 @@ struct typec_altmode_driver {
  * handle all SVID specific communication.
  */
 #define typec_altmode_register_driver(drv) \
-		__typec_altmode_register_driver(drv, THIS_MODULE)
+		__typec_altmode_register_driver(drv, THIS_MODULE, KBUILD_MODNAME)
 int __typec_altmode_register_driver(struct typec_altmode_driver *drv,
-				    struct module *module);
+				    struct module *module, const char *mod_name);
 /**
  * typec_altmode_unregister_driver - unregisters a USB Type-C alternate mode
  * 				     device driver
drivers/usb/typec/bus.c +3 -1
index e84b134a3381..587d3b06ee8d 100644
@@ -383,12 +383,14 @@ void typec_altmode_put_plug(struct typec_altmode *plug)
 EXPORT_SYMBOL_GPL(typec_altmode_put_plug);
 
 int __typec_altmode_register_driver(struct typec_altmode_driver *drv,
-				    struct module *module)
+				    struct module *module,
+				    const char *mod_name)
 {
 	if (!drv->probe)
 		return -EINVAL;
 
 	drv->driver.owner = module;
+	drv->driver.mod_name = mod_name;
 	drv->driver.bus = &typec_bus;
 
 	return driver_register(&drv->driver);
Signature · 1 line
2.43.0
maintainer Acked-by on v1 3/4
#6 lore raw

Re: [PATCH 3/4] usb: typec: set mod_name in driver registration

Quoted 11 lines · Shashank Balaji

The driver core only creates the sysfs "module" symlink for a built-in driver when its struct device_driver has mod_name set (see module_add_driver()). This driver left mod_name unset, so its built-in form had no such symlink.

Set mod_name to KBUILD_MODNAME during driver registration. Built-in drivers now gain the symlink, while loadable modules are unaffected.

Quoted 44 lines
---
 include/linux/usb/typec_altmode.h | 4 ++--
 drivers/usb/typec/bus.c           | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)
include/linux/usb/typec_altmode.h +2 -2
index ef21ead551be..92309b569c3a 100644
@@ -227,9 +227,9 @@ struct typec_altmode_driver {
  * handle all SVID specific communication.
  */
 #define typec_altmode_register_driver(drv) \
-		__typec_altmode_register_driver(drv, THIS_MODULE)
+		__typec_altmode_register_driver(drv, THIS_MODULE, KBUILD_MODNAME)
 int __typec_altmode_register_driver(struct typec_altmode_driver *drv,
-				    struct module *module);
+				    struct module *module, const char *mod_name);
 /**
  * typec_altmode_unregister_driver - unregisters a USB Type-C alternate mode
  * 				     device driver
drivers/usb/typec/bus.c +3 -1
index e84b134a3381..587d3b06ee8d 100644
@@ -383,12 +383,14 @@ void typec_altmode_put_plug(struct typec_altmode *plug)
 EXPORT_SYMBOL_GPL(typec_altmode_put_plug);
 
 int __typec_altmode_register_driver(struct typec_altmode_driver *drv,
-				    struct module *module)
+				    struct module *module,
+				    const char *mod_name)
 {
 	if (!drv->probe)
 		return -EINVAL;
 
 	drv->driver.owner = module;
+	drv->driver.mod_name = mod_name;
 	drv->driver.bus = &typec_bus;
 
 	return driver_register(&drv->driver);
Signature · 2 lines
-- 
2.43.0
Signature · 1 line
heikki
#7 lore raw

PATCH 4/4 usb: ulpi: set mod_name in driver registration

In reply to Shashank Balaji

The driver core only creates the sysfs "module" symlink for a built-in driver when its struct device_driver has mod_name set (see module_add_driver()). This driver left mod_name unset, so its built-in form had no such symlink.

Set mod_name to KBUILD_MODNAME during driver registration. Built-in drivers now gain the symlink, while loadable modules are unaffected.

---
 include/linux/ulpi/driver.h | 4 ++--
 drivers/usb/common/ulpi.c   | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)
include/linux/ulpi/driver.h +2 -2
index c668d9c8d876..c899197e0aa8 100644
@@ -51,8 +51,8 @@ struct ulpi_driver {
 /*
  * use a macro to avoid include chaining to get THIS_MODULE
  */
-#define ulpi_register_driver(drv) __ulpi_register_driver(drv, THIS_MODULE)
-int __ulpi_register_driver(struct ulpi_driver *drv, struct module *module);
+#define ulpi_register_driver(drv) __ulpi_register_driver(drv, THIS_MODULE, KBUILD_MODNAME)
+int __ulpi_register_driver(struct ulpi_driver *drv, struct module *module, const char *mod_name);
 void ulpi_unregister_driver(struct ulpi_driver *drv);
 
 #define module_ulpi_driver(__ulpi_driver) \
drivers/usb/common/ulpi.c +3 -1
index 7e43429e996e..dec4baca1c53 100644
@@ -147,15 +147,17 @@ static const struct device_type ulpi_dev_type = {
  * __ulpi_register_driver - register a driver with the ULPI bus
  * @drv: driver being registered
  * @module: ends up being THIS_MODULE
+ * @mod_name: ends up being KBUILD_MODNAME
  *
  * Registers a driver with the ULPI bus.
  */
-int __ulpi_register_driver(struct ulpi_driver *drv, struct module *module)
+int __ulpi_register_driver(struct ulpi_driver *drv, struct module *module, const char *mod_name)
 {
 	if (!drv->probe)
 		return -EINVAL;
 
 	drv->driver.owner = module;
+	drv->driver.mod_name = mod_name;
 	drv->driver.bus = &ulpi_bus;
 
 	return driver_register(&drv->driver);
Signature · 1 line
2.43.0
#8 lore raw
In reply to Shashank Balaji
Quoted 36 lines

-----Original Message-----
From: Mahadasyam, Shashank (SGC) <[email protected]>
Subject: [PATCH 0/4] usb: enable sysfs module symlink for more built-in drivers

This is in continuation to [1].

struct device_driver's mod_name is not set by a number of bus' driver registration functions. Without that, built-in drivers don't have the module symlink in sysfs. We want this to go from unbound driver name -> module name -> kernel config name. This is useful on embedded platforms to minimize kernel config, reduce kernel size, and reduce boot time.

This patchset adds mod_name to usb-related drivers.

[1] https://lore.kernel.org/all/[email protected]/

---
Shashank Balaji (4):
usb: core: pass THIS_MODULE implicitly through a macro
usb: core: set mod_name in driver registration
usb: typec: set mod_name in driver registration
usb: ulpi: set mod_name in driver registration

 include/linux/ulpi/driver.h             |  4 ++--
 include/linux/usb.h                     |  6 ++++--
 include/linux/usb/typec_altmode.h       |  4 ++--
 drivers/net/usb/r8152.c                 |  2 +-
 drivers/usb/common/ulpi.c               |  4 +++-
 drivers/usb/core/driver.c               | 10 ++++++----
 drivers/usb/core/usb.c                  |  2 +-
 drivers/usb/misc/apple-mfi-fastcharge.c |  2 +-
 drivers/usb/misc/onboard_usb_dev.c      |  2 +-
 drivers/usb/typec/bus.c                 |  4 +++-
 drivers/usb/usbip/stub_main.c           |  2 +-
 11 files changed, 25 insertions(+), 17 deletions(-)
Quoted 3 lines

---
base-commit: 248951ddc14de84de3910f9b13f51491a8cd91df
change-id: 20260722-mod_name_usb-e3baf58e1e1e

FWIW, I looked through these and they look OK to me. I didn't see any obvious errors (but I'm not a USB or driver or sysfs developer). Given that, a "Reviewed-by" might be too strong, but you can add an "Acked-by" for me if you'd like.

We should talk some time about my (half-baked) tool to find the config options associated with files and source code line numbers. It sounds like it has similar goals to what these patches are trying to enable.
-- Tim

maintainer Reviewed-by on the v1 series
#9 lore raw
In reply to Shashank Balaji
Quoted 12 lines · Shashank Balaji

This is in continuation to [1].

struct device_driver's mod_name is not set by a number of bus' driver registration
functions. Without that, built-in drivers don't have the module symlink in sysfs.
We want this to go from unbound driver name -> module name -> kernel config name.
This is useful on embedded platforms to minimize kernel config, reduce kernel size,
and reduce boot time.

Quoted 6 lines

This patchset adds mod_name to usb-related drivers.

[1]
https://lore.kernel.org/all/[email protected]/

Quoted 26 lines

---
Shashank Balaji (4):
      usb: core: pass THIS_MODULE implicitly through a macro
      usb: core: set mod_name in driver registration
      usb: typec: set mod_name in driver registration
      usb: ulpi: set mod_name in driver registration

 include/linux/ulpi/driver.h             |  4 ++-- include/linux/usb.h                     |  6 ++++-- include/linux/usb/typec_altmode.h       |  4 ++-- drivers/net/usb/r8152.c                 |  2 +- drivers/usb/common/ulpi.c               |  4 +++- drivers/usb/core/driver.c               | 10 ++++++---- drivers/usb/core/usb.c                  |  2 +- drivers/usb/misc/apple-mfi-fastcharge.c |  2 +- drivers/usb/misc/onboard_usb_dev.c      |  2 +- drivers/usb/typec/bus.c                 |  4 +++- drivers/usb/usbip/stub_main.c           |  2 +-

 11 files changed, 25 insertions(+), 17 deletions(-)

---
base-commit: 248951ddc14de84de3910f9b13f51491a8cd91df
change-id: 20260722-mod_name_usb-e3baf58e1e1e

Best regards,
--
Shashank Balaji <[email protected]>