Skip to contentSkip to conversation

wget: fix CVE-2026-58469

PATCH In review [email protected] 2 participants 4 messages Jul 22 – Jul 27

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 wget: fix CVE-2026-58469

From: Amaury Couderc <[email protected]>

Backport patch to fix CVE-2026-58469.

References:
https://nvd.nist.gov/vuln/detail/CVE-2026-58469
https://www.cve.org/CVERecord?id=CVE-2026-58469
https://security-tracker.debian.org/tracker/CVE-2026-58469
https://ubuntu.com/security/CVE-2026-58469
https://osv.dev/list?q=CVE-2026-58469

Upstream fix:
https://gitlab.com/gnuwget/wget/-/commit/37a40fcb450153f69537c7cbc2a7a4fb0b6f7826 [nvd]

---
 .../wget/wget/CVE-2026-58469.patch            | 52 +++++++++++++++++++
 meta/recipes-extended/wget/wget_1.25.0.bb     |  1 +
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-extended/wget/wget/CVE-2026-58469.patch
meta/recipes-extended/wget/wget/CVE-2026-58469.patch new file +52 -0
new file mode 100644
index 0000000000..c5d3df9090
@@ -0,0 +1,52 @@
+From c7d858a9ca8b9840e5edc520c36fe4f33f2e9cea Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Tim=20R=C3=BChsen?= <[email protected]>
+Date: Mon, 29 Jun 2026 18:32:02 +0200
+Subject: [PATCH] * src/metalink.c (clean_metalink_string): Fix buffer
+ underflow
+
+Reported-by: [email protected]
+
+CVE: CVE-2026-58469
+Upstream-Status: Backport [https://gitlab.com/gnuwget/wget/-/commit/37a40fcb450153f69537c7cbc2a7a4fb0b6f7826]
+
+Signed-off-by: Amaury Couderc <[email protected]>
+---
+ src/metalink.c | 9 +++------
+ 1 file changed, 3 insertions(+), 6 deletions(-)
+
+diff --git a/src/metalink.c b/src/metalink.c
+index de2439c9..2d6e5846 100644
+--- a/src/metalink.c
++++ b/src/metalink.c
+@@ -1041,7 +1041,6 @@ void
+ clean_metalink_string (char **str)
+ {
+   int c;
+-  size_t len;
+   char *new, *beg, *end;
+ 
+   if (!str || !*str)
+@@ -1049,7 +1048,7 @@ clean_metalink_string (char **str)
+ 
+   beg = *str;
+ 
+-  while ((c = *beg) && (c == '\n' || c == '\r' || c == '\t' || c == ' '))
++  while (isspace(*beg))
+     beg++;
+ 
+   end = beg;
+@@ -1062,12 +1061,10 @@ clean_metalink_string (char **str)
+   /* If we are at the end of the string, search the first legit
+      character going backward.  */
+   if (*end == '\0')
+-    while ((c = *(end - 1)) && (c == '\n' || c == '\r' || c == '\t' || c == ' '))
++    while (end > beg && !isspace(*(end - 1)))
+       end--;
+ 
+-  len = end - beg;
+-
+-  new = xmemdup0 (beg, len);
++  new = xmemdup0 (beg, end - beg);
+   xfree (*str);
+   *str = new;
+ }
meta/recipes-extended/wget/wget_1.25.0.bb +1 -0
index f0d3458462..a1f34dfb5c 100644
@@ -15,6 +15,7 @@ DEPENDS += "autoconf-archive-native pod2man-native"
 
 SRC_URI = "${GNU_MIRROR}/wget/wget-${PV}.tar.gz \
            file://0002-improve-reproducibility.patch \
+           file://CVE-2026-58469.patch \
            "
 
 SRC_URI[sha256sum] = "766e48423e79359ea31e41db9e5c289675947a7fcf2efdcedb726ac9d0da3784"
Signature · 1 line
2.34.1
#1 lore raw
Quoted 14 lines · Amaury Couderc via lists.openembedded.org

From: Amaury Couderc <[email protected]>

Backport patch to fix CVE-2026-58469.

References:
https://nvd.nist.gov/vuln/detail/CVE-2026-58469
https://www.cve.org/CVERecord?id=CVE-2026-58469
https://security-tracker.debian.org/tracker/CVE-2026-58469
https://ubuntu.com/security/CVE-2026-58469
https://osv.dev/list?q=CVE-2026-58469

Upstream fix:
https://gitlab.com/gnuwget/wget/-/commit/37a40fcb450153f69537c7cbc2a7a4fb0b6f7826 [nvd]

Quoted 6 lines
---
 .../wget/wget/CVE-2026-58469.patch            | 52 +++++++++++++++++++
 meta/recipes-extended/wget/wget_1.25.0.bb     |  1 +
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-extended/wget/wget/CVE-2026-58469.patch

Hello,

Hetvi Thakar wrote[0] about a related series to wrynose:

Quoted 5 lines

I reviewed the earlier series.
It looks like the follow-up upstream regression fixes for CVE-2026-58469 and CVE-2026-58472 were not included in the backport. These follow-up commits are required to complete the backport, and I have included them in my series .

Hetvi, do you confirm this is missing here as well?

In the meantime, I think we should hold this series since we suspect it's missing regression patches.

[0]: https://lore.kernel.org/all/PH7PR11MB8598AB8F89B7886FD3EC9148ADC02@PH7PR11MB8598.namprd11.prod.outlook.com/

Regards,

Signature · 2 lines
Yoann Congal
Smile ECS
#2 lore raw

Hello,

I reviewed the patches from Hetvi and they seem good to me. I would propose to go forward with them instead of mine for scarthgap and wrynose branches.
For the master branch I can send a v2 of the patches which include the follow-up regression fixes so that everything is covered.

Would it be fine for you?

Kind Regards,

Amaury

________________________________________
From: Yoann Congal <[email protected]>
Sent: Sunday, 26 July 2026 22:48
To: Amaury Couderc; [email protected]
Cc: Hetvi Thakar
Subject: Re: [OE-core] [PATCH 1/5] wget: fix CVE-2026-58469

Quoted 14 lines · Amaury Couderc via lists.openembedded.org

From: Amaury Couderc <[email protected]>

Backport patch to fix CVE-2026-58469.

References:
https://nvd.nist.gov/vuln/detail/CVE-2026-58469
https://www.cve.org/CVERecord?id=CVE-2026-58469
https://security-tracker.debian.org/tracker/CVE-2026-58469
https://ubuntu.com/security/CVE-2026-58469
https://osv.dev/list?q=CVE-2026-58469

Upstream fix:
https://gitlab.com/gnuwget/wget/-/commit/37a40fcb450153f69537c7cbc2a7a4fb0b6f7826 [nvd]

Quoted 6 lines
---
 .../wget/wget/CVE-2026-58469.patch            | 52 +++++++++++++++++++
 meta/recipes-extended/wget/wget_1.25.0.bb     |  1 +
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-extended/wget/wget/CVE-2026-58469.patch

Hello,

Hetvi Thakar wrote[0] about a related series to wrynose:

Quoted 5 lines

I reviewed the earlier series.
It looks like the follow-up upstream regression fixes for CVE-2026-58469 and CVE-2026-58472 were not included in the backport. These follow-up commits are required to complete the backport, and I have included them in my series .

Hetvi, do you confirm this is missing here as well?

In the meantime, I think we should hold this series since we suspect it's missing regression patches.

[0]: https://lore.kernel.org/all/PH7PR11MB8598AB8F89B7886FD3EC9148ADC02@PH7PR11MB8598.namprd11.prod.outlook.com/

Regards,
--
Yoann Congal
Smile ECS

#3 lore raw
Quoted 10 lines · Amaury Couderc

Hello,

I reviewed the patches from Hetvi and they seem good to me. I would propose to go forward with them instead of mine for scarthgap and wrynose branches.
For the master branch I can send a v2 of the patches which include the follow-up regression fixes so that everything is covered.

Would it be fine for you?

Sounds good to me. If Hetvi could Review this next version that would be even better :)

Thanks!

Signature · 2 lines
Yoann Congal
Smile ECS