Skip to contentSkip to conversation

arm64: dts: qcom: qcom6490-idp: Add IPA node

PATCH Superseded Pavan Kumar 3 participants 3 messages Jul 22

Subsystems (3)

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 arm64: dts: qcom: qcom6490-idp: Add IPA node

Enable the IPA block and provide the firmware name required for firmware loading on qcm6490-idp.

---
Changes in v5:
- Reworked commit message to describe the functionality being enabled.
- Removed IPA property consolidation explanation.
- Removed obsolete Link tag to IPA loader series.
- Clarified that the change applies to qcm6490-idp.
Changes in v4:
- Removed empty line between Link and Signed-off-by tags.
- Added empty line before the status property in the IPA node.
- Sent as a new thread instead of replying to the previous revision. Changes in v3:
- Rebased on top of IPA property consolidation series.
- Dropped qcom,gsi-loader and memory-region properties as they are now provided by kodiak.dtsi.
- Added Link tag to the dependent IPA loader series. Changes in v2:
- Modified firmware file extension from .mdt to .mbn

v4: https://lore.kernel.org/all/[email protected]/
v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

---
 arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/qcm6490-idp.dts +6 -0
index bdc02260f902..7242695aed97 100644
@@ -619,6 +619,12 @@ &gpu_zap_shader {
 	firmware-name = "qcom/qcm6490/a660_zap.mbn";
 };
 
+&ipa {
+	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
+
+	status = "okay";
+};
+
 &lpass_rx_macro {
 	status = "okay";
 };
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] The IPA device will fail to probe unconditionally due to a missing `memory-region` property…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The IPA device will fail to probe unconditionally due to a missing memory-region property, contradicting the commit message claims. --

--- Patch [1]: [PATCH v5] arm64: dts: qcom: qcom6490-idp: Add IPA node --- commit 1670b1c514088d32ff0dcb8120b44156a4500dd0
Author: Pavan Kumar <[email protected]>

arm64: dts: qcom: qcom6490-idp: Add IPA node

Enable the IPA block and provide the firmware name required for firmware loading on qcm6490-idp.

Quoted 4 lines

Changes in v3:
- Rebased on top of IPA property consolidation series.
- Dropped qcom,gsi-loader and memory-region properties as they are now provided by kodiak.dtsi.

[Severity: High]
Is this description accurate regarding kodiak.dtsi providing these properties?

During system boot, the IPA driver in drivers/net/ipa/ipa_main.c probes the ipa node. Without a qcom,gsi-loader property, ipa_firmware_loader() defaults to IPA_LOADER_SELF. This triggers a call to ipa_firmware_load(), which attempts to fetch the memory-region property via of_reserved_mem_region_to_resource().

If memory-region is missing in both qcm6490-idp.dts and the included kodiak.dtsi, the fetch will fail and abort the probe.

Quoted 4 lines
arch/arm64/boot/dts/qcom/qcm6490-idp.dts +0 -0
index bdc02260f902b..7242695aed978 100644

[ ... ]

arch/arm64/boot/dts/qcom/qcm6490-idp.dts &gpu_zap_shader { · line 627

Quoted 10 lines
arch/arm64/boot/dts/qcom/qcm6490-idp.dts +6 -0
@@ -619,6 +619,12 @@ &gpu_zap_shader {
 	firmware-name = "qcom/qcm6490/a660_zap.mbn";
 };
 
+&ipa {
+	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
+
+	status = "okay";
+};
+

[Severity: High]
Will this node fail to probe unconditionally on the qcm6490-idp board due to the missing memory-region property?

Additionally, looking earlier in arch/arm64/boot/dts/qcom/qcm6490-idp.dts, there is an explicit deletion of the firmware memory region:

/delete-node/ &ipa_fw_mem;

If kodiak.dtsi did provide the memory-region property pointing to this node, wouldn't deleting its target cause a Device Tree Compiler error? Does the memory-region property need to be explicitly defined here to allow successful probing?

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Reviewed-by on v5 1/1
#2 lore raw
In reply to Pavan Kumar
Quoted 1 line

[PATCH v5] arm64: dts: qcom: qcom6490-idp: Add IPA node

-ENOSUCHBOARD, it's qcm6490-idp.

Quoted 22 lines · Pavan Kumar

Enable the IPA block and provide the firmware name required for firmware loading on qcm6490-idp.

---
Changes in v5:
- Reworked commit message to describe the functionality being enabled.
- Removed IPA property consolidation explanation.
- Removed obsolete Link tag to IPA loader series.
- Clarified that the change applies to qcm6490-idp.
Changes in v4:
- Removed empty line between Link and Signed-off-by tags.
- Added empty line before the status property in the IPA node.
- Sent as a new thread instead of replying to the previous revision. Changes in v3:
- Rebased on top of IPA property consolidation series.
- Dropped qcom,gsi-loader and memory-region properties as they are now provided by kodiak.dtsi.
- Added Link tag to the dependent IPA loader series. Changes in v2:
- Modified firmware file extension from .mdt to .mbn

Quoted 8 lines

v4: https://lore.kernel.org/all/[email protected]/
v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

---
 arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 6 ++++++
 1 file changed, 6 insertions(+)

Other than the subject:

Signature · 2 lines
With best wishes
Dmitry