media: vimc: fix pixel format lookup in enum_framesizes
Subsystems (3)
PATCH 1/1 media: vimc: fix pixel format lookup in enum_framesizes
vimc_capture_enum_framesizes() looks up the requested format using vimc_pix_map_by_code(), which searches the pix map table by media bus code (MEDIA_BUS_FMT_*).
However, v4l2_frmsizeenum::pixel_format holds a V4L2 pixel format (V4L2_PIX_FMT_*), not a media bus code, so valid pixel formats end up being rejected with -EINVAL.
Fix this by using vimc_pix_map_by_pixelformat() instead, which performs the lookup by pixel format as the ioctl expects.
Fixes 09c41a23a2e2 ("media: Revert "media: vimc: propagate pixel format in the stream"")
Signed-off-by Arash Golgol <[email protected]>
--- drivers/media/test-drivers/vimc/vimc-capture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/test-drivers/vimc/vimc-capture.c +2 -2
@@ -175,8 +175,8 @@ static int vimc_capture_enum_framesizes(struct file *file, void *priv,if (fsize->index)return -EINVAL ; -/* Only accept code in the pix map table */ - vpix =vimc_pix_map_by_code (fsize->pixel_format); +/* Only accept pixel_format in the pix map table */ + vpix =vimc_pix_map_by_pixelformat (fsize->pixel_format);if (!vpix)return -EINVAL ;
Signature · 1 line
2.34.1