Skip to contentSkip to conversation

lib/crypto: aes-gcm: Fix CRYPTO_LIB_GF128HASH selection

PATCH In review Eric Biggers 1 participant 2 messages Jul 22

Subsystems (2)
lore
Share & tools
lore

Eric Biggers

author maintainer
#0 lore raw

PATCH 1/1 lib/crypto: aes-gcm: Fix CRYPTO_LIB_GF128HASH selection

Move the selection of CRYPTO_LIB_GF128HASH from CRYPTO_LIB_AES_GCM to CRYPTO_LIB_AES to avoid a build error when CRYPTO_LIB_AES=y && CRYPTO_LIB_AES_GCM=m. Like the other AES modes, AES-GCM is included in libaes as an optional feature rather than a dedicated module.

---
 lib/crypto/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/crypto/Kconfig +2 -1
index 65a478f69715d..18cc911f79df6 100644
@@ -8,6 +8,8 @@ config CRYPTO_LIB_UTILS
 
 config CRYPTO_LIB_AES
 	tristate
+	# Select dependencies of modes that are part of libaes.
+	select CRYPTO_LIB_GF128HASH if CRYPTO_LIB_AES_GCM != n
 	select CRYPTO_LIB_UTILS
 
 config CRYPTO_LIB_AES_ARCH
@@ -65,7 +67,6 @@ config CRYPTO_LIB_AES_GCM
 	tristate
 	select CRYPTO_LIB_AES
 	select CRYPTO_LIB_AES_CTR
-	select CRYPTO_LIB_GF128HASH
 	help
 	  The AES-GCM library functions.
 

base-commit: e4f23159c8d09b6b15d47f2c95e0a3e7c62f52a2

Signature · 1 line
2.55.0
author maintainer
#1 lore raw
Quoted 9 lines · Eric Biggers

Move the selection of CRYPTO_LIB_GF128HASH from CRYPTO_LIB_AES_GCM to CRYPTO_LIB_AES to avoid a build error when CRYPTO_LIB_AES=y && CRYPTO_LIB_AES_GCM=m. Like the other AES modes, AES-GCM is included in libaes as an optional feature rather than a dedicated module.

I folded this into the fixed commit to eliminate the bisection hazard.

- Eric