hwmon: Add support for currX_emergency and inX_emergency attributes
Subsystems (2)
Guenter Roeck
maintainerPATCH v2 1/1 hwmon: Add support for currX_emergency and inX_emergency attributes
Some hardware monitoring chips support three alarm levels for current and voltage measurements. Add support for currX_emergency and inX_emergency attributes to support such chips.
Cc Manaf Meethalavalappu Pallikunhi <[email protected]>
Signed-off-by Guenter Roeck <[email protected]>
---
v2: Also add emergency alarm attributes, and drop stray What: entry from
documentation.
Documentation/ABI/testing/sysfs-class-hwmon | 24 +++++++++++++++++++++ Documentation/hwmon/sysfs-interface.rst | 8 +++++++ drivers/hwmon/hwmon.c | 4 ++++ include/linux/hwmon.h | 8 +++++++ 4 files changed, 44 insertions(+)
Documentation/ABI/testing/sysfs-class-hwmon +24 -0
@@ -81,6 +81,18 @@ Description: take drastic action such as power down or reset. At the very least, it should report a fault. +What: /sys/class/hwmon/hwmonX/inY_emergency +Description: + Voltage emergency max value. + + Unit: millivolt + + RW + + If voltage reaches or exceeds this limit, the system is expected + to take drastic action such as immediate power down or reset. + At the very least, it should report a fault. + What: /sys/class/hwmon/hwmonX/inY_input Description: Voltage input value.
@@ -647,6 +659,18 @@ Description: RW +What: /sys/class/hwmon/hwmonX/currY_emergency +Description: + Current emergency high value. + + Unit: milliampere + + RW + + If a current reaches or exceeds this limit, the system is + expected to take drastic action such as immediate power down + or reset. At the very least, it should report a fault. + What: /sys/class/hwmon/hwmonX/currY_input Description: Current input value
Documentation/hwmon/sysfs-interface.rst +8 -0
@@ -127,6 +127,9 @@ Voltages `in[0-*]_crit` Voltage critical max value. +`in[0-*]_emergency` + Voltage emergency max value. + `in[0-*]_input` Voltage input value.
@@ -332,6 +335,9 @@ Currents `curr[1-*]_crit` Current critical high value. +`curr[1-*]_emergency` + Current emergency high value. + `curr[1-*]_input` Current input value.
@@ -529,10 +535,12 @@ implementation. | `in[0-*]_max_alarm`, | | | `in[0-*]_lcrit_alarm`, | - 0: no alarm | | `in[0-*]_crit_alarm`, | - 1: alarm | +| `in[0-*]_emergency_alarm`, | | | `curr[1-*]_min_alarm`, | | | `curr[1-*]_max_alarm`, | RO | | `curr[1-*]_lcrit_alarm`, | | | `curr[1-*]_crit_alarm`, | | +| `curr[1-*]_emergency_alarm`, | | | `power[1-*]_cap_alarm`, | | | `power[1-*]_max_alarm`, | | | `power[1-*]_crit_alarm`, | |
drivers/hwmon/hwmon.c +4 -0
@@ -621,6 +621,7 @@ static const char * const hwmon_in_attr_templates[] = { [hwmon_in_max] = "in%d_max", [hwmon_in_lcrit] = "in%d_lcrit", [hwmon_in_crit] = "in%d_crit", + [hwmon_in_emergency] = "in%d_emergency", [hwmon_in_average] = "in%d_average", [hwmon_in_lowest] = "in%d_lowest", [hwmon_in_highest] = "in%d_highest",
@@ -631,6 +632,7 @@ static const char * const hwmon_in_attr_templates[] = { [hwmon_in_max_alarm] = "in%d_max_alarm", [hwmon_in_lcrit_alarm] = "in%d_lcrit_alarm", [hwmon_in_crit_alarm] = "in%d_crit_alarm", + [hwmon_in_emergency_alarm] = "in%d_emergency_alarm", [hwmon_in_rated_min] = "in%d_rated_min", [hwmon_in_rated_max] = "in%d_rated_max", [hwmon_in_beep] = "in%d_beep",
@@ -644,6 +646,7 @@ static const char * const hwmon_curr_attr_templates[] = { [hwmon_curr_max] = "curr%d_max", [hwmon_curr_lcrit] = "curr%d_lcrit", [hwmon_curr_crit] = "curr%d_crit", + [hwmon_curr_emergency] = "curr%d_emergency", [hwmon_curr_average] = "curr%d_average", [hwmon_curr_lowest] = "curr%d_lowest", [hwmon_curr_highest] = "curr%d_highest",
@@ -654,6 +657,7 @@ static const char * const hwmon_curr_attr_templates[] = { [hwmon_curr_max_alarm] = "curr%d_max_alarm", [hwmon_curr_lcrit_alarm] = "curr%d_lcrit_alarm", [hwmon_curr_crit_alarm] = "curr%d_crit_alarm", + [hwmon_curr_emergency_alarm] = "curr%d_emergency_alarm", [hwmon_curr_rated_min] = "curr%d_rated_min", [hwmon_curr_rated_max] = "curr%d_rated_max", [hwmon_curr_beep] = "curr%d_beep",
include/linux/hwmon.h +8 -0
@@ -134,6 +134,7 @@ enum hwmon_in_attributes { hwmon_in_max, hwmon_in_lcrit, hwmon_in_crit, + hwmon_in_emergency, hwmon_in_average, hwmon_in_lowest, hwmon_in_highest,
@@ -144,6 +145,7 @@ enum hwmon_in_attributes { hwmon_in_max_alarm, hwmon_in_lcrit_alarm, hwmon_in_crit_alarm, + hwmon_in_emergency_alarm, hwmon_in_rated_min, hwmon_in_rated_max, hwmon_in_beep,
@@ -156,6 +158,7 @@ enum hwmon_in_attributes {#define HWMON_I_MAX BIT(hwmon_in_max)#define HWMON_I_LCRIT BIT(hwmon_in_lcrit)#define HWMON_I_CRIT BIT(hwmon_in_crit) +#define HWMON_I_EMERGENCY BIT(hwmon_in_emergency)#define HWMON_I_AVERAGE BIT(hwmon_in_average)#define HWMON_I_LOWEST BIT(hwmon_in_lowest)#define HWMON_I_HIGHEST BIT(hwmon_in_highest)
@@ -166,6 +169,7 @@ enum hwmon_in_attributes {#define HWMON_I_MAX_ALARM BIT(hwmon_in_max_alarm)#define HWMON_I_LCRIT_ALARM BIT(hwmon_in_lcrit_alarm)#define HWMON_I_CRIT_ALARM BIT(hwmon_in_crit_alarm) +#define HWMON_I_EMERGENCY_ALARM BIT(hwmon_in_emergency_alarm)#define HWMON_I_RATED_MIN BIT(hwmon_in_rated_min)#define HWMON_I_RATED_MAX BIT(hwmon_in_rated_max)#define HWMON_I_BEEP BIT(hwmon_in_beep)
@@ -178,6 +182,7 @@ enum hwmon_curr_attributes { hwmon_curr_max, hwmon_curr_lcrit, hwmon_curr_crit, + hwmon_curr_emergency, hwmon_curr_average, hwmon_curr_lowest, hwmon_curr_highest,
@@ -188,6 +193,7 @@ enum hwmon_curr_attributes { hwmon_curr_max_alarm, hwmon_curr_lcrit_alarm, hwmon_curr_crit_alarm, + hwmon_curr_emergency_alarm, hwmon_curr_rated_min, hwmon_curr_rated_max, hwmon_curr_beep,
@@ -199,6 +205,7 @@ enum hwmon_curr_attributes {#define HWMON_C_MAX BIT(hwmon_curr_max)#define HWMON_C_LCRIT BIT(hwmon_curr_lcrit)#define HWMON_C_CRIT BIT(hwmon_curr_crit) +#define HWMON_C_EMERGENCY BIT(hwmon_curr_emergency)#define HWMON_C_AVERAGE BIT(hwmon_curr_average)#define HWMON_C_LOWEST BIT(hwmon_curr_lowest)#define HWMON_C_HIGHEST BIT(hwmon_curr_highest)
@@ -209,6 +216,7 @@ enum hwmon_curr_attributes {#define HWMON_C_MAX_ALARM BIT(hwmon_curr_max_alarm)#define HWMON_C_LCRIT_ALARM BIT(hwmon_curr_lcrit_alarm)#define HWMON_C_CRIT_ALARM BIT(hwmon_curr_crit_alarm) +#define HWMON_C_EMERGENCY_ALARM BIT(hwmon_curr_emergency_alarm)#define HWMON_C_RATED_MIN BIT(hwmon_curr_rated_min)#define HWMON_C_RATED_MAX BIT(hwmon_curr_rated_max)#define HWMON_C_BEEP BIT(hwmon_curr_beep)
Signature · 1 line
2.45.2
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
Some hardware monitoring chips support three alarm levels for current and voltage measurements. Add support for
currX_emergencyandinX_emergencyattributes to support such chips.Cc Manaf Meethalavalappu Pallikunhi <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1