ndctl.spec.in: make xmlto BuildRequires depend on rhel < 9
Alison Schofield
maintainerPATCH 1/1 ndctl.spec.in: make xmlto BuildRequires depend on rhel < 9
From: Michal Schorm <[email protected]>
'xmlto' is only needed alongside 'asciidoc' on RHEL < 9. On Fedora and RHEL >= 9, documentation is built with 'rubygem-asciidoctor' via '-Dasciidoctor=enabled', which does not require 'xmlto'. Move the dependency inside the existing RHEL < 9 conditional.
Related: rhbz#2503124
Reposted from:
https://src.fedoraproject.org/rpms/ndctl/pull-request/4#
---
Michal, ndctl tool operates via mailing list, not PRs, so reposted your fixup here.
ndctl.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ndctl.spec.in +1 -1
@@ -12,6 +12,7 @@ Requires: CXL_LNAME%{?_isa} = %{version}-%{release} BuildRequires: autoconf %if 0%{?rhel} && 0%{?rhel} < 9 BuildRequires: asciidoc +BuildRequires: xmlto %define asciidoctor -Dasciidoctor=disabled %define libtracefs -Dlibtracefs=disabled %else
@@ -21,7 +22,6 @@ BuildRequires: libtracefs-devel %define asciidoctor -Dasciidoctor=enabled %define libtracefs -Dlibtracefs=enabled %endif -BuildRequires: xmlto BuildRequires: automake BuildRequires: libtool BuildRequires: pkgconfig
Signature · 1 line
2.37.3
Quoted 1 line · Alison Schofield
From: Michal Schorm <[email protected]>
Mailer caught my mistake above, missing a c in Schorm. I'll fix that up.
Applied to pending for NDCTL v86
https://github.com/pmem/ndctl/commits/pending/
Quoted 46 lines
'xmlto' is only needed alongside 'asciidoc' on RHEL < 9. On Fedora and RHEL >= 9, documentation is built with 'rubygem-asciidoctor' via '-Dasciidoctor=enabled', which does not require 'xmlto'. Move the dependency inside the existing RHEL < 9 conditional.
Related: rhbz#2503124
Reposted from:
https://src.fedoraproject.org/rpms/ndctl/pull-request/4#Assisted-by Claude AI <[email protected]>Signed-off-by Michal Schorm <[email protected]>Reviewed-by Alison Schofield <[email protected]>---
Michal, ndctl tool operates via mailing list, not PRs, so reposted your fixup here.
ndctl.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)ndctl.spec.in +1
-1@@ -12,6 +12,7 @@ Requires: CXL_LNAME%{?_isa} = %{version}-%{release} BuildRequires: autoconf %if 0%{?rhel} && 0%{?rhel} < 9 BuildRequires: asciidoc +BuildRequires: xmlto %define asciidoctor -Dasciidoctor=disabled %define libtracefs -Dlibtracefs=disabled %else@@ -21,7 +22,6 @@ BuildRequires: libtracefs-devel %define asciidoctor -Dasciidoctor=enabled %define libtracefs -Dlibtracefs=enabled %endif -BuildRequires: xmlto BuildRequires: automake BuildRequires: libtool BuildRequires: pkgconfigSignature · 1 line
2.37.3