platform/x86/intel/pmc: Update NVLS PCDS LPM request GUID
Subsystems (2)
Xi Pardee
maintainerPATCH v2 1/1 platform/x86/intel/pmc: Update NVLS PCDS LPM request GUID
The PMC SSRAM PMT telemetry GUID for Nova Lake S (NVLS) PCDS die changed due to a firmware version bump. The GUID is used by the PMC core driver to locate the correct PMT telemetry entry in SSRAM; if it doesn't match the firmware-reported value, the driver fails to find the LPM (Low Power Mode) data and cannot load properly.
Update PCDS_LPM_REQ_GUID from 0x01091102 to 0x01091103 to match the new firmware version.
--- drivers/platform/x86/intel/pmc/nvl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/pmc/nvl.c +1 -1
@@ -14,7 +14,7 @@/* PMC SSRAM PMT Telemetry GUIDS */ #define PCDH_LPM_REQ_GUID 0x01093101#define PCHS_LPM_REQ_GUID 0x01092101 -#define PCDS_LPM_REQ_GUID 0x01091102 +#define PCDS_LPM_REQ_GUID 0x01091103/* * Die Mapping to Product.
Signature · 1 line
2.43.0
Ilpo Järvinen
maintainerQuoted 8 lines · Xi Pardee
The PMC SSRAM PMT telemetry GUID for Nova Lake S (NVLS) PCDS die changed due to a firmware version bump. The GUID is used by the PMC core driver to locate the correct PMT telemetry entry in SSRAM; if it doesn't match the firmware-reported value, the driver fails to find the LPM (Low Power Mode) data and cannot load properly.
Update
PCDS_LPM_REQ_GUIDfrom0x01091102to0x01091103to match the new firmware version.
Hi,
Unfortunately this still lacks the reason why it's okay to not have 0x01091102 at all in the kernel.
Whenever there's two (or more) FW versions mentioned in the changelog and one is taken away, it should be explained why "removing" one does not result in taking away functionality for systems that have the old FW version.
It may be dead obvious to you at this moment such as that this thing hasn't launched but it should still be recorded into the changelog so others don't need to lookup such details.
It seems to become a theme these get updated so hopefully next time we don't need 3 patch versions. :-)
Signature · 1 line
i.
Quoted 19 lines
Signed-off-by Xi Pardee <[email protected]>--- drivers/platform/x86/intel/pmc/nvl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/intel/pmc/nvl.c +1
-1@@ -14,7 +14,7 @@/* PMC SSRAM PMT Telemetry GUIDS */ #define PCDH_LPM_REQ_GUID 0x01093101#define PCHS_LPM_REQ_GUID 0x01092101 -#define PCDS_LPM_REQ_GUID 0x01091102 +#define PCDS_LPM_REQ_GUID 0x01091103/* * Die Mapping to Product.