Skip to contentSkip to conversation

mtd: maps: remove dead select of MTD_CFI_BE_BYTE_SWAP

PATCH Applied Julian Braha 4 participants 4 messages Jul 22 – Aug 7 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mtd: maps: remove dead select of MTD_CFI_BE_BYTE_SWAP

'select' does not work on config options in a 'choice', so currently it is possible to enable MTD_PHYSMAP_IXP4XX without MTD_CFI_BE_BYTE_SWAP.

From a previous conversation, it was decided to remove the select entirely:
https://lore.kernel.org/all/[email protected]/

This dead select was found by kconfirm, a static analysis tool for Kconfig.

---
Changes since v1: remove 'select' instead of using 'depends on' Link:
https://lore.kernel.org/all/[email protected]/

---
 drivers/mtd/maps/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/mtd/maps/Kconfig +0 -1
index f447902d707e..1bb3dba2631d 100644
@@ -101,7 +101,6 @@ config MTD_PHYSMAP_IXP4XX
 	depends on MTD_PHYSMAP_OF
 	depends on ARM
 	select MTD_COMPLEX_MAPPINGS
-	select MTD_CFI_BE_BYTE_SWAP if CPU_BIG_ENDIAN
 	default ARCH_IXP4XX
 	help
 	  This provides some extra DT physmap parsing for the Intel IXP4xx
Signature · 1 line
2.54.0
Acked-by on v2 1/1
#1 lore raw
Quoted 11 lines · Julian Braha

'select' does not work on config options in a 'choice', so currently it is possible to enable MTD_PHYSMAP_IXP4XX without MTD_CFI_BE_BYTE_SWAP.

From a previous conversation, it was decided to remove the select entirely:
https://lore.kernel.org/all/[email protected]/

This dead select was found by kconfirm, a static analysis tool for Kconfig.

---

#2 lore raw
In reply to Julian Braha
Quoted 5 lines · Julian Braha

'select' does not work on config options in a 'choice', so currently it is possible to enable MTD_PHYSMAP_IXP4XX without MTD_CFI_BE_BYTE_SWAP.

From a previous conversation, it was decided to remove the select entirely:
https://lore.kernel.org/all/[email protected]/

You can make this a proper Link tag.

"From a previous conversation [1], it was decided to remove the select entirely.
...
Link: $URL [1]"

Quoted 1 line

This dead select was found by kconfirm, a static analysis tool for Kconfig.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#3 lore raw
In reply to Julian Braha
Quoted 9 lines · Julian Braha

'select' does not work on config options in a 'choice', so currently it is possible to enable MTD_PHYSMAP_IXP4XX without MTD_CFI_BE_BYTE_SWAP.

Quoted 1 line

From a previous conversation, it was decided to remove the select entirely:

https://lore.kernel.org/all/[email protected]/

This dead select was found by kconfirm, a static analysis tool for Kconfig.

[...]

Applied to mtd/next, thanks!

[1/1] mtd: maps: remove dead select of MTD_CFI_BE_BYTE_SWAP

      commit: 94d32f1ace8ee3ef3537ac6c8e71b76a418a4762

Patche(s) should be available on mtd/linux.git and will be part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl