clk: qcom: add MSM8920 RPM clock controller support
Subsystems (5)
cover clk: qcom: add MSM8920 RPM clock controller support
Add MSM8920 support to the SMD RPM clock controller.
MSM8920 is essentially MSM8917 with MSM8953's modem stack, which adds an IPA block. The new rpmcc table is MSM8917's clocks plus RPM_SMD_IPA_{,A_}CLK (same IPA IDs already used by MSM8940; no new dt-bindings/clock/qcom,rpmcc.h entries needed).
This series is split binding-then-driver so the shared clk-smd-rpm changes can land via linux-arm-msm independently of the MSM8920 / perry device trees (requested in msm89x7-mainline/linux#48 review).
Based on qcom/for-next (d36de2e50966). Applies cleanly there; also applies to torvalds/master with a trivial yaml-schema context shift (flat items vs oneOf) if preferred.
Hardware context: needed for initial MSM8920 + Motorola Moto E4 (perry) upstream DTS follow-up. Fork PR tracking: msm89x7-mainline/linux#48.
Catherine Frederick authored the original fork series; this re-roll keeps her From:/SoB and adds an [aneesh:] note + SoB for the split / rebase onto the current for-next binding schema.
Catherine Frederick (coolguy) (2):
dt-bindings: clock: qcom,rpmcc: add MSM8920
clk: qcom: smd-rpm: add MSM8920 support
.../devicetree/bindings/clock/qcom,rpmcc.yaml | 2 ++ drivers/clk/qcom/clk-smd-rpm.c | 31 +++++++++++++++++++ 2 files changed, 33 insertions(+)
base-commit: d36de2e50966f3dd9ef3482f1faf649b3d697714
Signature · 1 line
2.53.0
PATCH 1/2 dt-bindings: clock: qcom,rpmcc: add MSM8920
From: "Catherine Frederick (coolguy)" <[email protected]>
Document the "qcom,rpmcc-msm8920" compatible for the RPM clock controller found on MSM8920.
[aneesh: split the binding into its own patch per submitting-patches; rebased onto qcom/for-next oneOf compatible schema]
--- Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml +2 -0
@@ -33,6 +33,7 @@ properties: - qcom,rpmcc-msm8909 - qcom,rpmcc-msm8916 - qcom,rpmcc-msm8917 + - qcom,rpmcc-msm8920 - qcom,rpmcc-msm8936 - qcom,rpmcc-msm8937 - qcom,rpmcc-msm8940
@@ -118,6 +119,7 @@ allOf: - qcom,rpmcc-msm8226 - qcom,rpmcc-msm8916 - qcom,rpmcc-msm8917 + - qcom,rpmcc-msm8920 - qcom,rpmcc-msm8936 - qcom,rpmcc-msm8937 - qcom,rpmcc-msm8940
Signature · 1 line
2.53.0
Re: [PATCH 1/2] dt-bindings: clock: qcom,rpmcc: add MSM8920
Quoted 5 lines · Aneesh Pradhan
From: "Catherine Frederick (coolguy)" <[email protected]>
Document the "qcom,rpmcc-msm8920" compatible for the RPM clock controller found on MSM8920.
Quoted 8 lines
Signed-off-by Catherine Frederick (coolguy) <[email protected]>[aneesh: split the binding into its own patch per submitting-patches; rebased onto qcom/for-next oneOf compatible schema]
Signed-off-by Aneesh Pradhan <[email protected]>--- Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml | 2 ++ 1 file changed, 2 insertions(+)
PATCH 2/2 clk: qcom: smd-rpm: add MSM8920 support
In reply to Aneesh PradhanFrom: "Catherine Frederick (coolguy)" <[email protected]>
MSM8920 is essentially MSM8917 with MSM8953's modem stack, which adds an IPA (IP Accelerator) block. Add an msm8920 RPM clock table mirroring msm8917's plus the IPA and IPA_A clocks, and register the "qcom,rpmcc-msm8920" compatible.
Split out from the combined MSM8920 change so the shared clk-smd-rpm driver can be reviewed and land via linux-arm-msm independently of the device tree, as requested in review.
--- drivers/clk/qcom/clk-smd-rpm.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)
drivers/clk/qcom/clk-smd-rpm.c +31 -0
@@ -667,6 +667,36 @@ static const struct rpm_smd_clk_desc rpm_clk_msm8917 = { .num_icc_clks = ARRAY_SIZE(bimc_pcnoc_snoc_smmnoc_icc_clks), }; +static struct clk_smd_rpm *msm8920_clks[] = { + [RPM_SMD_XO_CLK_SRC ] = &clk_smd_rpm_branch_bi_tcxo, + [RPM_SMD_XO_A_CLK_SRC ] = &clk_smd_rpm_branch_bi_tcxo_a, + [RPM_SMD_BIMC_GPU_CLK ] = &clk_smd_rpm_bimc_gpu_clk, + [RPM_SMD_BIMC_GPU_A_CLK ] = &clk_smd_rpm_bimc_gpu_a_clk, + [RPM_SMD_IPA_CLK ] = &clk_smd_rpm_ipa_clk, + [RPM_SMD_IPA_A_CLK ] = &clk_smd_rpm_ipa_a_clk, + [RPM_SMD_QDSS_CLK ] = &clk_smd_rpm_qdss_clk, + [RPM_SMD_QDSS_A_CLK ] = &clk_smd_rpm_qdss_a_clk, + [RPM_SMD_BB_CLK1 ] = &clk_smd_rpm_bb_clk1, + [RPM_SMD_BB_CLK1_A ] = &clk_smd_rpm_bb_clk1_a, + [RPM_SMD_BB_CLK2 ] = &clk_smd_rpm_bb_clk2, + [RPM_SMD_BB_CLK2_A ] = &clk_smd_rpm_bb_clk2_a, + [RPM_SMD_RF_CLK2 ] = &clk_smd_rpm_rf_clk2, + [RPM_SMD_RF_CLK2_A ] = &clk_smd_rpm_rf_clk2_a, + [RPM_SMD_DIV_CLK2 ] = &clk_smd_rpm_div_clk2, + [RPM_SMD_DIV_A_CLK2 ] = &clk_smd_rpm_div_clk2_a, + [RPM_SMD_BB_CLK1_PIN ] = &clk_smd_rpm_bb_clk1_pin, + [RPM_SMD_BB_CLK1_A_PIN ] = &clk_smd_rpm_bb_clk1_a_pin, + [RPM_SMD_BB_CLK2_PIN ] = &clk_smd_rpm_bb_clk2_pin, + [RPM_SMD_BB_CLK2_A_PIN ] = &clk_smd_rpm_bb_clk2_a_pin, +}; + +static const struct rpm_smd_clk_desc rpm_clk_msm8920 = { + .clks = msm8920_clks, + .num_clks =ARRAY_SIZE (msm8920_clks), + .icc_clks = bimc_pcnoc_snoc_smmnoc_icc_clks, + .num_icc_clks =ARRAY_SIZE (bimc_pcnoc_snoc_smmnoc_icc_clks), +}; +static struct clk_smd_rpm *msm8936_clks[] = { [RPM_SMD_XO_CLK_SRC ] = &clk_smd_rpm_branch_bi_tcxo, [RPM_SMD_XO_A_CLK_SRC ] = &clk_smd_rpm_branch_bi_tcxo_a,
@@ -1300,6 +1330,7 @@ static const struct of_device_id rpm_smd_clk_match_table[] = { { .compatible = "qcom,rpmcc-msm8909", .data = &rpm_clk_msm8909 }, { .compatible = "qcom,rpmcc-msm8916", .data = &rpm_clk_msm8916 }, { .compatible = "qcom,rpmcc-msm8917", .data = &rpm_clk_msm8917 }, + { .compatible = "qcom,rpmcc-msm8920", .data = &rpm_clk_msm8920 }, { .compatible = "qcom,rpmcc-msm8936", .data = &rpm_clk_msm8936 }, { .compatible = "qcom,rpmcc-msm8937", .data = &rpm_clk_msm8937 }, { .compatible = "qcom,rpmcc-msm8940", .data = &rpm_clk_msm8940 },
Signature · 1 line
2.53.0
Re: [PATCH 2/2] clk: qcom: smd-rpm: add MSM8920 support
Quoted 7 lines · Aneesh Pradhan
From: "Catherine Frederick (coolguy)" <[email protected]>
MSM8920 is essentially MSM8917 with MSM8953's modem stack, which adds an IPA (IP Accelerator) block. Add an msm8920 RPM clock table mirroring msm8917's plus the IPA and
IPA_Aclocks, and register the "qcom,rpmcc-msm8920" compatible.
Quoted 8 lines
Split out from the combined MSM8920 change so the shared clk-smd-rpm driver can be reviewed and land via linux-arm-msm independently of the device tree, as requested in review.
Signed-off-by Catherine Frederick (coolguy) <[email protected]>[aneesh: split rpmcc out of the SoC dtsi commit for upstream-first review]Signed-off-by Aneesh Pradhan <[email protected]>---
Konrad
cover arm64: dts: qcom: initial MSM8920 and Motorola Moto E4 (perry)
In reply to Aneesh PradhanInitial upstream support for MSM8920 and the Motorola Moto E4 (perry).
Depends on the separate qcom,rpmcc-msm8920 clk series (binding + clk-smd-rpm) for the MSM8920 rpmcc compatible used by msm8920.dtsi.
This is a trimmed mainline-first subset of msm89x7-mainline/linux#48, rewritten so every phandle exists on qcom/for-next's msm8917 / pm8937 / pmi8950 (the fork DT assumed richer SoC/PMIC nodes that are not upstream yet).
Included: regulators, eMMC/SD, USB OTG (gpio-id extcon), keys, RMI4 touch + reset-gpios, BMA253 (i2c-gpio), WCNSS (wcn3660b), PMI8950 WLED. Deferred follow-ups: DSI panel, IPA, QDSP6 audio, FG/smbcharger, modem.
DTB build verified: msm8917-motorola-perry.dtb + msm8920-motorola-perry.dtb.
Catherine Frederick (coolguy) (3):
dt-bindings: arm: qcom: add MSM8920 and Motorola Moto E4 (perry)
arm64: dts: qcom: add initial MSM8920 device tree
arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
.../devicetree/bindings/arm/qcom.yaml | 7 + arch/arm64/boot/dts/qcom/Makefile | 2 + .../qcom/msm8917-motorola-perry-common.dtsi | 412 ++++++++++++++++++ .../boot/dts/qcom/msm8917-motorola-perry.dts | 20 + .../boot/dts/qcom/msm8920-motorola-perry.dts | 20 + arch/arm64/boot/dts/qcom/msm8920.dtsi | 12 + 6 files changed, 473 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi create mode 100644 arch/arm64/boot/dts/qcom/msm8917-motorola-perry.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8920.dtsi
base-commit: a27464b0b99874d22b04a92186ab7ea9252c3847
Signature · 1 line
2.53.0
PATCH 1/3 dt-bindings: arm: qcom: add MSM8920 and Motorola Moto E4 (perry)
From: "Catherine Frederick (coolguy)" <[email protected]>
Document the Motorola Moto E4 (perry) board compatible for MSM8917 and MSM8920, and add qcom,msm8920 to the SoC compatible list.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +7 -0
@@ -261,11 +261,17 @@ properties: - items: - enum: + - motorola,perry - xiaomi,riva - xiaomi,rolex - xiaomi,tiare - const: qcom,msm8917 + - items: + - enum: + - motorola,perry + - const: qcom,msm8920 + - items: - enum: - wingtech,wt82918hd
@@ -1323,6 +1329,7 @@ allOf: - qcom,apq8094 - qcom,apq8096 - qcom,msm8917 + - qcom,msm8920 - qcom,msm8937 - qcom,msm8939 - qcom,msm8953
Signature · 1 line
2.53.0
PATCH 2/3 arm64: dts: qcom: add initial MSM8920 device tree
In reply to Aneesh PradhanFrom: "Catherine Frederick (coolguy)" <[email protected]>
MSM8920 is MSM8917 with a different RPM clock compatible (IPA clocks present in rpmcc-msm8920). Start with the minimal SoC dtsi: include msm8917.dtsi and override &rpmcc. IPA and other 8920-only peripherals are deferred until their drivers/bindings are upstream.
Depends on the qcom,rpmcc-msm8920 binding/driver series.
--- arch/arm64/boot/dts/qcom/msm8920.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8920.dtsi
arch/arm64/boot/dts/qcom/msm8920.dtsi new file +12 -0
@@ -0,0 +1,12 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2023, Dang Huynh <[email protected]> + * Copyright (c) 2026, Aneesh Pradhan <[email protected]> + */ + +#include "msm8917.dtsi" + +/* MSM8920 uses the MSM8917 RPM clock set plus IPA clocks (see rpmcc-msm8920). */ +&rpmcc { + compatible = "qcom,rpmcc-msm8920", "qcom,rpmcc"; +};
Signature · 1 line
2.53.0
PATCH 3/3 arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
In reply to Aneesh PradhanFrom: "Catherine Frederick (coolguy)" <[email protected]>
Add MSM8917 and MSM8920 board files for the Motorola Moto E4 (perry) sharing a common dtsi, shaped against in-tree msm8917-xiaomi-wingtech / msm8937-xiaomi-land so every referenced label exists on mainline.
Initial subset: regulators, eMMC/SD, USB OTG (gpio extcon), gpio-keys, Synaptics RMI4 touchscreen, BMA253 via i2c-gpio, WCNSS Wi-Fi (qcom,wcn3660b), PMI8950 WLED.
Deferred (missing mainline SoC/PMIC nodes or drivers): DSI panel/MDSS, IPA, QDSP6/WCD audio, PMI8950 FG/smbcharger, modem/ADSP/Venus remoteprocs.
Validated on XT1765 under postmarketOS with a fuller fork DT carry; this is the trimmed upstream-first subset.
[aneesh: rewrite against mainline msm8917/pm8937/pmi8950; drop fork-only
nodes]
--- arch/arm64/boot/dts/qcom/Makefile | 2 + .../qcom/msm8917-motorola-perry-common.dtsi | 412 ++++++++++++++++++ .../boot/dts/qcom/msm8917-motorola-perry.dts | 20 + .../boot/dts/qcom/msm8920-motorola-perry.dts | 20 + 4 files changed, 454 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi create mode 100644 arch/arm64/boot/dts/qcom/msm8917-motorola-perry.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts
arch/arm64/boot/dts/qcom/Makefile +2 -0
@@ -109,6 +109,8 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-yiming-uz801v3.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-riva.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-rolex.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-tiare.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8917-motorola-perry.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8920-motorola-perry.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8929-wingtech-wt82918hd.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8937-xiaomi-land.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8939-asus-z00t.dtb
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +412 -0
412 lines not on this page · raw message
arch/arm64/boot/dts/qcom/msm8917-motorola-perry.dts new file +20 -0
@@ -0,0 +1,20 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2025 Val Packett + * Copyright (c) 2026, Aneesh Pradhan <[email protected]> + */ + +/dts-v1/; + +#include "msm8917.dtsi" +#include "msm8917-motorola-perry-common.dtsi" + +/ { + model = "Motorola Moto E4 (perry)"; + compatible = "motorola,perry", "qcom,msm8917"; + qcom,msm-id = <QCOM_ID_MSM8917 0>; + qcom,board-id = <0x48 0x8100>, + <0x48 0x80b0>, + <0x48 0x80a0>; + chassis-type = "handset"; +};
arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts new file +20 -0
@@ -0,0 +1,20 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2025 Val Packett + * Copyright (c) 2026, Aneesh Pradhan <[email protected]> + */ + +/dts-v1/; + +#include "msm8920.dtsi" +#include "msm8917-motorola-perry-common.dtsi" + +/ { + model = "Motorola Moto E4 (perry)"; + compatible = "motorola,perry", "qcom,msm8920"; + qcom,msm-id = <QCOM_ID_MSM8920 0>; + qcom,board-id = <0x48 0x8100>, + <0x48 0x80b0>, + <0x48 0x80a0>; + chassis-type = "handset"; +};
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Device Tree blob entries in the Makefile are not sorted alphabetically. --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device Tree blob entries in the Makefile are not sorted alphabetically. --
--- Patch [3]: [PATCH 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support --- commit f1e9e7f386e094ca8238575174ce1d5dde0b3f6c
Author: Catherine Frederick (coolguy) <[email protected]>
arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
This commit adds MSM8917 and MSM8920 board files for the Motorola Moto E4 (perry) sharing a common dtsi. It includes an initial subset of peripherals such as regulators, eMMC/SD, USB OTG, and touchscreen, while deferring peripherals lacking mainline drivers.
arch/arm64/boot/dts/qcom/Makefile dtb-$(CONFIG_ARCH_QCOM) += msm8916-yiming-uz801v3.dtb · line 113
Quoted 10 lines
arch/arm64/boot/dts/qcom/Makefile +2
-0@@ -109,6 +109,8 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-yiming-uz801v3.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-riva.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-rolex.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-tiare.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8917-motorola-perry.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8920-motorola-perry.dtb
[Severity: Low]
This isn't a bug, but shouldn't these new device tree blobs be sorted alphabetically within the Makefile?
It looks like msm8917-motorola-perry.dtb is being inserted after the msm8917-xiaomi-* entries. Placing it before msm8917-xiaomi-riva.dtb would follow the existing sorting convention and help minimize merge conflicts.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
v2 cover arm64: dts: qcom: initial MSM8920 and Motorola Moto E4 (perry)
In reply to Aneesh PradhanInitial upstream support for MSM8920 and the Motorola Moto E4 (perry).
Depends on the separate qcom,rpmcc-msm8920 clk series (binding + clk-smd-rpm) for the MSM8920 rpmcc compatible used by msm8920.dtsi.
This is a trimmed mainline-first subset of msm89x7-mainline/linux#48, rewritten so every phandle exists on qcom/for-next's msm8917 / pm8937 / pmi8950 (the fork DT assumed richer SoC/PMIC nodes that are not upstream yet).
Included: regulators, eMMC/SD, USB OTG (gpio-id extcon), keys, RMI4 touch + reset-gpios, BMA253 (i2c-gpio), WCNSS (wcn3660b), PMI8950 WLED. Deferred follow-ups: DSI panel, IPA, QDSP6 audio, FG/smbcharger, modem.
DTB build verified: msm8917-motorola-perry.dtb + msm8920-motorola-perry.dtb.
Changes since v1:
- Sort Makefile DTB entries alphabetically: place msm8917-motorola-perry.dtb before msm8917-xiaomi-*, keeping msm8920-motorola-perry.dtb after the msm8917 block (Sashiko review on v1 patch 3/3).
Catherine Frederick (coolguy) (3):
dt-bindings: arm: qcom: add MSM8920 and Motorola Moto E4 (perry)
arm64: dts: qcom: add initial MSM8920 device tree
arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
.../devicetree/bindings/arm/qcom.yaml | 7 + arch/arm64/boot/dts/qcom/Makefile | 2 + .../qcom/msm8917-motorola-perry-common.dtsi | 412 ++++++++++++++++++ .../boot/dts/qcom/msm8917-motorola-perry.dts | 20 + .../boot/dts/qcom/msm8920-motorola-perry.dts | 20 + arch/arm64/boot/dts/qcom/msm8920.dtsi | 12 + 6 files changed, 473 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi create mode 100644 arch/arm64/boot/dts/qcom/msm8917-motorola-perry.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8920.dtsi
base-commit: a27464b0b99874d22b04a92186ab7ea9252c3847
Signature · 1 line
2.53.0
PATCH v2 1/3 dt-bindings: arm: qcom: add MSM8920 and Motorola Moto E4 (perry)
From: "Catherine Frederick (coolguy)" <[email protected]>
Document the Motorola Moto E4 (perry) board compatible for MSM8917 and MSM8920, and add qcom,msm8920 to the SoC compatible list.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +7 -0
@@ -261,11 +261,17 @@ properties: - items: - enum: + - motorola,perry - xiaomi,riva - xiaomi,rolex - xiaomi,tiare - const: qcom,msm8917 + - items: + - enum: + - motorola,perry + - const: qcom,msm8920 + - items: - enum: - wingtech,wt82918hd
@@ -1323,6 +1329,7 @@ allOf: - qcom,apq8094 - qcom,apq8096 - qcom,msm8917 + - qcom,msm8920 - qcom,msm8937 - qcom,msm8939 - qcom,msm8953
Signature · 1 line
2.53.0
Re: [PATCH v2 1/3] dt-bindings: arm: qcom: add MSM8920 and Motorola Moto E4 (perry)
Quoted 19 lines · Aneesh Pradhan
From: "Catherine Frederick (coolguy)" <[email protected]>
Document the Motorola Moto E4 (perry) board compatible for MSM8917 and MSM8920, and add qcom,msm8920 to the SoC compatible list.
Signed-off-by Catherine Frederick (coolguy) <[email protected]>[aneesh: split bindings into their own patch; add msm8920 SoC enum]Signed-off-by Aneesh Pradhan <[email protected]>--- Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/arm/qcom.yaml +0
-0@@ -261,11 +261,17 @@ properties: - items:
Documentation/devicetree/bindings/arm/qcom.yaml properties: · line 272
Quoted 10 lines
Documentation/devicetree/bindings/arm/qcom.yaml +4
-0- enum: + - motorola,perry - xiaomi,riva - xiaomi,rolex - xiaomi,tiare - const: qcom,msm8917 + - items: + - enum: + - motorola,perry
Duplicated compatible. Same device cannot be both - msm8920 and 8917.
Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830
Best regards,
Krzysztof
PATCH v2 2/3 arm64: dts: qcom: add initial MSM8920 device tree
In reply to Aneesh PradhanFrom: "Catherine Frederick (coolguy)" <[email protected]>
MSM8920 is MSM8917 with a different RPM clock compatible (IPA clocks present in rpmcc-msm8920). Start with the minimal SoC dtsi: include msm8917.dtsi and override &rpmcc. IPA and other 8920-only peripherals are deferred until their drivers/bindings are upstream.
Depends on the qcom,rpmcc-msm8920 binding/driver series.
--- arch/arm64/boot/dts/qcom/msm8920.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8920.dtsi
arch/arm64/boot/dts/qcom/msm8920.dtsi new file +12 -0
@@ -0,0 +1,12 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2023, Dang Huynh <[email protected]> + * Copyright (c) 2026, Aneesh Pradhan <[email protected]> + */ + +#include "msm8917.dtsi" + +/* MSM8920 uses the MSM8917 RPM clock set plus IPA clocks (see rpmcc-msm8920). */ +&rpmcc { + compatible = "qcom,rpmcc-msm8920", "qcom,rpmcc"; +};
Signature · 1 line
2.53.0
PATCH v2 3/3 arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
In reply to Aneesh PradhanFrom: "Catherine Frederick (coolguy)" <[email protected]>
Add MSM8917 and MSM8920 board files for the Motorola Moto E4 (perry) sharing a common dtsi, shaped against in-tree msm8917-xiaomi-wingtech / msm8937-xiaomi-land so every referenced label exists on mainline.
Initial subset: regulators, eMMC/SD, USB OTG (gpio extcon), gpio-keys, Synaptics RMI4 touchscreen, BMA253 via i2c-gpio, WCNSS Wi-Fi (qcom,wcn3660b), and PMI8950 WLED.
Deferred (missing mainline SoC/PMIC nodes or drivers): DSI panel/MDSS, IPA, QDSP6/WCD audio, PMI8950 FG/smbcharger, modem/ADSP/Venus remoteprocs.
Validated on XT1765 under postmarketOS with a fuller fork DT carry; this is the trimmed upstream-first subset.
[aneesh: rewrite against mainline msm8917/pm8937/pmi8950; drop fork-only
nodes; keep Makefile DTB entries alphabetically sorted]
--- arch/arm64/boot/dts/qcom/Makefile | 2 + .../qcom/msm8917-motorola-perry-common.dtsi | 412 ++++++++++++++++++ .../boot/dts/qcom/msm8917-motorola-perry.dts | 20 + .../boot/dts/qcom/msm8920-motorola-perry.dts | 20 + 4 files changed, 454 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi create mode 100644 arch/arm64/boot/dts/qcom/msm8917-motorola-perry.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts
arch/arm64/boot/dts/qcom/Makefile +2 -0
@@ -106,9 +106,11 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86518.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86528.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-yiming-uz801v3.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8917-motorola-perry.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-riva.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-rolex.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-tiare.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8920-motorola-perry.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8929-wingtech-wt82918hd.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8937-xiaomi-land.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8939-asus-z00t.dtb
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +412 -0
412 lines not on this page · raw message
arch/arm64/boot/dts/qcom/msm8917-motorola-perry.dts new file +20 -0
@@ -0,0 +1,20 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2025 Val Packett + * Copyright (c) 2026, Aneesh Pradhan <[email protected]> + */ + +/dts-v1/; + +#include "msm8917.dtsi" +#include "msm8917-motorola-perry-common.dtsi" + +/ { + model = "Motorola Moto E4 (perry)"; + compatible = "motorola,perry", "qcom,msm8917"; + qcom,msm-id = <QCOM_ID_MSM8917 0>; + qcom,board-id = <0x48 0x8100>, + <0x48 0x80b0>, + <0x48 0x80a0>; + chassis-type = "handset"; +};
arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts new file +20 -0
@@ -0,0 +1,20 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2025 Val Packett + * Copyright (c) 2026, Aneesh Pradhan <[email protected]> + */ + +/dts-v1/; + +#include "msm8920.dtsi" +#include "msm8917-motorola-perry-common.dtsi" + +/ { + model = "Motorola Moto E4 (perry)"; + compatible = "motorola,perry", "qcom,msm8920"; + qcom,msm-id = <QCOM_ID_MSM8920 0>; + qcom,board-id = <0x48 0x8100>, + <0x48 0x80b0>, + <0x48 0x80a0>; + chassis-type = "handset"; +};
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] Critical pins for the touchscreen interrupt, sensor I2C bus, sensor interrupt, and regulator…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Critical pins for the touchscreen interrupt, sensor I2C bus, sensor interrupt, and regulator enable lack pinctrl configurations.
- [Medium] Battery design capacity is incorrectly specified for the hardware.
--
--- Patch [3]: [PATCH v2 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support --- commit 456da8a21ca3d3b4649cf6cd9b340f36af9edbf2
Author: Catherine Frederick (coolguy) <[email protected]>
arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
Adds MSM8917 and MSM8920 board files for the Motorola Moto E4 (perry) sharing a common dtsi. Includes regulators, eMMC/SD, USB OTG, gpio-keys, touchscreen, IMU, Wi-Fi, and WLED.
Quoted 7 lines
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +1
-0@@ -0,0 +1,412 @@ +// SPDX-License-Identifier: GPL-2.0-only
[ ... ]
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi line 24
Quoted 4 lines
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +4
-0+ battery: battery { + compatible = "simple-battery"; + + charge-full-design-microamp-hours = <4000000>;
[Severity: Medium]
Does the Moto E4 have a 4000 mAh battery? The design capacity here specifies 4000 mAh, but this device usually ships with a 2800 mAh battery.
Could this incorrect capacity confuse the fuel gauge algorithms and lead to inaccurate state-of-charge calculations?
Quoted 4 lines
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +4
-0+ constant-charge-current-max-microamp = <1000000>; + voltage-min-design-microvolt = <3400000>; + voltage-max-design-microvolt = <4400000>; + };
[ ... ]
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi line 79
Quoted 4 lines
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +4
-0+ i2c-sensors { + compatible = "i2c-gpio"; + sda-gpios = <&tlmm 14 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; + scl-gpios = <&tlmm 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
[Severity: Medium]
Are we missing pinctrl configurations for the I2C bitbanging pins (gpio14, gpio15) and the IMU interrupt pin (gpio41) below?
Relying on bootloader state for these pins could lead to initialization failures if they are left floating or improperly muxed.
Quoted 9 lines
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +9
-0+ i2c-gpio,delay-us = <2>; /* ~100 kHz */ + #address-cells = <1>; + #size-cells = <0>; + + imu@18 { + compatible = "bosch,bma253"; + reg = <0x18>; + + interrupts-extended = <&tlmm 41 IRQ_TYPE_EDGE_RISING>;
[ ... ]
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi line 371
Quoted 6 lines
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +6
-0+ ts_default: ts-default-state { + pins = "gpio64"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + };
[Severity: Medium]
Should the touchscreen interrupt pin (gpio65) be configured in this state as well?
The touchscreen node explicitly uses it:
&blsp1_i2c3 {
touchscreen@20 {
interrupts = <65 IRQ_TYPE_EDGE_FALLING>;
pinctrl-0 = <&ts_default>;
reset-gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
}
}Missing pinctrl on this falling-edge interrupt could result in an interrupt storm if the bootloader doesn't set the correct pin bias.
Quoted 1 line
+};
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Re: [PATCH v2 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
In reply to Aneesh PradhanQuoted 5 lines · Aneesh Pradhan
From: "Catherine Frederick (coolguy)" <[email protected]>
Add MSM8917 and MSM8920 board files for the Motorola Moto E4 (perry) sharing a common dtsi, shaped against in-tree msm8917-xiaomi-wingtech / msm8937-xiaomi-land so every referenced label exists on mainline.
Do we know whether both MSM8917 and MSM8920 variants actually exist in the wild? It's common practice for vendors to include an oversized set of msm-ids in their downstream forks, either because of negligence or because decisions change during product development.
Quoted 10 lines
Initial subset: regulators, eMMC/SD, USB OTG (gpio extcon), gpio-keys, Synaptics RMI4 touchscreen, BMA253 via i2c-gpio, WCNSS Wi-Fi (qcom,wcn3660b), and PMI8950 WLED.
Deferred (missing mainline SoC/PMIC nodes or drivers): DSI panel/MDSS, IPA, QDSP6/WCD audio, PMI8950 FG/smbcharger, modem/ADSP/Venus remoteprocs.
Validated on XT1765 under postmarketOS with a fuller fork DT carry; this is the trimmed upstream-first subset.
You should definitely validate the changes you send on their own, atop linux-next/master
[...]
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi line 40
Quoted 6 lines
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +6
-0+ /* Early console deferred with MDSS; panel driver not upstream yet. */ + stdout-path = "framebuffer0"; + + framebuffer0: framebuffer@90001000 { + compatible = "simple-framebuffer"; + reg = <0x0 0x90001000 0x0 (720 * 1280 * 3)>;
Please use memory-region instead of reg here
Quoted 4 lines
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +4
-0+ width = <720>; + height = <1280>; + stride = <(720 * 3)>; + format = "r8g8b8";
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi line 54
Quoted 10 lines
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +10
-0+ + clocks = <&gcc GCC_MDSS_AHB_CLK>, + <&gcc GCC_MDSS_AXI_CLK>, + <&gcc GCC_MDSS_VSYNC_CLK>, + <&gcc GCC_MDSS_MDP_CLK>, + <&gcc GCC_MDSS_BYTE0_CLK>, + <&gcc GCC_MDSS_PCLK0_CLK>, + <&gcc GCC_MDSS_ESC0_CLK>; + power-domains = <&gcc MDSS_GDSC>; + status = "disabled";
Is this disable an oversight?
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi line 143
Quoted 8 lines
+&blsp1_i2c3 {
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +7
-0+ status = "okay"; + + touchscreen@20 { + compatible = "syna,rmi4-i2c"; + reg = <0x20>; + interrupt-parent = <&tlmm>; + interrupts = <65 IRQ_TYPE_EDGE_FALLING>;
interrupts-extended = <&tlmm 65 IRQ..
[...]
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi line 377
Quoted 4 lines
+&usb {
arch/arm64/boot/dts/qcom/msm8917-motorola-perry-common.dtsi new file +3
-0+ extcon = <&usb_id>, <&usb_id>; + dr_mode = "otg"; + status = "okay";
Please uniformly keep a \n before 'status'
[...]
arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts line 3
Quoted 6 lines
arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts new file +3
-0@@ -0,0 +1,20 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2025 Val Packett
I'm confused as to why Val Packett's copyright is there. Is that the same person as the aforementioned Catherine Frederick?
Konrad
Re: [PATCH v2 0/3] arm64: dts: qcom: initial MSM8920 and Motorola Moto E4 (perry)
In reply to Aneesh PradhanQuoted 10 lines · Aneesh Pradhan
Initial upstream support for MSM8920 and the Motorola Moto E4 (perry).
Depends on the separate qcom,rpmcc-msm8920 clk series (binding + clk-smd-rpm) for the MSM8920 rpmcc compatible used by
msm8920.dtsi.This is a trimmed mainline-first subset of msm89x7-mainline/linux#48, rewritten so every phandle exists on qcom/for-next's msm8917 / pm8937 / pmi8950 (the fork DT assumed richer SoC/PMIC nodes that are not upstream yet).
Quoted 5 lines
Included: regulators, eMMC/SD, USB OTG (gpio-id extcon), keys, RMI4 touch + reset-gpios, BMA253 (i2c-gpio), WCNSS (wcn3660b), PMI8950 WLED. Deferred follow-ups: DSI panel, IPA, QDSP6 audio, FG/smbcharger, modem.
DTB build verified: msm8917-motorola-perry.dtb + msm8920-motorola-perry.dtb.
Please send all series as separate threads and all revisions as separate threads too. You can use the b4 tool [1] which takes care of that and a couple other annoyances
Konrad
Rob Herring
maintainerRe: [PATCH 0/3] arm64: dts: qcom: initial MSM8920 and Motorola Moto E4 (perry)
In reply to Aneesh PradhanQuoted 1 line · Aneesh Pradhan
Initial upstream support for MSM8920 and the Motorola Moto E4 (perry).
Please don't thread different series together. No tooling does this, so you would have to go out of your way to do it.
Rob