Skip to contentSkip to conversation

x86/mm/64: free the gap between BSS_MAIN and BSS_DECRYPTED

PATCH Superseded Hamza Mahfooz 2 participants 3 messages Jul 23 – Aug 6

Subsystems (2)

v5 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 x86/mm/64: free the gap between BSS_MAIN and BSS_DECRYPTED

This region is unused and takes up, up to 2 MiB of memory if AMD_MEM_ENCRYPT is enabled. So, free it in mem_encrypt_free_decrypted_mem().

Tested on a CoCo VM running on an AMD EPYC 7763v which generated the following print:

Freeing unused kernel image (bss_decrypted gap) memory: 184K

---
 arch/x86/include/asm/mem_encrypt.h | 3 ++-
 arch/x86/kernel/vmlinux.lds.S      | 2 ++
 arch/x86/mm/mem_encrypt_amd.c      | 6 ++++++
 3 files changed, 10 insertions(+), 1 deletion(-)
arch/x86/include/asm/mem_encrypt.h +2 -1
index ea6494628cb0..c9722be2808f 100644
@@ -112,7 +112,8 @@ void add_encrypt_protection_map(void);
 #define __sme_pa(x)		(__pa(x) | sme_me_mask)
 #define __sme_pa_nodebug(x)	(__pa_nodebug(x) | sme_me_mask)
 
-extern char __start_bss_decrypted[], __end_bss_decrypted[], __start_bss_decrypted_unused[];
+extern char __start_bss_decrypted_gap[], __start_bss_decrypted[],
+	__end_bss_decrypted[], __start_bss_decrypted_unused[];
 
 #endif	/* __ASSEMBLER__ */
 
arch/x86/kernel/vmlinux.lds.S +2 -0
index 4711a35e706c..179578a08da1 100644
@@ -88,6 +88,8 @@ const_cpu_current_top_of_stack = cpu_current_top_of_stack;
  * decrypted to avoid exposing more than we wish.
  */
 #define BSS_DECRYPTED						\
+	. = ALIGN(PAGE_SIZE);					\
+	__start_bss_decrypted_gap = .;				\
 	. = ALIGN(PMD_SIZE);					\
 	__start_bss_decrypted = .;				\
 	__pi___start_bss_decrypted = .;				\
arch/x86/mm/mem_encrypt_amd.c +6 -0
index 2f8c32173972..4111195910ab 100644
@@ -566,4 +566,10 @@ void __init mem_encrypt_free_decrypted_mem(void)
 	}
 
 	free_init_pages("unused decrypted", vaddr, vaddr_end);
+
+	vaddr = (unsigned long)__start_bss_decrypted_gap;
+	vaddr_end = (unsigned long)__start_bss_decrypted;
+
+	free_kernel_image_pages("unused kernel image (bss_decrypted gap)",
+				(void *)vaddr, (void *)vaddr_end);
 }
Signature · 1 line
2.55.0
#1 lore raw

ping?

Quoted 60 lines · Hamza Mahfooz

This region is unused and takes up, up to 2 MiB of memory if AMD_MEM_ENCRYPT is enabled. So, free it in mem_encrypt_free_decrypted_mem().

Tested on a CoCo VM running on an AMD EPYC 7763v which generated the following print:

Freeing unused kernel image (bss_decrypted gap) memory: 184K

---
 arch/x86/include/asm/mem_encrypt.h | 3 ++-
 arch/x86/kernel/vmlinux.lds.S      | 2 ++
 arch/x86/mm/mem_encrypt_amd.c      | 6 ++++++
 3 files changed, 10 insertions(+), 1 deletion(-)
arch/x86/include/asm/mem_encrypt.h +2 -1
index ea6494628cb0..c9722be2808f 100644
@@ -112,7 +112,8 @@ void add_encrypt_protection_map(void);
 #define __sme_pa(x)		(__pa(x) | sme_me_mask)
 #define __sme_pa_nodebug(x)	(__pa_nodebug(x) | sme_me_mask)
 
-extern char __start_bss_decrypted[], __end_bss_decrypted[], __start_bss_decrypted_unused[];
+extern char __start_bss_decrypted_gap[], __start_bss_decrypted[],
+	__end_bss_decrypted[], __start_bss_decrypted_unused[];
 
 #endif	/* __ASSEMBLER__ */
 
arch/x86/kernel/vmlinux.lds.S +2 -0
index 4711a35e706c..179578a08da1 100644
@@ -88,6 +88,8 @@ const_cpu_current_top_of_stack = cpu_current_top_of_stack;
  * decrypted to avoid exposing more than we wish.
  */
 #define BSS_DECRYPTED						\
+	. = ALIGN(PAGE_SIZE);					\
+	__start_bss_decrypted_gap = .;				\
 	. = ALIGN(PMD_SIZE);					\
 	__start_bss_decrypted = .;				\
 	__pi___start_bss_decrypted = .;				\
arch/x86/mm/mem_encrypt_amd.c +6 -0
index 2f8c32173972..4111195910ab 100644
@@ -566,4 +566,10 @@ void __init mem_encrypt_free_decrypted_mem(void)
 	}
 
 	free_init_pages("unused decrypted", vaddr, vaddr_end);
+
+	vaddr = (unsigned long)__start_bss_decrypted_gap;
+	vaddr_end = (unsigned long)__start_bss_decrypted;
+
+	free_kernel_image_pages("unused kernel image (bss_decrypted gap)",
+				(void *)vaddr, (void *)vaddr_end);
 }
Signature · 1 line
2.55.0