Skip to contentSkip to conversation

bus: da8xx-mstpri: remove redundant dev_err()

PATCH New Ashmit Kumar 1 participant 1 message Jul 23

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: da8xx-mstpri: remove redundant dev_err()

The devm_ioremap_resource() function already prints a detailed error message if it fails to map the resource. Thus, calling dev_err() immediately after it fails is redundant.

Remove the duplicate dev_err() call and its surrounding curly braces to conform to kernel coding style.

---
 drivers/bus/da8xx-mstpri.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/bus/da8xx-mstpri.c +1 -3
index ee4c0233513..96c117922db 100644
@@ -215,10 +215,8 @@ static int da8xx_mstpri_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	mstpri = devm_ioremap_resource(dev, res);
-	if (IS_ERR(mstpri)) {
-		dev_err(dev, "unable to map MSTPRI registers\n");
+	if (IS_ERR(mstpri))
 		return PTR_ERR(mstpri);
-	}
 
 	prio_list = da8xx_mstpri_get_board_prio();
 	if (!prio_list) {
Signature · 1 line
2.43.0