media: atomisp: Remove useless return statement
Subsystems (4)
PATCH 1/1 media: atomisp: Remove useless return statement
Fix checkpatch error
"WARNING: void function return statements are not generally useful"
Signed-off-by Tomas Chimenti <[email protected]>
---
Hello
This is my first patch, any feedback would be very welcome. Thanks
--- .../pci/runtime/inputfifo/src/inputfifo.c | 16 ---------------- 1 file changed, 16 deletions(-)
drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c +0 -16
@@ -88,7 +88,6 @@ _sh_css_fifo_snd(unsigned int token)while (!can_event_send_token (STR2MIPI_EVENT_ID ))udelay (1 );event_send_token (STR2MIPI_EVENT_ID , token); -return ; } static void inputfifo_send_data_a(
@@ -98,7 +97,6 @@ static void inputfifo_send_data_a(unsigned int token = (1 <<HIVE_STR_TO_MIPI_VALID_A_BIT ) | (data <<HIVE_STR_TO_MIPI_DATA_A_LSB );_sh_css_fifo_snd (token); -return ; } static void inputfifo_send_data_b(
@@ -108,7 +106,6 @@ static void inputfifo_send_data_b(unsigned int token = (1 <<HIVE_STR_TO_MIPI_VALID_B_BIT ) | (data << _HIVE_STR_TO_MIPI_DATA_B_LSB);_sh_css_fifo_snd (token); -return ; } static void inputfifo_send_data(
@@ -121,7 +118,6 @@ static void inputfifo_send_data( (a <<HIVE_STR_TO_MIPI_DATA_A_LSB ) | (b << _HIVE_STR_TO_MIPI_DATA_B_LSB));_sh_css_fifo_snd (token); -return ; }static void inputfifo_send_sol (void )
@@ -131,7 +127,6 @@ static void inputfifo_send_sol(void) 1 << HIVE_STR_TO_MIPI_SOL_BIT);_sh_css_fifo_snd (token); -return ; }static void inputfifo_send_eol (void )
@@ -140,7 +135,6 @@ static void inputfifo_send_eol(void)hrt_data token =inputfifo_wrap_marker (1 <<HIVE_STR_TO_MIPI_EOL_BIT );_sh_css_fifo_snd (token); -return ; }static void inputfifo_send_sof (void )
@@ -150,7 +144,6 @@ static void inputfifo_send_sof(void) 1 << HIVE_STR_TO_MIPI_SOF_BIT);_sh_css_fifo_snd (token); -return ; }static void inputfifo_send_eof (void )
@@ -159,7 +152,6 @@ static void inputfifo_send_eof(void)hrt_data token =inputfifo_wrap_marker (1 <<HIVE_STR_TO_MIPI_EOF_BIT );_sh_css_fifo_snd (token); -return ; } static void inputfifo_send_ch_id_and_fmt_type(
@@ -177,7 +169,6 @@ static void inputfifo_send_ch_id_and_fmt_type(*/ token =inputfifo_wrap_marker (0 );_sh_css_fifo_snd (token); -return ; }static void inputfifo_send_empty_token (void )
@@ -186,7 +177,6 @@ static void inputfifo_send_empty_token(void)hrt_data token =inputfifo_wrap_marker (0 );_sh_css_fifo_snd (token); -return ; } static void inputfifo_start_frame(
@@ -196,7 +186,6 @@ static void inputfifo_start_frame( {inputfifo_send_ch_id_and_fmt_type (ch_id, fmt_type);inputfifo_send_sof (); -return ; } static void inputfifo_end_frame(
@@ -207,7 +196,6 @@ static void inputfifo_end_frame(for (i =0 ; i < marker_cycles; i++)inputfifo_send_empty_token ();inputfifo_send_eof (); -return ; } static void inputfifo_send_line2(
@@ -297,7 +285,6 @@ static void inputfifo_send_line2(for (i =0 ; i < hblank_cycles; i++)inputfifo_send_empty_token ();inputfifo_send_eol (); -return ; } static void
@@ -377,7 +364,6 @@ static void inputfifo_send_frame( } }inputfifo_end_frame (marker_cycles); -return ; } static enum inputfifo_mipi_data_type inputfifo_determine_type(
@@ -453,7 +439,6 @@ void ia_css_inputfifo_start_frame( s2mi->streaming = true;inputfifo_start_frame (ch_id, s2mi->fmt_type); -return ; } void ia_css_inputfifo_send_line(
@@ -516,5 +501,4 @@ void ia_css_inputfifo_end_frame(inputfifo_end_frame (s2mi->marker_cycles); s2mi->streaming = false; -return ; }
Signature · 1 line
2.39.5
Quoted 8 lines · Tomas Chimenti
Fix checkpatch error
"WARNING: void function return statements are not generally useful"Signed-off-by Tomas Chimenti <[email protected]>---
HelloThis is my first patch, any feedback would be very welcome. Thanks
Right.
Please, read lore.kernel.org linux-media@ archives against this driver to understand what to do with this patch.
Also, if you are in a group that is mentored, tell to the mentors to stop looking into this driver by a newbie. This driver has much more urgent tasks to do and it's not trivial, it also requires a real HW to be at hand to test.
Signature · 2 lines
With Best Regards, Andy Shevchenko