platform/x86: hp-wmi: Add OMEN board 8BA9 thermal profile support
PATCH 1/1 platform/x86: hp-wmi: Add OMEN board 8BA9 thermal profile support
The HP OMEN 16-wd0xxx (board ID: 8BA9) has the same WMI interface as other Victus S boards, but requires quirks for correctly switching thermal profile.
Add the DMI board name to victus_s_thermal_profile_boards[] table and map it to omen_v1_thermal_params.
Without this entry, platform profile switching is unavailable, preventing fan RPM reporting and controlling.
Tested on:
HP OMEN 16-wd0012TX
DMI Board Name: 8BA9
It has been confirmed that the platform profile is registered successfully, and the fan RPMs are readable and controllable.
--- drivers/platform/x86/hp/hp-wmi.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/platform/x86/hp/hp-wmi.c +4 -0
@@ -201,6 +201,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst .matches = { DMI_MATCH(DMI_BOARD_NAME, "8A4D") }, .driver_data = (void *)&omen_v1_legacy_thermal_params, }, + { + .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BA9") }, + .driver_data = (void *)&omen_v1_thermal_params, + }, { .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BAB") }, .driver_data = (void *)&omen_v1_thermal_params,
Signature · 1 line
2.55.0
Ilpo Järvinen
maintainerQuoted 27 lines · Suryansh Singh
The HP OMEN 16-wd0xxx (board ID: 8BA9) has the same WMI interface as other Victus S boards, but requires quirks for correctly switching thermal profile.
Add the DMI board name to victus_s_thermal_profile_boards[] table and map it to
omen_v1_thermal_params.Without this entry, platform profile switching is unavailable, preventing fan RPM reporting and controlling.
Tested on:
HP OMEN 16-wd0012TX
DMI Board Name: 8BA9It has been confirmed that the platform profile is registered successfully, and the fan RPMs are readable and controllable.
Signed-off-by Suryansh Singh <[email protected]>--- drivers/platform/x86/hp/hp-wmi.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/platform/x86/hp/hp-wmi.c +0
-0
drivers/platform/x86/hp/hp-wmi.c static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst · line 207
Quoted 7 lines
drivers/platform/x86/hp/hp-wmi.c +4
-0@@ -201,6 +201,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst .matches = { DMI_MATCH(DMI_BOARD_NAME, "8A4D") }, .driver_data = (void *)&omen_v1_legacy_thermal_params, }, + { + .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BA9") }, + .driver_data = (void *)&omen_v1_thermal_params, + },
Hi,
This patch is based on too old code. In plaform drivers tree, hp-wmi's driver_data scope has been expanded to cover things beyond thermal params.
Signature · 1 line
i.
PATCH v2 1/1 platform/x86: hp-wmi: Add OMEN board 8BA9 thermal profile support
The HP OMEN 16-wd0xxx (board ID: 8BA9) has the same WMI interface as other Victus S boards, but requires quirks for correctly switching thermal profile.
Add the DMI board name to hp_wmi_feature_boards[] table and map it to omen_v1_board_params.
Without this entry, platform profile switching is unavailable, preventing fan RPM reporting and controlling.
Tested on:
HP OMEN 16-wd0012TX
DMI Board Name: 8BA9
It has been confirmed that the platform profile is registered successfully, and the fan RPMs are readable and controllable.
--- drivers/platform/x86/hp/hp-wmi.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/platform/x86/hp/hp-wmi.c +4 -0
@@ -246,6 +246,10 @@ static const struct dmi_system_id hp_wmi_feature_boards[] __initconst = { .matches = { DMI_MATCH(DMI_BOARD_NAME, "8A4D") }, .driver_data = (void *)&omen_v1_legacy_board_params, }, + { + .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BA9") }, + .driver_data = (void *)&omen_v1_board_params, + }, { .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BAB") }, .driver_data = (void *)&omen_v1_board_params,
Signature · 1 line
2.55.0
Ilpo Järvinen
maintainerQuoted 8 lines · Suryansh Singh
The HP OMEN 16-wd0xxx (board ID: 8BA9) has the same WMI interface as other Victus S boards, but requires quirks for correctly switching thermal profile.
Add the DMI board name to hp_wmi_feature_boards[] table and map it to
omen_v1_board_params.[...]
Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also fixes are mostly routed through for-next unless the fix is for a commit introduced in the most recent cycle or is clearly a regression fix.
The list of commits applied:
[1/1] platform/x86: hp-wmi: Add OMEN board 8BA9 thermal profile support
commit: 946000e1d594a9005e178f4166a09941ad5d454a
--
i.