net: ethernet: ax88796: initialize all fields of eeprom_93cx6 struct
Subsystems (2)
PATCH 1/1 net: ethernet: ax88796: initialize all fields of eeprom_93cx6 struct
From: Stanislaw Gruszka <[email protected]>
Commit 7738a7ab9d12 ("misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle") added extra 'quirk' field to struct eeprom_93cx6, which change how the data is read.
Some existing users of eeprom_93cx6, including ax88796 driver, allocate the structure on the stack without initialization of all the fields. As a result, the added quirk field has undefined value, what can randomly cause reading wrong data from the EEPROM.
Fix by using designated initialization.
Fixes 7738a7ab9d12 ("misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle")
Cc [email protected] # v6.13+
Signed-off-by Stanislaw Gruszka <[email protected]>
--- drivers/net/ethernet/8390/ax88796.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/net/ethernet/8390/ax88796.c +6 -6
@@ -722,12 +722,12 @@ static int ax_init_dev(struct net_device *dev)#ifdef CONFIG_AX88796_93CX6 if (ax->plat->flags &AXFLG_HAS_93CX6 ) {unsigned char mac_addr[ETH_ALEN ]; -struct eeprom_93cx6 eeprom; - - eeprom.data = ei_local; - eeprom.register_read = ax_eeprom_register_read; - eeprom.register_write = ax_eeprom_register_write; - eeprom.width =PCI_EEPROM_WIDTH_93C56 ; +struct eeprom_93cx6 eeprom = { + .data = ei_local, + .register_read = ax_eeprom_register_read, + .register_write = ax_eeprom_register_write, + .width =PCI_EEPROM_WIDTH_93C56 , + }; eeprom_93cx6_multiread(&eeprom, 0, (__le16 __force *)mac_addr,
Signature · 1 line
2.50.1