pinctrl: generic: free maps on pinctrl_generic_to_map() failure

PATCH Superseded [email protected] 2 participants 2 messages Jul 25 – Jul 29

Subsystems (2)

GPIO Pin control

lore

Share & tools

lore

[email protected]

author

2026-07-25 02:21 UTC #0 lore raw

PATCH v2 1/1 pinctrl: generic: free maps on pinctrl_generic_to_map() failure

From: Surendra Singh Chouhan <[email protected]>

pinctrl_generic_to_map() parses DT configuration and allocates pinctrl maps via pinctrl_utils_reserve_map().

If subsequent steps (such as pinctrl_utils_add_map_mux(), pinctrl_generic_add_group(), pinconf_generic_parse_dt_config(), or pinctrl_utils_add_map_configs()) return an error, *maps may contain partially allocated map entries. Returning the error directly without freeing *maps leaks the allocated mapping memory across all drivers that rely on pinctrl_generic_to_map().

Fix this by calling pinctrl_utils_free_map() and resetting *maps, *num_maps, and *num_reserved_maps in the error path of pinctrl_generic_to_map().

Fixes aaaf31be0426 ("pinctrl: extract pinctrl_generic_to_map() from pinctrl_generic_pins_function_dt_node_to_map()")

Signed-off-by Surendra Singh Chouhan <[email protected]>

---
v2:
- Move map cleanup inside pinctrl_generic_to_map() helper in pinctrl-generic.c so all callers are protected from memory leaks, as suggested by Frank Li.

 drivers/pinctrl/pinctrl-generic-mux.c |  4 +---
 drivers/pinctrl/pinctrl-generic.c     | 27 +++++++++++++++++++--------
 2 files changed, 20 insertions(+), 11 deletions(-)

drivers/pinctrl/pinctrl-generic-mux.c +1 -3

index 927c7aa616f5..da5a5ec01583 100644
@@ -58,10 +58,8 @@ mux_pinmux_dt_node_to_map(struct pinctrl_dev *pctldev,
 				     num_maps, &num_reserved_maps, group_names,
 				     0, &np_config->name, NULL, 0);
 
-	if (ret) {
-		pinctrl_utils_free_map(pctldev, *maps, *num_maps);
+	if (ret)
 		return ret;
-	}
 
 	ret = pinmux_generic_add_function(pctldev, np_config->name, group_names,
 					  1, function);

drivers/pinctrl/pinctrl-generic.c +19 -8

index 9759b0186bcc..d5f07f4a8b88 100644
@@ -42,34 +42,45 @@ int pinctrl_generic_to_map(struct pinctrl_dev *pctldev, struct device_node *pare
 	ret = pinctrl_utils_add_map_mux(pctldev, maps, num_reserved_maps, num_maps, group_name,
 					parent->name);
 	if (ret < 0)
-		return ret;
+		goto err_free_map;
 
 	ret = pinctrl_generic_add_group(pctldev, group_name, pins, npins, data);
-	if (ret < 0)
-		return dev_err_probe(dev, ret, "failed to add group %s: %d\n",
+	if (ret < 0) {
+		dev_err_probe(dev, ret, "failed to add group %s: %d\n",
 				     group_name, ret);
+		goto err_free_map;
+	}
 
 	ret = pinconf_generic_parse_dt_config(np, pctldev, &configs, &num_configs);
-	if (ret)
-		return dev_err_probe(dev, ret, "failed to parse pin config of group %s\n",
+	if (ret) {
+		dev_err_probe(dev, ret, "failed to parse pin config of group %s\n",
 			group_name);
+		goto err_free_map;
+	}
 
 	if (num_configs == 0)
 		return 0;
 
 	ret = pinctrl_utils_reserve_map(pctldev, maps, num_reserved_maps, num_maps, reserve);
 	if (ret)
-		return ret;
+		goto err_free_map;
 
 	ret = pinctrl_utils_add_map_configs(pctldev, maps, num_reserved_maps, num_maps, group_name,
 					    configs,
 			num_configs, PIN_MAP_TYPE_CONFIGS_GROUP);
 	kfree(configs);
 	if (ret)
-		return ret;
+		goto err_free_map;
 
 	return 0;
-};
+
+err_free_map:
+	pinctrl_utils_free_map(pctldev, *maps, *num_maps);
+	*maps = NULL;
+	*num_maps = 0;
+	*num_reserved_maps = 0;
+	return ret;
+}
 EXPORT_SYMBOL_GPL(pinctrl_generic_to_map);
 
 static int pinctrl_generic_pins_function_dt_subnode_to_map(struct pinctrl_dev *pctldev,

Signature · 1 line

2.55.0

Linus Walleij

maintainer

2026-07-29 07:50 UTC #1 lore raw

Quoted 12 lines · On Sat, Jul 25, 2026 at 4:22 AM <[email protected]> wrote:

From: Surendra Singh Chouhan <[email protected]>
pinctrl_generic_to_map() parses DT configuration and allocates pinctrl maps via pinctrl_utils_reserve_map().
If subsequent steps (such as pinctrl_utils_add_map_mux(), pinctrl_generic_add_group(), pinconf_generic_parse_dt_config(), or pinctrl_utils_add_map_configs()) return an error, *maps may contain partially allocated map entries. Returning the error directly without freeing *maps leaks the allocated mapping memory across all drivers that rely on pinctrl_generic_to_map().

Quoted 6 lines

Fix this by calling pinctrl_utils_free_map() and resetting *maps, *num_maps, and *num_reserved_maps in the error path of pinctrl_generic_to_map().
Fixes aaaf31be0426 ("pinctrl: extract pinctrl_generic_to_map() from pinctrl_generic_pins_function_dt_node_to_map()")
Signed-off-by Surendra Singh Chouhan <[email protected]>

This does not apply to the current "devel" branch in the pinctrl tree:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel

Please rebase (some things may be fixed already) and resend.

Yours,
Linus Walleij