Skip to contentSkip to conversation

Input: inexio: replace printk with dev_dbg and fix missing space

PATCH Applied Bivash Kumar Singh 2 participants 2 messages Jul 25 – Jul 26

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: inexio: replace printk with dev_dbg and fix missing space

Replace printk(KERN_DEBUG) with dev_dbg() using the serio device, which is the correct logging style for driver code. Also fix missing space after comma in the function argument, and remove the redundant 'inexio.c:' filename prefix from the message.

---
 drivers/input/touchscreen/inexio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/input/touchscreen/inexio.c +3 -1
index ac3836ff2a30..2fa04eaec292 100644
@@ -81,7 +81,9 @@ static irqreturn_t inexio_interrupt(struct serio *serio,
 	if (INEXIO_RESPONSE_BEGIN_BYTE&pinexio->data[0])
 		inexio_process_data(pinexio);
 	else
-		printk(KERN_DEBUG "inexio.c: unknown/unsynchronized data from device, byte %x\n",pinexio->data[0]);
+		dev_dbg(&serio->dev,
+			"unknown/unsynchronized data from device, byte %x\n",
+			pinexio->data[0]);
 
 	return IRQ_HANDLED;
 }
Signature · 1 line
2.53.0
maintainer Applied
#1 lore raw
Quoted 6 lines · Bivash Kumar Singh

Replace printk(KERN_DEBUG) with dev_dbg() using the serio device, which is the correct logging style for driver code. Also fix missing space after comma in the function argument, and remove the redundant 'inexio.c:' filename prefix from the message.

Applied, thank you.

Signature · 1 line
Dmitry