ARM: dts: BCM5301X: fix PCIe controller 2 second interrupt
Subsystems (2)
PATCH 1/1 ARM: dts: BCM5301X: fix PCIe controller 2 second interrupt
PCIe controller 2 has interrupts 0-4 mapping to GIC SPI 138-142. The mapping for interrupt 1 was incorrectly set to 138 due to a copy-paste error. Fix it to 139.
--- arch/arm/boot/dts/broadcom/bcm-ns.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/broadcom/bcm-ns.dtsi +1 -1
@@ -141,7 +141,7 @@ axi@18000000 { /* PCIe Controller 2 */ <0x00014000 0 &gic GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>, - <0x00014000 1 &gic GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>, + <0x00014000 1 &gic GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 2 &gic GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 3 &gic GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 4 &gic GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>,
Signature · 1 line
2.55.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The commit message inaccurately claims that PCIe controller 2 has interrupts 0-4 mapping to GIC…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately claims that PCIe controller 2 has interrupts 0-4 mapping to GIC SPI 138-142, omitting the mapping for interrupt 5 to GIC SPI 143. --
--- Patch [1]: [PATCH] ARM: dts: BCM5301X: fix PCIe controller 2 second interrupt --- commit 61d1b598a171b93e277ba55c095b09aad8291a33
Author: Rosen Penev <[email protected]>
ARM: dts: BCM5301X: fix PCIe controller 2 second interrupt
This commit corrects the interrupt mapping for PCIe controller 2 in the device tree. It updates interrupt 1 to map to GIC SPI 139, fixing a copy-paste error where it was previously mapped to 138.
Quoted 3 lines
PCIe controller 2 has interrupts 0-4 mapping to GIC SPI 138-142. The mapping for interrupt 1 was incorrectly set to 138 due to a copy-paste error. Fix it to 139.
[Severity: Medium]
Is this description accurate regarding the number of mapped interrupts?
Looking at arch/arm/boot/dts/broadcom/bcm-ns.dtsi, the device tree explicitly maps interrupts 0 through 5 for PCIe controller 2:
/* PCIe Controller 2 */ <0x00014000 0 &gic GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 1 &gic GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 2 &gic GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 3 &gic GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 4 &gic GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 5 &gic GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
Could the commit message be updated to mention that interrupts 0-5 map to GIC SPI 138-143?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 3 lines · On Sat, Jul 25, 2026 at 3:00 PM <[email protected]> wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately claims that PCIe controller 2 has interrupts 0-4 mapping to GIC SPI 138-142, omitting the mapping for interrupt 5 to GIC SPI 143.
Quite pedantic.
Quoted 35 lines
--
--- Patch [1]: [PATCH] ARM: dts: BCM5301X: fix PCIe controller 2 second interrupt --- commit
61d1b598a171b93e277ba55c095b09aad8291a33
Author: Rosen Penev <[email protected]>ARM: dts: BCM5301X: fix PCIe controller 2 second interrupt
This commit corrects the interrupt mapping for PCIe controller 2 in the device tree. It updates interrupt 1 to map to GIC SPI 139, fixing a copy-paste error where it was previously mapped to 138.
Quoted 3 lines
PCIe controller 2 has interrupts 0-4 mapping to GIC SPI 138-142. The mapping for interrupt 1 was incorrectly set to 138 due to a copy-paste error. Fix it to 139.
[Severity: Medium]
Is this description accurate regarding the number of mapped interrupts?Looking at
arch/arm/boot/dts/broadcom/bcm-ns.dtsi, the device tree explicitly maps interrupts 0 through 5 for PCIe controller 2:/* PCIe Controller 2 */ <0x00014000 0 &gic GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 1 &gic GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 2 &gic GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 3 &gic GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 4 &gic GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>, <0x00014000 5 &gic GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,Could the commit message be updated to mention that interrupts 0-5 map to GIC SPI 138-143?
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
From: Florian Fainelli <[email protected]>
Quoted 7 lines · Rosen Penev
PCIe controller 2 has interrupts 0-4 mapping to GIC SPI 138-142. The mapping for interrupt 1 was incorrectly set to 138 due to a copy-paste error. Fix it to 139.
Assisted-by opencode:big-pickleSigned-off-by Rosen Penev <[email protected]>---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/fixes, thanks! --
Florian