Skip to contentSkip to conversation

clarify address type in 'xb' cmd

PATCH In review Tripp R 2 participants 3 messages Jul 26 – Jul 27

lore
Share & tools
lore

Tripp R

author
#0 lore raw

PATCH 1/1 clarify address type in 'xb' cmd

---
Implemented the xb (examine block) command to print the contents of a block device to the console.

It is effectively a clone of the x/xp commands (examine memory / examine physical memory), having the same arguments for those commands, albeit preceded by the name of a block driver.

e.g. usage

	 xd floppy0 /510c 0
---
 hmp-commands.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hmp-commands.hx +1 -1
index db63b58a47..26b7cadcf2 100644
@@ -481,7 +481,7 @@ ERST
         .name       = "xb",
         .args_type  = "device:s, fmt:/,addr:l",
         .params     = "device /fmt addr",
-        .help       = "block memory dump starting at 'addr'",
+        .help       = "block memory dump starting at 'addr', in units of bytes.",
         .cmd        = hmp_block_dump,
     },
 

---
base-commit: bcc42fe49f7aae8982604900e307d783615bc79c
change-id: 20260726-xbhmpcmd-e8c82287a035

Best regards,

Signature · 1 line
Tripp R <[email protected]>
#1 lore raw

* Tripp R ([email protected]) wrote:

Hi Tripp,

Quoted 4 lines

---
Implemented the xb (examine block) command to print the contents of a block device to the console.

It is effectively a clone of the x/xp commands (examine memory / examine physical memory), having the same arguments for those commands, albeit preceded by the name of a block driver.

OK, that message is oddly formatted, and also doesn't match your subject - your subject is about clarifying it, but we don't seem to have that original command yet - have you missed the commit that implements it somewhere?

Quoted 2 lines

e.g. usage

	 xd floppy0 /510c 0

So that's 510 bytes as character starting at 0?

Dave

Quoted 27 lines
---
 hmp-commands.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hmp-commands.hx +1 -2
index db63b58a47..26b7cadcf2 100644
@@ -481,7 +481,7 @@ ERST
         .name       = "xb",
         .args_type  = "device:s, fmt:/,addr:l",
         .params     = "device /fmt addr",
-        .help       = "block memory dump starting at 'addr'",
+        .help       = "block memory dump starting at 'addr', in units of bytes.",
         .cmd        = hmp_block_dump,
     },
 
 
---

base-commit: bcc42fe49f7aae8982604900e307d783615bc79c
change-id: 20260726-xbhmpcmd-e8c82287a035

Best regards,

Signature · 1 line
Tripp R <[email protected]>
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
author
#2 lore raw
In reply to Tripp R

Hello David,

Hope things are going well. Just resubmitted the patch, which should (hopefully) be correct this time around.

On another note, I noticed a minor bug in the memory_dump (x) command, is the procedure for opening an issue much different from that of a patch?

Best,
Tripp

Quoted 42 lines · Tripp R

---
Implemented the xb (examine block) command to print the contents of a
block device to the console.

It is effectively a clone of the x/xp commands (examine memory / examine
physical memory), having the same arguments for those commands,
albeit preceded by the name of a block driver.

e.g. usage

         xd floppy0 /510c 0
---
 hmp-commands.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hmp-commands.hx +1 -2
index db63b58a47..26b7cadcf2 100644
@@ -481,7 +481,7 @@ ERST
         .name       = "xb",
         .args_type  = "device:s, fmt:/,addr:l",
         .params     = "device /fmt addr",
-        .help       = "block memory dump starting at 'addr'",
+        .help       = "block memory dump starting at 'addr', in units of
 bytes.",
         .cmd        = hmp_block_dump,
     },
 
 
---

base-commit: bcc42fe49f7aae8982604900e307d783615bc79c
change-id: 20260726-xbhmpcmd-e8c82287a035

Best regards,
--
Tripp R <[email protected]>