HID: pidff: fix OOB write when hid->inputs is empty
Subsystems (5)
PATCH 1/1 HID: pidff: fix OOB write when hid->inputs is empty
hid_pidff_init_with_quirks() derives its input_dev from
list_entry(hid->inputs.next, struct hid_input, list)
without first checking that hid->inputs is non-empty. The list member of struct hid_input is at offset 0, so on an empty list list_entry() yields &hid->inputs itself and the following hidinput->input load reads an unrelated member of struct hid_device. dev is then a type-confused pointer, and force-feedback init writes through it: each set_bit(FF_*, dev->ffbit) stores 8 bytes at dev + 192, past the end of the object dev actually aliases, and input_ff_create() adds further writes of a heap pointer and two function pointers.
Until hid-universal-pidff the only caller was hid_pidff_init() from usbhid, which runs under HID_CLAIMED_INPUT and therefore always has at least one hid_input. universal_pidff_probe() starts the device with HID_CONNECT_DEFAULT & ~HID_CONNECT_FF and then calls hid_pidff_init_with_quirks() directly whenever the descriptor carries a PID usage page, bypassing that gate. A report descriptor whose only application collection is on HID_UP_PID leaves hid->inputs empty while hid_connect() still succeeds through the hidraw claim, so probe reaches the unguarded list_entry().
The write happens in the USB probe path, on the hotplug workqueue, so plugging in a malicious device is enough to trigger it; no attacker software and no logged-in user are required. KASAN reports an 8-byte out-of-bounds write in hid_pidff_init_with_quirks() reached from universal_pidff_probe().
Check for an empty list before deriving dev and return -ENODEV, as the other HID force-feedback drivers already do. universal_pidff_probe() propagates the error and unwinds.
Discovered by XBOW, triaged by Baul Lee <[email protected]>
--- drivers/hid/usbhid/hid-pidff.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/hid/usbhid/hid-pidff.c +10 -3
@@ -1539,13 +1539,20 @@ static int pidff_check_autocenter(struct pidff_device *pidff,int hid_pidff_init_with_quirks (struct hid_device *hid,u32 initial_quirks) {struct pidff_device *pidff; -struct hid_input *hidinput = - list_entry(hid->inputs.next, struct hid_input, list); -struct input_dev *dev = hidinput->input; +struct hid_input *hidinput; +struct input_dev *dev;struct ff_device *ff;int max_effects;int error; +if (list_empty (&hid->inputs)) { +hid_err (hid,"no inputs found\n" ); +return -ENODEV ; + } + + hidinput = list_first_entry(&hid->inputs, struct hid_input, list); + dev = hidinput->input; +hid_dbg (hid,"starting pid init\n" );if (list_empty (&hid->report_enum[HID_OUTPUT_REPORT ].report_list)) {
Signature · 1 line
2.50.1 (Apple Git-155)
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Pre-existing issues:
- [High] The probe function universal_pidff_probe() fails to call hid_hw_stop() when hid_pidff_init_with_quirks() returns an error, leading to leaked HID resources and an exploitable Use-After-Free.
- [High] Race condition in hid_pidff_init_with_quirks leading to a NULL pointer dereference when a malicious userspace process calls the EVIOCSFF ioctl between input_ff_create() and callback assignment. --
--- Patch [1]: [PATCH] HID: pidff: fix OOB write when hid->inputs is empty --- commit 3acaf40e184c8c11b91d10a3096b1beb8e9b142b
Author: Baul Lee <[email protected]>
HID: pidff: fix OOB write when hid->inputs is empty
This commit fixes an out-of-bounds write in hid_pidff_init_with_quirks() by ensuring that the hid->inputs list is not empty before accessing it. If the list is empty, the function now returns -ENODEV.
Quoted 3 lines
Check for an empty list before deriving dev and return
-ENODEV, as the other HID force-feedback drivers already do.universal_pidff_probe()propagates the error and unwinds.
[Severity: High]
This isn't a bug introduced by this patch, but does universal_pidff_probe() actually fully unwind here?
Looking at universal_pidff_probe() in drivers/hid/hid-universal-pidff.c:
error = init_function(hdev, id->driver_data);
if (error) {
hid_warn(hdev, "Error initialising force feedback\n");
goto err;
}
...
err:
return error;This error path propagates the initialization error but misses the necessary hid_hw_stop() call to unwind hid_hw_start(). If universal_pidff_probe() fails during force feedback initialization, it returns an error without unwinding hid_hw_start().
This leaves the hidraw and hidinput structures registered but pointing to a soon-to-be-driverless hid_device. When the physical device is unplugged, the core skips calling hid_hw_stop() because hdev->driver is NULL.
Could this lead to an exploitable use-after-free condition if a local user plugs in an untrusted USB device to trigger this -ENODEV return, and then accesses the lingering /dev/hidrawX node?
Quoted 15 lines
drivers/hid/usbhid/hid-pidff.c +2
-3@@ -1539,13 +1539,20 @@ static int pidff_check_autocenter(struct pidff_device *pidff,int hid_pidff_init_with_quirks (struct hid_device *hid,u32 initial_quirks) {struct pidff_device *pidff; -struct hid_input *hidinput = - list_entry(hid->inputs.next, struct hid_input, list); -struct input_dev *dev = hidinput->input; +struct hid_input *hidinput; +struct input_dev *dev;struct ff_device *ff;int max_effects;
drivers/hid/usbhid/hid-pidff.c static int pidff_check_autocenter(struct pidff_device *pidff, · line 1555
Quoted 10 lines
drivers/hid/usbhid/hid-pidff.c +8
-0int error; +if (list_empty (&hid->inputs)) { +hid_err (hid,"no inputs found\n" ); +return -ENODEV ; + } + + hidinput = list_first_entry(&hid->inputs, struct hid_input, list); + dev = hidinput->input; +
[Severity: High]
This isn't a bug introduced by this patch, but is there a race condition further down in this function during force feedback initialization?
The input device is already fully registered and visible to userspace (via hidinput_connect()) before hid_pidff_init_with_quirks() is called. When input_ff_create() is invoked later in this function, it sets the EV_FF bit on the device and assigns dev->ff.
Immediately after it returns, but before ff->upload and other callbacks are initialized, a userspace process can open the input node and issue an EVIOCSFF ioctl:
error = input_ff_create(dev, max_effects); if (error) goto fail; ff = dev->ff; ff->private = pidff; ff->upload = pidff_upload_effect;
Could a local unprivileged user trigger a null pointer dereference by rapidly issuing ioctls on the newly created /dev/input/eventX node, causing input_ff_upload() to invoke a null ff->upload function pointer?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Tomasz Pakuła
maintainerQuoted 62 lines · Baul Lee
hid_pidff_init_with_quirks()derives itsinput_devfromlist_entry(hid->inputs.next, struct hid_input, list)without first checking that
hid->inputsis non-empty. The list member of structhid_inputis at offset 0, so on an empty listlist_entry()yields&hid->inputsitself and the followinghidinput->inputload reads an unrelated member of structhid_device. dev is then a type-confused pointer, and force-feedback init writes through it: eachset_bit(FF_*, dev->ffbit)stores 8 bytes at dev + 192, past the end of the object dev actually aliases, andinput_ff_create()adds further writes of a heap pointer and two function pointers.Until hid-universal-pidff the only caller was
hid_pidff_init()from usbhid, which runs underHID_CLAIMED_INPUTand therefore always has at least onehid_input.universal_pidff_probe()starts the device withHID_CONNECT_DEFAULT& ~HID_CONNECT_FF and then callshid_pidff_init_with_quirks()directly whenever the descriptor carries a PID usage page, bypassing that gate. A report descriptor whose only application collection is onHID_UP_PIDleaveshid->inputsempty whilehid_connect()still succeeds through the hidraw claim, so probe reaches the unguardedlist_entry().The write happens in the USB probe path, on the hotplug workqueue, so plugging in a malicious device is enough to trigger it; no attacker software and no logged-in user are required. KASAN reports an 8-byte out-of-bounds write in
hid_pidff_init_with_quirks()reached fromuniversal_pidff_probe().Check for an empty list before deriving dev and return
-ENODEV, as the other HID force-feedback drivers already do.universal_pidff_probe()propagates the error and unwinds.Discovered by XBOW, triaged by Baul Lee <[email protected]>
Fixes f06bf8d94fff ("HID: Add hid-universal-pidff driver and supported device ids")Reported-by Federico Kirschbaum <[email protected]>Reported-by Baul Lee <[email protected]>Signed-off-by Baul Lee <[email protected]>--- drivers/hid/usbhid/hid-pidff.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)drivers/hid/usbhid/hid-pidff.c +3
-3@@ -1539,13 +1539,20 @@ static int pidff_check_autocenter(struct pidff_device *pidff,int hid_pidff_init_with_quirks (struct hid_device *hid,u32 initial_quirks) {struct pidff_device *pidff; -struct hid_input *hidinput = - list_entry(hid->inputs.next, struct hid_input, list); -struct input_dev *dev = hidinput->input; +struct hid_input *hidinput; +struct input_dev *dev;struct ff_device *ff;int max_effects;int error; +if (list_empty (&hid->inputs)) {
drivers/hid/usbhid/hid-pidff.c static int pidff_check_autocenter(struct pidff_device *pidff, · line 1558
Quoted 10 lines
drivers/hid/usbhid/hid-pidff.c +7
-0+hid_err (hid,"no inputs found\n" ); +return -ENODEV ; + } + + hidinput = list_first_entry(&hid->inputs, struct hid_input, list); + dev = hidinput->input; +hid_dbg (hid,"starting pid init\n" );if (list_empty (&hid->report_enum[HID_OUTPUT_REPORT ].report_list)) {
Looks good, doesn't break anything and will help in such scenario. Thanks!
Signature · 1 line
Reviewed-by: Tomasz Pakuła <[email protected]>
Quoted 33 lines · Baul Lee
hid_pidff_init_with_quirks()derives itsinput_devfromlist_entry(hid->inputs.next, struct hid_input, list)without first checking that
hid->inputsis non-empty. The list member of structhid_inputis at offset 0, so on an empty listlist_entry()yields&hid->inputsitself and the followinghidinput->inputload reads an unrelated member of structhid_device. dev is then a type-confused pointer, and force-feedback init writes through it: eachset_bit(FF_*, dev->ffbit)stores 8 bytes at dev + 192, past the end of the object dev actually aliases, andinput_ff_create()adds further writes of a heap pointer and two function pointers.Until hid-universal-pidff the only caller was
hid_pidff_init()from usbhid, which runs underHID_CLAIMED_INPUTand therefore always has at least onehid_input.universal_pidff_probe()starts the device withHID_CONNECT_DEFAULT& ~HID_CONNECT_FF and then callshid_pidff_init_with_quirks()directly whenever the descriptor carries a PID usage page, bypassing that gate. A report descriptor whose only application collection is onHID_UP_PIDleaveshid->inputsempty whilehid_connect()still succeeds through the hidraw claim, so probe reaches the unguardedlist_entry().The write happens in the USB probe path, on the hotplug workqueue, so plugging in a malicious device is enough to trigger it; no attacker software and no logged-in user are required. KASAN reports an 8-byte out-of-bounds write in
hid_pidff_init_with_quirks()reached fromuniversal_pidff_probe().Check for an empty list before deriving dev and return
-ENODEV, as the other HID force-feedback drivers already do.universal_pidff_probe()propagates the error and unwinds.
Quoted 7 lines
Discovered by XBOW, triaged by Baul Lee <[email protected]>
Fixes f06bf8d94fff ("HID: Add hid-universal-pidff driver and supported device ids")Reported-by Federico Kirschbaum <[email protected]>Reported-by Baul Lee <[email protected]>Signed-off-by Baul Lee <[email protected]>
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs