ALSA: hda/realtek: Add quirk for Infinix INBOOK X3 Slim
PATCH 1/1 ALSA: hda/realtek: Add quirk for Infinix INBOOK X3 Slim
The Infinix INBOOK X3 Slim (ALC269VB, subsystem 0x2782:0250) has its internal speakers wired to pin 0x1b, but the BIOS pin configuration table declares 0x1b as "no physical connection" (0x411111f0). It instead declares pin 0x14 as the internal speaker, although nothing is connected to 0x14.
As a result the internal speakers are silent under Linux while the headphone jack works correctly. The codec output path to 0x14 is fully open (DAC assigned and streaming, mixer and pin unmuted, EAPD asserted), so the failure is silent with no error reported. The speakers work under Windows, where the vendor driver supplies its own pin table.
Add a fixup that disables the unconnected pin 0x14 and declares pin 0x1b as the internal speaker.
Reusing the existing ALC269VC_FIXUP_INFINIX_Y4_MAX was tried first, since it also remaps 0x1b to an internal speaker. It is not sufficient here: it leaves 0x14 declared, so autoconfig finds two line_outs
line_outs=2 (0x14/0x1b/0x0/0x0/0x0) type:speaker
and binds the primary "Speaker" control to the unconnected pin 0x14 while demoting the working speaker at 0x1b to "Bass Speaker". Audio is audible that way, but the volume and mute controls a desktop actually uses end up attached to a pin that is not wired to anything. Disabling 0x14 is what produces a single correct Speaker output.
Verified on the affected machine: with the corrected pin configuration the driver's autoconfig reports
line_outs=1 (0x1b/0x0/0x0/0x0/0x0) type:speaker
both channels play, headphone auto-mute switches correctly in both directions, and audio survives codec runtime suspend (D3) and resume.
--- sound/hda/codecs/realtek/alc269.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
sound/hda/codecs/realtek/alc269.c +10 -0
@@ -3939,6 +3939,7 @@ enum {ALC269_FIXUP_DMIC_THINKPAD_ACPI ,ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13 ,ALC269VC_FIXUP_INFINIX_Y4_MAX , +ALC269VB_FIXUP_INFINIX_INBOOK_X3_SLIM ,ALC269VC_FIXUP_LUNNEN_GROUND_14 ,ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO , ALC255_FIXUP_ACER_MIC_NO_PRESENCE,
@@ -4409,6 +4410,14 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id =ALC269_FIXUP_LIMIT_INT_MIC_BOOST }, + [ALC269VB_FIXUP_INFINIX_INBOOK_X3_SLIM] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl []) { + {0x14 ,0x411111f0 },/* disable, not connected */ + {0x1b ,0x90170110 },/* use as internal speaker */ + { } + }, + }, [ALC269VC_FIXUP_LUNNEN_GROUND_14] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl []) {
@@ -8020,6 +8029,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x2782 ,0x0214 ,"VAIO VJFE-CL" ,ALC269_FIXUP_LIMIT_INT_MIC_BOOST ),SND_PCI_QUIRK (0x2782 ,0x0228 ,"Infinix ZERO BOOK 13" ,ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13 ),SND_PCI_QUIRK (0x2782 ,0x0232 ,"CHUWI CoreBook XPro" ,ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO ), +SND_PCI_QUIRK (0x2782 ,0x0250 ,"Infinix INBOOK X3 Slim" ,ALC269VB_FIXUP_INFINIX_INBOOK_X3_SLIM ),SND_PCI_QUIRK (0x2782 ,0x1407 ,"Positivo P15X" ,ALC269_FIXUP_POSITIVO_P15X_HEADSET_MIC ),SND_PCI_QUIRK (0x2782 ,0x1409 ,"Positivo K116J" ,ALC269_FIXUP_POSITIVO_P15X_HEADSET_MIC ), SND_PCI_QUIRK(0x2782, 0x1701, "Infinix Y4 Max", ALC269VC_FIXUP_INFINIX_Y4_MAX),
Signature · 1 line
2.55.0
Quoted 31 lines · Gunal S
The Infinix INBOOK X3 Slim (ALC269VB, subsystem 0x2782:0250) has its internal speakers wired to pin
0x1b, but the BIOS pin configuration table declares0x1bas "no physical connection" (0x411111f0). It instead declares pin0x14as the internal speaker, although nothing is connected to0x14.As a result the internal speakers are silent under Linux while the headphone jack works correctly. The codec output path to
0x14is fully open (DAC assigned and streaming, mixer and pin unmuted, EAPD asserted), so the failure is silent with no error reported. The speakers work under Windows, where the vendor driver supplies its own pin table.Add a fixup that disables the unconnected pin
0x14and declares pin0x1bas the internal speaker.Reusing the existing
ALC269VC_FIXUP_INFINIX_Y4_MAXwas tried first, since it also remaps0x1bto an internal speaker. It is not sufficient here: it leaves0x14declared, so autoconfig finds twoline_outsline_outs=2 (0x14/0x1b/0x0/0x0/0x0) type:speaker
and binds the primary "Speaker" control to the unconnected pin
0x14while demoting the working speaker at0x1bto "Bass Speaker". Audio is audible that way, but the volume and mute controls a desktop actually uses end up attached to a pin that is not wired to anything. Disabling0x14is what produces a single correct Speaker output.Verified on the affected machine: with the corrected pin configuration the driver's autoconfig reports
Quoted 6 lines
line_outs=1 (0x1b/0x0/0x0/0x0/0x0) type:speaker
both channels play, headphone auto-mute switches correctly in both directions, and audio survives codec runtime suspend (D3) and resume.
Signed-off-by Gunal S <[email protected]>
Could you use a full name for Signed-off-by (and From) line? Signed-off-by is a legal requirement, and we prefer a full real name shown there.
thanks,
Takashi
PATCH v2 1/1 ALSA: hda/realtek: Add quirk for Infinix INBOOK X3 Slim
The Infinix INBOOK X3 Slim (ALC269VB, subsystem 0x2782:0250) has its internal speakers wired to pin 0x1b, but the BIOS pin configuration table declares 0x1b as "no physical connection" (0x411111f0). It instead declares pin 0x14 as the internal speaker, although nothing is connected to 0x14.
As a result the internal speakers are silent under Linux while the headphone jack works correctly. The codec output path to 0x14 is fully open (DAC assigned and streaming, mixer and pin unmuted, EAPD asserted), so the failure is silent with no error reported. The speakers work under Windows, where the vendor driver supplies its own pin table.
Add a fixup that disables the unconnected pin 0x14 and declares pin 0x1b as the internal speaker.
Reusing the existing ALC269VC_FIXUP_INFINIX_Y4_MAX was tried first, since it also remaps 0x1b to an internal speaker. It is not sufficient here: it leaves 0x14 declared, so autoconfig finds two line_outs
line_outs=2 (0x14/0x1b/0x0/0x0/0x0) type:speaker
and binds the primary "Speaker" control to the unconnected pin 0x14 while demoting the working speaker at 0x1b to "Bass Speaker". Audio is audible that way, but the volume and mute controls a desktop actually uses end up attached to a pin that is not wired to anything. Disabling 0x14 is what produces a single correct Speaker output.
Verified on the affected machine: with the corrected pin configuration the driver's autoconfig reports
line_outs=1 (0x1b/0x0/0x0/0x0/0x0) type:speaker
both channels play, headphone auto-mute switches correctly in both directions, and audio survives codec runtime suspend (D3) and resume.
---
v2: No functional change. Corrected the author and Signed-off-by lines to
my full name, as requested by Takashi.
sound/hda/codecs/realtek/alc269.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
sound/hda/codecs/realtek/alc269.c +10 -0
@@ -3939,6 +3939,7 @@ enum {ALC269_FIXUP_DMIC_THINKPAD_ACPI ,ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13 ,ALC269VC_FIXUP_INFINIX_Y4_MAX , +ALC269VB_FIXUP_INFINIX_INBOOK_X3_SLIM ,ALC269VC_FIXUP_LUNNEN_GROUND_14 ,ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO , ALC255_FIXUP_ACER_MIC_NO_PRESENCE,
@@ -4409,6 +4410,14 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id =ALC269_FIXUP_LIMIT_INT_MIC_BOOST }, + [ALC269VB_FIXUP_INFINIX_INBOOK_X3_SLIM] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl []) { + {0x14 ,0x411111f0 },/* disable, not connected */ + {0x1b ,0x90170110 },/* use as internal speaker */ + { } + }, + }, [ALC269VC_FIXUP_LUNNEN_GROUND_14] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl []) {
@@ -8020,6 +8029,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x2782 ,0x0214 ,"VAIO VJFE-CL" ,ALC269_FIXUP_LIMIT_INT_MIC_BOOST ),SND_PCI_QUIRK (0x2782 ,0x0228 ,"Infinix ZERO BOOK 13" ,ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13 ),SND_PCI_QUIRK (0x2782 ,0x0232 ,"CHUWI CoreBook XPro" ,ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO ), +SND_PCI_QUIRK (0x2782 ,0x0250 ,"Infinix INBOOK X3 Slim" ,ALC269VB_FIXUP_INFINIX_INBOOK_X3_SLIM ),SND_PCI_QUIRK (0x2782 ,0x1407 ,"Positivo P15X" ,ALC269_FIXUP_POSITIVO_P15X_HEADSET_MIC ),SND_PCI_QUIRK (0x2782 ,0x1409 ,"Positivo K116J" ,ALC269_FIXUP_POSITIVO_P15X_HEADSET_MIC ), SND_PCI_QUIRK(0x2782, 0x1701, "Infinix Y4 Max", ALC269VC_FIXUP_INFINIX_Y4_MAX),
Signature · 1 line
2.55.0
Quoted 33 lines · Gunal Seenivasagan
The Infinix INBOOK X3 Slim (ALC269VB, subsystem 0x2782:0250) has its internal speakers wired to pin
0x1b, but the BIOS pin configuration table declares0x1bas "no physical connection" (0x411111f0). It instead declares pin0x14as the internal speaker, although nothing is connected to0x14.As a result the internal speakers are silent under Linux while the headphone jack works correctly. The codec output path to
0x14is fully open (DAC assigned and streaming, mixer and pin unmuted, EAPD asserted), so the failure is silent with no error reported. The speakers work under Windows, where the vendor driver supplies its own pin table.Add a fixup that disables the unconnected pin
0x14and declares pin0x1bas the internal speaker.Reusing the existing
ALC269VC_FIXUP_INFINIX_Y4_MAXwas tried first, since it also remaps0x1bto an internal speaker. It is not sufficient here: it leaves0x14declared, so autoconfig finds twoline_outsline_outs=2 (0x14/0x1b/0x0/0x0/0x0) type:speaker
and binds the primary "Speaker" control to the unconnected pin
0x14while demoting the working speaker at0x1bto "Bass Speaker". Audio is audible that way, but the volume and mute controls a desktop actually uses end up attached to a pin that is not wired to anything. Disabling0x14is what produces a single correct Speaker output.Verified on the affected machine: with the corrected pin configuration the driver's autoconfig reports
line_outs=1 (0x1b/0x0/0x0/0x0/0x0) type:speaker
Quoted 7 lines
both channels play, headphone auto-mute switches correctly in both directions, and audio survives codec runtime suspend (D3) and resume.
Signed-off-by Gunal Seenivasagan <[email protected]>---
v2: No functional change. Corrected the author and Signed-off-by lines to
my full name, as requested by Takashi.
Applied now. Thanks.
Takashi