Skip to contentSkip to conversation

staging: rtl8723bs: apply clang-format cleanup

PATCH In review Aryan Krishnan 2 participants 3 messages Jul 27 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: apply clang-format cleanup

From: Aryan <[email protected]>

This patch formats the drivers/staging/rtl8723bs directory using clang-format, hence reducing the number of errors by 2, warnings by 66, and CHECKs by 4,685.

This is a purely mechanical, whitespace/formatting-only change with no functional impact.

---
Hey everyone, this is my first Linux Kernel patch, and I specifically wanted to focus on the rtl8723bs driver. When seeing some of the CHECKs and specifically points regarding formatting, I thought about running clang-format to see if that would help. In this case it reduced the CHECKs by over 50%.

For now this is all in one big patch, do let me know if you'd like me to split this by directory or file instead. I felt this was decently mechanical overall however and decided to keep it as one patch.

I am 16 and looking to improve and be active in the community. I have some experience with chromium and PDFium although I am aware that this will not fully carry over. Do let me know if there are any general style conventions I missed as well as any other additional tips to improve in the repo.

Thanks!
- Aryan

 drivers/staging/rtl8723bs/core/rtw_ap.c       |  433 +--
 drivers/staging/rtl8723bs/core/rtw_btcoex.c   |    3 +-
 drivers/staging/rtl8723bs/core/rtw_cmd.c      |  754 +++---
 drivers/staging/rtl8723bs/core/rtw_efuse.c    |   58 +-
 .../staging/rtl8723bs/core/rtw_ieee80211.c    |  198 +-
 drivers/staging/rtl8723bs/core/rtw_io.c       |    3 +-
 .../staging/rtl8723bs/core/rtw_ioctl_set.c    |  120 +-
 drivers/staging/rtl8723bs/core/rtw_mlme.c     |  930 ++++---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2338 ++++++++++-------
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c  |  127 +-
 drivers/staging/rtl8723bs/core/rtw_recv.c     |  551 ++--
 drivers/staging/rtl8723bs/core/rtw_security.c |  824 +++---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c  |  103 +-
 .../staging/rtl8723bs/core/rtw_wlan_util.c    |  409 +--
 drivers/staging/rtl8723bs/core/rtw_xmit.c     |  573 ++--
 drivers/staging/rtl8723bs/hal/Hal8723BReg.h   |   28 +-
 .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c   | 1585 ++++++-----
 .../staging/rtl8723bs/hal/HalBtc8723b1Ant.h   |   94 +-
 .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c   | 1694 ++++++------
 .../staging/rtl8723bs/hal/HalBtc8723b2Ant.h   |   74 +-
 drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h  |  248 +-
 .../staging/rtl8723bs/hal/HalHWImg8723B_BB.c  |  508 ++--
 .../staging/rtl8723bs/hal/HalHWImg8723B_BB.h  |   18 +-
 .../staging/rtl8723bs/hal/HalHWImg8723B_MAC.c |  195 +-
 .../staging/rtl8723bs/hal/HalHWImg8723B_MAC.h |    6 +-
 .../staging/rtl8723bs/hal/HalHWImg8723B_RF.c  |  632 ++---
 .../staging/rtl8723bs/hal/HalHWImg8723B_RF.h  |   18 +-
 drivers/staging/rtl8723bs/hal/HalPhyRf.c      |  161 +-
 drivers/staging/rtl8723bs/hal/HalPhyRf.h      |   15 +-
 .../staging/rtl8723bs/hal/HalPhyRf_8723B.c    | 1382 ++++++----
 .../staging/rtl8723bs/hal/HalPhyRf_8723B.h    |   49 +-
 drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c  |   70 +-
 drivers/staging/rtl8723bs/hal/Mp_Precomp.h    |    2 +-
 drivers/staging/rtl8723bs/hal/hal_btcoex.c    |  130 +-
 drivers/staging/rtl8723bs/hal/hal_com.c       |  253 +-
 .../staging/rtl8723bs/hal/hal_com_phycfg.c    |  404 +--
 drivers/staging/rtl8723bs/hal/hal_intf.c      |   50 +-
 drivers/staging/rtl8723bs/hal/hal_pwr_seq.c   |  121 +-
 drivers/staging/rtl8723bs/hal/hal_sdio.c      |   32 +-
 drivers/staging/rtl8723bs/hal/odm.c           |  302 ++-
 drivers/staging/rtl8723bs/hal/odm.h           |  551 ++--
 .../staging/rtl8723bs/hal/odm_CfoTracking.c   |   59 +-
 .../staging/rtl8723bs/hal/odm_CfoTracking.h   |   13 +-
 drivers/staging/rtl8723bs/hal/odm_DIG.c       |  328 +--
 drivers/staging/rtl8723bs/hal/odm_DIG.h       |   75 +-
 .../rtl8723bs/hal/odm_DynamicBBPowerSaving.c  |   54 +-
 .../rtl8723bs/hal/odm_DynamicBBPowerSaving.h  |    5 +-
 .../rtl8723bs/hal/odm_DynamicTxPower.h        |   32 +-
 .../rtl8723bs/hal/odm_EdcaTurboCheck.c        |   39 +-
 drivers/staging/rtl8723bs/hal/odm_HWConfig.c  |  207 +-
 drivers/staging/rtl8723bs/hal/odm_HWConfig.h  |   71 +-
 .../rtl8723bs/hal/odm_RegConfig8723B.c        |  121 +-
 .../rtl8723bs/hal/odm_RegConfig8723B.h        |   43 +-
 .../staging/rtl8723bs/hal/odm_RegDefine11N.h  |  270 +-
 drivers/staging/rtl8723bs/hal/odm_interface.h |   20 +-
 drivers/staging/rtl8723bs/hal/odm_precomp.h   |   18 +-
 drivers/staging/rtl8723bs/hal/odm_reg.h       |  122 +-
 drivers/staging/rtl8723bs/hal/odm_types.h     |   44 +-
 drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c  |  405 +--
 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c   |   94 +-
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 1445 +++++-----
 .../staging/rtl8723bs/hal/rtl8723b_phycfg.c   |  334 +--
 .../staging/rtl8723bs/hal/rtl8723b_rf6052.c   |   53 +-
 .../staging/rtl8723bs/hal/rtl8723b_rxdesc.c   |   15 +-
 .../staging/rtl8723bs/hal/rtl8723bs_recv.c    |  131 +-
 .../staging/rtl8723bs/hal/rtl8723bs_xmit.c    |  175 +-
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  256 +-
 drivers/staging/rtl8723bs/hal/sdio_ops.c      |  138 +-
 .../rtl8723bs/include/Hal8192CPhyReg.h        |  234 +-
 .../staging/rtl8723bs/include/HalPwrSeqCmd.h  |  117 +-
 .../staging/rtl8723bs/include/basic_types.h   |  155 +-
 drivers/staging/rtl8723bs/include/cmd_osdep.h |    8 +-
 drivers/staging/rtl8723bs/include/drv_types.h |  183 +-
 .../rtl8723bs/include/drv_types_sdio.h        |   12 +-
 .../staging/rtl8723bs/include/hal_btcoex.h    |    2 +-
 drivers/staging/rtl8723bs/include/hal_com.h   |  148 +-
 .../staging/rtl8723bs/include/hal_com_h2c.h   |   12 +-
 .../rtl8723bs/include/hal_com_phycfg.h        |   50 +-
 .../staging/rtl8723bs/include/hal_com_reg.h   |  684 +++--
 drivers/staging/rtl8723bs/include/hal_data.h  |  214 +-
 drivers/staging/rtl8723bs/include/hal_intf.h  |  119 +-
 drivers/staging/rtl8723bs/include/hal_pg.h    |   51 +-
 drivers/staging/rtl8723bs/include/hal_phy.h   |   53 +-
 .../staging/rtl8723bs/include/hal_phy_cfg.h   |   37 +-
 .../staging/rtl8723bs/include/hal_phy_reg.h   |    2 +-
 .../staging/rtl8723bs/include/hal_pwr_seq.h   | 1023 ++++++--
 drivers/staging/rtl8723bs/include/hal_sdio.h  |   11 +-
 drivers/staging/rtl8723bs/include/ieee80211.h |  515 ++--
 .../rtl8723bs/include/ioctl_cfg80211.h        |   37 +-
 .../staging/rtl8723bs/include/osdep_intf.h    |    2 +-
 .../staging/rtl8723bs/include/osdep_service.h |    9 +-
 .../rtl8723bs/include/osdep_service_linux.h   |   18 +-
 .../staging/rtl8723bs/include/rtl8192c_recv.h |    8 +-
 .../staging/rtl8723bs/include/rtl8723b_cmd.h  |  191 +-
 .../staging/rtl8723bs/include/rtl8723b_hal.h  |   66 +-
 .../staging/rtl8723bs/include/rtl8723b_recv.h |  117 +-
 .../staging/rtl8723bs/include/rtl8723b_rf.h   |    8 +-
 .../staging/rtl8723bs/include/rtl8723b_spec.h |  219 +-
 .../staging/rtl8723bs/include/rtl8723b_xmit.h |  728 ++---
 drivers/staging/rtl8723bs/include/rtw_ap.h    |   11 +-
 .../staging/rtl8723bs/include/rtw_btcoex.h    |   11 +-
 .../staging/rtl8723bs/include/rtw_byteorder.h |    2 +-
 drivers/staging/rtl8723bs/include/rtw_cmd.h   |  295 ++-
 .../staging/rtl8723bs/include/rtw_eeprom.h    |   63 +-
 drivers/staging/rtl8723bs/include/rtw_efuse.h |   41 +-
 drivers/staging/rtl8723bs/include/rtw_event.h |   34 +-
 drivers/staging/rtl8723bs/include/rtw_ht.h    |   45 +-
 drivers/staging/rtl8723bs/include/rtw_io.h    |   29 +-
 .../staging/rtl8723bs/include/rtw_ioctl_set.h |   17 +-
 drivers/staging/rtl8723bs/include/rtw_mlme.h  |  203 +-
 .../staging/rtl8723bs/include/rtw_mlme_ext.h  |  407 +--
 .../staging/rtl8723bs/include/rtw_pwrctrl.h   |  143 +-
 drivers/staging/rtl8723bs/include/rtw_qos.h   |   11 +-
 drivers/staging/rtl8723bs/include/rtw_recv.h  |  196 +-
 drivers/staging/rtl8723bs/include/rtw_rf.h    |   87 +-
 .../staging/rtl8723bs/include/rtw_security.h  |  302 +--
 .../staging/rtl8723bs/include/rtw_version.h   |    4 +-
 drivers/staging/rtl8723bs/include/rtw_xmit.h  |  327 +--
 drivers/staging/rtl8723bs/include/sdio_ops.h  |    7 +-
 .../rtl8723bs/include/sdio_ops_linux.h        |    6 +-
 drivers/staging/rtl8723bs/include/sta_info.h  |  184 +-
 drivers/staging/rtl8723bs/include/wifi.h      |  430 ++-
 .../staging/rtl8723bs/include/wlan_bssdef.h   |  149 +-
 .../staging/rtl8723bs/include/xmit_osdep.h    |   14 +-
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c |  993 ++++---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c   |  145 +-
 .../staging/rtl8723bs/os_dep/osdep_service.c  |    9 +-
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c  |   67 +-
 .../staging/rtl8723bs/os_dep/sdio_ops_linux.c |   11 +-
 drivers/staging/rtl8723bs/os_dep/wifi_regd.c  |   34 +-
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c |   30 +-
 131 files changed, 16439 insertions(+), 13514 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +218 -215
index 065850a9e8947..cc7167862033d 100644
@@ -60,11 +60,8 @@ static void update_BCNTIM(struct adapter *padapter)
 
 	tim_bitmap_le = cpu_to_le16(pstapriv->tim_bitmap);
 
-	p = rtw_get_ie(pie + _FIXED_IE_LENGTH_,
-		       WLAN_EID_TIM,
-		       &tim_ielen,
-		       pnetwork_mlmeext->ie_length - _FIXED_IE_LENGTH_
-	);
+	p = rtw_get_ie(pie + _FIXED_IE_LENGTH_, WLAN_EID_TIM, &tim_ielen,
+		       pnetwork_mlmeext->ie_length - _FIXED_IE_LENGTH_);
 	if (p && tim_ielen > 0) {
 		tim_ielen += 2;
 
@@ -72,7 +69,8 @@ static void update_BCNTIM(struct adapter *padapter)
 
 		tim_ie_offset = (signed int)(p - pie);
 
-		remainder_ielen = pnetwork_mlmeext->ie_length - tim_ie_offset - tim_ielen;
+		remainder_ielen =
+			pnetwork_mlmeext->ie_length - tim_ie_offset - tim_ielen;
 
 		/* append TIM IE from dst_ie offset */
 		dst_ie = p;
@@ -83,19 +81,16 @@ static void update_BCNTIM(struct adapter *padapter)
 		offset = _FIXED_IE_LENGTH_;
 
 		/* get ssid_ie len */
-		p = rtw_get_ie(pie + _BEACON_IE_OFFSET_,
-			       WLAN_EID_SSID,
-			       &tmp_len,
-			       (pnetwork_mlmeext->ie_length - _BEACON_IE_OFFSET_)
-		);
+		p = rtw_get_ie(
+			pie + _BEACON_IE_OFFSET_, WLAN_EID_SSID, &tmp_len,
+			(pnetwork_mlmeext->ie_length - _BEACON_IE_OFFSET_));
 		if (p)
 			offset += tmp_len + 2;
 
 		/*  get supported rates len */
-		p = rtw_get_ie(pie + _BEACON_IE_OFFSET_,
-			       WLAN_EID_SUPP_RATES, &tmp_len,
-			       (pnetwork_mlmeext->ie_length - _BEACON_IE_OFFSET_)
-		);
+		p = rtw_get_ie(
+			pie + _BEACON_IE_OFFSET_, WLAN_EID_SUPP_RATES, &tmp_len,
+			(pnetwork_mlmeext->ie_length - _BEACON_IE_OFFSET_));
 		if (p)
 			offset += tmp_len + 2;
 
@@ -104,14 +99,16 @@ static void update_BCNTIM(struct adapter *padapter)
 
 		premainder_ie = pie + offset;
 
-		remainder_ielen = pnetwork_mlmeext->ie_length - offset - tim_ielen;
+		remainder_ielen =
+			pnetwork_mlmeext->ie_length - offset - tim_ielen;
 
 		/* append TIM IE from offset */
 		dst_ie = pie + offset;
 	}
 
 	if (premainder_ie && remainder_ielen)
-		pbackup_remainder_ie = kmemdup(premainder_ie, remainder_ielen, GFP_ATOMIC);
+		pbackup_remainder_ie =
+			kmemdup(premainder_ie, remainder_ielen, GFP_ATOMIC);
 
 	*dst_ie++ = WLAN_EID_TIM;
 
@@ -122,11 +119,11 @@ static void update_BCNTIM(struct adapter *padapter)
 
 	*dst_ie++ = tim_ielen;
 
-	*dst_ie++ = 0;/* DTIM count */
-	*dst_ie++ = 1;/* DTIM period */
+	*dst_ie++ = 0; /* DTIM count */
+	*dst_ie++ = 1; /* DTIM period */
 
-	if (pstapriv->tim_bitmap & BIT(0))/* for bc/mc frames */
-		*dst_ie++ = BIT(0);/* bitmap ctrl */
+	if (pstapriv->tim_bitmap & BIT(0)) /* for bc/mc frames */
+		*dst_ie++ = BIT(0); /* bitmap ctrl */
 	else
 		*dst_ie++ = 0;
 
@@ -152,7 +149,7 @@ static void update_BCNTIM(struct adapter *padapter)
 		kfree(pbackup_remainder_ie);
 	}
 
-	offset =  (unsigned int)(dst_ie - pie);
+	offset = (unsigned int)(dst_ie - pie);
 	pnetwork_mlmeext->ie_length = offset + remainder_ielen;
 }
 
@@ -232,7 +229,8 @@ void expire_timeout_chk(struct adapter *padapter)
 
 					/* to update bcn with tim_bitmap for this station */
 					pstapriv->tim_bitmap |= BIT(psta->aid);
-					update_beacon(padapter, WLAN_EID_TIM, NULL, true);
+					update_beacon(padapter, WLAN_EID_TIM,
+						      NULL, true);
 
 					if (!pmlmeext->active_keep_alive_check)
 						continue;
@@ -241,21 +239,26 @@ void expire_timeout_chk(struct adapter *padapter)
 			if (pmlmeext->active_keep_alive_check) {
 				int stainfo_offset;
 
-				stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
+				stainfo_offset =
+					rtw_stainfo_offset(pstapriv, psta);
 				if (stainfo_offset_valid(stainfo_offset))
-					chk_alive_list[chk_alive_num++] = stainfo_offset;
+					chk_alive_list[chk_alive_num++] =
+						stainfo_offset;
 
 				continue;
 			}
 			list_del_init(&psta->asoc_list);
 			pstapriv->asoc_list_cnt--;
-			updated = ap_free_sta(padapter, psta, false, WLAN_REASON_DEAUTH_LEAVING);
+			updated = ap_free_sta(padapter, psta, false,
+					      WLAN_REASON_DEAUTH_LEAVING);
 		} else {
 			/* TODO: Aging mechanism to digest frames in sleep_q to */
 			/* avoid running out of xmitframe */
-			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
+			if (psta->sleepq_len >
+				    (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
 			    padapter->xmitpriv.free_xmitframe_cnt <
-					((NR_XMITFRAME / pstapriv->asoc_list_cnt) / 2))
+				    ((NR_XMITFRAME / pstapriv->asoc_list_cnt) /
+				     2))
 				wakeup_sta_to_xmit(padapter, psta);
 		}
 	}
@@ -276,14 +279,17 @@ void expire_timeout_chk(struct adapter *padapter)
 		for (i = 0; i < chk_alive_num; i++) {
 			int ret = _FAIL;
 
-			psta = rtw_get_stainfo_by_offset(pstapriv, chk_alive_list[i]);
+			psta = rtw_get_stainfo_by_offset(pstapriv,
+							 chk_alive_list[i]);
 			if (!(psta->state & _FW_LINKED))
 				continue;
 
 			if (psta->state & WIFI_SLEEP_STATE)
-				ret = issue_nulldata(padapter, psta->hwaddr, 0, 1, 50);
+				ret = issue_nulldata(padapter, psta->hwaddr, 0,
+						     1, 50);
 			else
-				ret = issue_nulldata(padapter, psta->hwaddr, 0, 3, 50);
+				ret = issue_nulldata(padapter, psta->hwaddr, 0,
+						     3, 50);
 
 			psta->keep_alive_trycnt++;
 			if (ret == _SUCCESS) {
@@ -300,13 +306,15 @@ void expire_timeout_chk(struct adapter *padapter)
 			if (!list_empty(&psta->asoc_list)) {
 				list_del_init(&psta->asoc_list);
 				pstapriv->asoc_list_cnt--;
-				updated = ap_free_sta(padapter, psta, false,
-						      WLAN_REASON_DEAUTH_LEAVING);
+				updated =
+					ap_free_sta(padapter, psta, false,
+						    WLAN_REASON_DEAUTH_LEAVING);
 			}
 			spin_unlock_bh(&pstapriv->asoc_list_lock);
 		}
 
-		if (backup_oper_channel > 0) /* back to the original operation channel */
+		if (backup_oper_channel >
+		    0) /* back to the original operation channel */
 			r8723bs_select_channel(padapter, backup_oper_channel);
 	}
 
@@ -318,8 +326,8 @@ void add_ratid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
 	unsigned char sta_band = 0, short_gi_rate = false;
 	unsigned int tx_ra_bitmap = 0;
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
-	struct wlan_bssid_ex
-		*pcur_network = (struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
+	struct wlan_bssid_ex *pcur_network =
+		(struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
 
 	if (!psta)
 		return;
@@ -349,7 +357,7 @@ void add_ratid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
 	psta->raid = networktype_to_raid_ex(padapter, psta);
 
 	if (psta->aid < NUM_STA) {
-		u8 arg[4] = {0};
+		u8 arg[4] = { 0 };
 
 		arg[0] = psta->mac_id;
 		arg[1] = psta->raid;
@@ -367,13 +375,13 @@ void update_bmc_sta(struct adapter *padapter)
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 	struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
-	struct wlan_bssid_ex
-		*pcur_network = (struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
+	struct wlan_bssid_ex *pcur_network =
+		(struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
 	struct sta_info *psta = rtw_get_bcmc_stainfo(padapter);
 
 	if (psta) {
-		psta->aid = 0;/* default set to 0 */
-		psta->mac_id = psta->aid + 1;/* mac_id = 1 for bc/mc stainfo */
+		psta->aid = 0; /* default set to 0 */
+		psta->mac_id = psta->aid + 1; /* mac_id = 1 for bc/mc stainfo */
 
 		pmlmeinfo->FW_sta_info[psta->mac_id].psta = psta;
 
@@ -385,12 +393,13 @@ void update_bmc_sta(struct adapter *padapter)
 		memset(&psta->sta_stats, 0, sizeof(struct stainfo_stats));
 
 		/* prepare for add_ratid */
-		network_type = rtw_check_network_type((u8 *)&pcur_network->supported_rates,
-						      pcur_network->configuration.ds_config
-		);
+		network_type = rtw_check_network_type(
+			(u8 *)&pcur_network->supported_rates,
+			pcur_network->configuration.ds_config);
 		if (is_supported_tx_cck(network_type)) {
 			network_type = WIRELESS_11B;
-		} else if (network_type == WIRELESS_INVALID) { /*  error handling */
+		} else if (network_type ==
+			   WIRELESS_INVALID) { /*  error handling */
 
 			if (pcur_network->configuration.ds_config > 14)
 				network_type = WIRELESS_INVALID;
@@ -410,7 +419,7 @@ void update_bmc_sta(struct adapter *padapter)
 
 		/* if (pHalData->fw_ractrl == true) */
 		{
-			u8 arg[4] = {0};
+			u8 arg[4] = { 0 };
 
 			arg[0] = psta->mac_id;
 			arg[1] = psta->raid;
@@ -464,7 +473,8 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
 
 		phtpriv_sta->rx_ampdu_min_spacing =
 			(phtpriv_sta->ht_cap.ampdu_params_info &
-			 IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2;
+			 IEEE80211_HT_CAP_AMPDU_DENSITY) >>
+			2;
 
 		/*  bwmode */
 		if ((phtpriv_sta->ht_cap.cap_info &
@@ -489,7 +499,8 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
 		if ((phtpriv_sta->ht_cap.cap_info &
 		     phtpriv_ap->ht_cap.cap_info) &
 		    cpu_to_le16(IEEE80211_HT_CAP_SGI_40)) {
-			if (psta->bw_mode == CHANNEL_WIDTH_40) /* according to psta->bw_mode */
+			if (psta->bw_mode ==
+			    CHANNEL_WIDTH_40) /* according to psta->bw_mode */
 				phtpriv_sta->sgi_40m = true;
 			else
 				phtpriv_sta->sgi_40m = false;
@@ -499,13 +510,16 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
 
 		/*  B0 Config LDPC Coding Capability */
 		if (TEST_FLAG(phtpriv_ap->ldpc_cap, LDPC_HT_ENABLE_TX) &&
-		    GET_HT_CAPABILITY_ELE_LDPC_CAP((u8 *)(&phtpriv_sta->ht_cap)))
-			SET_FLAG(cur_ldpc_cap, (LDPC_HT_ENABLE_TX | LDPC_HT_CAP_TX));
+		    GET_HT_CAPABILITY_ELE_LDPC_CAP(
+			    (u8 *)(&phtpriv_sta->ht_cap)))
+			SET_FLAG(cur_ldpc_cap,
+				 (LDPC_HT_ENABLE_TX | LDPC_HT_CAP_TX));
 
 		/*  B7 B8 B9 Config STBC setting */
 		if (TEST_FLAG(phtpriv_ap->stbc_cap, STBC_HT_ENABLE_TX) &&
 		    GET_HT_CAPABILITY_ELE_RX_STBC((u8 *)(&phtpriv_sta->ht_cap)))
-			SET_FLAG(cur_stbc_cap, (STBC_HT_ENABLE_TX | STBC_HT_CAP_TX));
+			SET_FLAG(cur_stbc_cap,
+				 (STBC_HT_ENABLE_TX | STBC_HT_CAP_TX));
 	} else {
 		phtpriv_sta->ampdu_enable = false;
 
@@ -520,12 +534,12 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
 	phtpriv_sta->beamform_cap = cur_beamform_cap;
 
 	/* Rx AMPDU */
-	send_delba(padapter, 0, psta->hwaddr);/*  recipient */
+	send_delba(padapter, 0, psta->hwaddr); /*  recipient */
 
 	/* TX AMPDU */
-	send_delba(padapter, 1, psta->hwaddr);/* originator */
-	phtpriv_sta->agg_enable_bitmap = 0x0;/* reset */
-	phtpriv_sta->candidate_tid_bitmap = 0x0;/* reset */
+	send_delba(padapter, 1, psta->hwaddr); /* originator */
+	phtpriv_sta->agg_enable_bitmap = 0x0; /* reset */
+	phtpriv_sta->candidate_tid_bitmap = 0x0; /* reset */
 
 	update_ldpc_stbc_cap(psta);
 
@@ -541,8 +555,8 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
 static void update_ap_info(struct adapter *padapter, struct sta_info *psta)
 {
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
-	struct wlan_bssid_ex
-		*pnetwork = (struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
+	struct wlan_bssid_ex *pnetwork =
+		(struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 	struct ht_priv *phtpriv_ap = &pmlmepriv->htpriv;
 
@@ -554,11 +568,13 @@ static void update_ap_info(struct adapter *padapter, struct sta_info *psta)
 	/* HT related cap */
 	if (phtpriv_ap->ht_option) {
 		/* check if sta support s Short GI 20M */
-		if ((phtpriv_ap->ht_cap.cap_info) & cpu_to_le16(IEEE80211_HT_CAP_SGI_20))
+		if ((phtpriv_ap->ht_cap.cap_info) &
+		    cpu_to_le16(IEEE80211_HT_CAP_SGI_20))
 			phtpriv_ap->sgi_20m = true;
 
 		/* check if sta support s Short GI 40M */
-		if ((phtpriv_ap->ht_cap.cap_info) & cpu_to_le16(IEEE80211_HT_CAP_SGI_40))
+		if ((phtpriv_ap->ht_cap.cap_info) &
+		    cpu_to_le16(IEEE80211_HT_CAP_SGI_40))
 			phtpriv_ap->sgi_40m = true;
 
 		psta->qos_option = true;
@@ -572,8 +588,8 @@ static void update_ap_info(struct adapter *padapter, struct sta_info *psta)
 	psta->bw_mode = pmlmeext->cur_bwmode;
 	phtpriv_ap->ch_offset = pmlmeext->cur_ch_offset;
 
-	phtpriv_ap->agg_enable_bitmap = 0x0;/* reset */
-	phtpriv_ap->candidate_tid_bitmap = 0x0;/* reset */
+	phtpriv_ap->agg_enable_bitmap = 0x0; /* reset */
+	phtpriv_ap->candidate_tid_bitmap = 0x0; /* reset */
 
 	memcpy(&psta->htpriv, &pmlmepriv->htpriv, sizeof(struct ht_priv));
 }
@@ -592,18 +608,22 @@ static void update_hw_ht_param(struct adapter *padapter)
 	 */
 	max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03;
 
-	min_MPDU_spacing = (pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x1c) >> 2;
+	min_MPDU_spacing =
+		(pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x1c) >> 2;
 
-	rtw_hal_set_hwreg(padapter, HW_VAR_AMPDU_MIN_SPACE, (u8 *)(&min_MPDU_spacing));
+	rtw_hal_set_hwreg(padapter, HW_VAR_AMPDU_MIN_SPACE,
+			  (u8 *)(&min_MPDU_spacing));
 
-	rtw_hal_set_hwreg(padapter, HW_VAR_AMPDU_FACTOR, (u8 *)(&max_AMPDU_len));
+	rtw_hal_set_hwreg(padapter, HW_VAR_AMPDU_FACTOR,
+			  (u8 *)(&max_AMPDU_len));
 
 	/*  */
 	/*  Config SM Power Save setting */
 	/*  */
 	pmlmeinfo->SM_PS =
 		(le16_to_cpu(pmlmeinfo->HT_caps.u.HT_cap_element.HT_caps_info) &
-		 0x0C) >> 2;
+		 0x0C) >>
+		2;
 }
 
 void start_bss_network(struct adapter *padapter)
@@ -612,12 +632,12 @@ void start_bss_network(struct adapter *padapter)
 	u8 val8, cur_channel, cur_bwmode, cur_ch_offset;
 	u16 bcn_interval;
 	u32 acparm;
-	int	ie_len;
-	struct registry_priv  *pregpriv = &padapter->registrypriv;
+	int ie_len;
+	struct registry_priv *pregpriv = &padapter->registrypriv;
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 	struct security_priv *psecuritypriv = &padapter->securitypriv;
-	struct wlan_bssid_ex
-		*pnetwork = (struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
+	struct wlan_bssid_ex *pnetwork =
+		(struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 	struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
 	struct wlan_bssid_ex *pnetwork_mlmeext = &pmlmeinfo->network;
@@ -636,7 +656,8 @@ void start_bss_network(struct adapter *padapter)
 	 * and at first time the security ie (RSN/WPA IE) will not include in beacon.
 	 */
 	if (!rtw_get_wps_ie(pnetwork->ies + _FIXED_IE_LENGTH_,
-			    pnetwork->ie_length - _FIXED_IE_LENGTH_, NULL, NULL))
+			    pnetwork->ie_length - _FIXED_IE_LENGTH_, NULL,
+			    NULL))
 		pmlmeext->bstart_bss = true;
 
 	/* todo: update wmm, ht cap */
@@ -653,7 +674,7 @@ void start_bss_network(struct adapter *padapter)
 		/* WEP Key will be set before this function, do not clear CAM. */
 		if ((psecuritypriv->dot11PrivacyAlgrthm != _WEP40_) &&
 		    (psecuritypriv->dot11PrivacyAlgrthm != _WEP104_))
-			flush_all_cam_entry(padapter);	/* clear CAM */
+			flush_all_cam_entry(padapter); /* clear CAM */
 	}
 
 	/* set MSR to AP_Mode */
@@ -673,12 +694,14 @@ void start_bss_network(struct adapter *padapter)
 	rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_BK, (u8 *)(&acparm));
 
 	/* Set Security */
-	val8 = (psecuritypriv->dot11AuthAlgrthm ==
-		dot11AuthAlgrthm_8021X) ? 0xcc : 0xcf;
+	val8 = (psecuritypriv->dot11AuthAlgrthm == dot11AuthAlgrthm_8021X) ?
+		       0xcc :
+		       0xcf;
 	rtw_hal_set_hwreg(padapter, HW_VAR_SEC_CFG, (u8 *)(&val8));
 
 	/* Beacon Control related register */
-	rtw_hal_set_hwreg(padapter, HW_VAR_BEACON_INTERVAL, (u8 *)(&bcn_interval));
+	rtw_hal_set_hwreg(padapter, HW_VAR_BEACON_INTERVAL,
+			  (u8 *)(&bcn_interval));
 
 	rtw_hal_set_hwreg(padapter, HW_VAR_DO_IQK, NULL);
 
@@ -688,18 +711,17 @@ void start_bss_network(struct adapter *padapter)
 	}
 
 	/* set channel, bwmode */
-	p = rtw_get_ie((pnetwork->ies + sizeof(struct ndis_802_11_fix_ie)),
-		       WLAN_EID_HT_OPERATION,
-		       &ie_len,
-		       (pnetwork->ie_length - sizeof(struct ndis_802_11_fix_ie))
-	);
+	p = rtw_get_ie(
+		(pnetwork->ies + sizeof(struct ndis_802_11_fix_ie)),
+		WLAN_EID_HT_OPERATION, &ie_len,
+		(pnetwork->ie_length - sizeof(struct ndis_802_11_fix_ie)));
 	if (p && ie_len) {
 		pht_info = (struct HT_info_element *)(p + 2);
 
 		if ((pregpriv->bw_mode & 0x0f) > 0)
 			cbw40_enable = 1;
 
-		if ((cbw40_enable) &&	 (pht_info->infos[0] & BIT(2))) {
+		if ((cbw40_enable) && (pht_info->infos[0] & BIT(2))) {
 			/* switch to the 40M Hz mode */
 			cur_bwmode = CHANNEL_WIDTH_40;
 			switch (pht_info->infos[0] & 0x3) {
@@ -732,7 +754,8 @@ void start_bss_network(struct adapter *padapter)
 
 	/* update RRSR after set channel and bandwidth */
 	update_basic_rate_table(padapter, pnetwork->supported_rates);
-	rtw_hal_set_hwreg(padapter, HW_VAR_BASIC_RATE, pnetwork->supported_rates);
+	rtw_hal_set_hwreg(padapter, HW_VAR_BASIC_RATE,
+			  pnetwork->supported_rates);
 
 	/* update capability after cur_wireless_mode updated */
 	update_capinfo(padapter,
@@ -749,7 +772,7 @@ void start_bss_network(struct adapter *padapter)
 	update_bmc_sta(padapter);
 }
 
-int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
+int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
 {
 	int ret = _SUCCESS;
 	u8 *p;
@@ -761,13 +784,13 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	int group_cipher, pairwise_cipher;
 	u8 channel, network_type, support_rate[NDIS_802_11_LENGTH_RATES_EX];
 	int support_rate_num = 0;
-	u8 OUI1[] = {0x00, 0x50, 0xf2, 0x01};
-	u8 WMM_PARA_IE[] = {0x00, 0x50, 0xf2, 0x02, 0x01, 0x01};
+	u8 OUI1[] = { 0x00, 0x50, 0xf2, 0x01 };
+	u8 WMM_PARA_IE[] = { 0x00, 0x50, 0xf2, 0x02, 0x01, 0x01 };
 	struct registry_priv *pregistrypriv = &padapter->registrypriv;
 	struct security_priv *psecuritypriv = &padapter->securitypriv;
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
-	struct wlan_bssid_ex
-		*pbss_network = (struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
+	struct wlan_bssid_ex *pbss_network =
+		(struct wlan_bssid_ex *)&pmlmepriv->cur_network.network;
 	u8 *ie = pbss_network->ies;
 
 	if (!check_fwstate(pmlmepriv, WIFI_AP_STATE))
@@ -787,7 +810,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 	pbss_network->rssi = 0;
 
-	memcpy(pbss_network->mac_address, myid(&padapter->eeprompriv), ETH_ALEN);
+	memcpy(pbss_network->mac_address, myid(&padapter->eeprompriv),
+	       ETH_ALEN);
 
 	/* beacon interval */
 	/* ie + 8;	8: TimeStamp, 2: Beacon Interval 2:Capability */
@@ -798,9 +822,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	cap = get_unaligned_le16(ie);
 
 	/* SSID */
-	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_,
-		       WLAN_EID_SSID,
-		       &ie_len,
+	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_SSID, &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0) {
 		memset(&pbss_network->ssid, 0, sizeof(struct ndis_802_11_ssid));
@@ -811,8 +833,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	/* channel */
 	channel = 0;
 	pbss_network->configuration.length = 0;
-	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_,
-		       WLAN_EID_DS_PARAMS, &ie_len,
+	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_DS_PARAMS, &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0)
 		channel = *(p + 2);
@@ -821,9 +842,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 	memset(support_rate, 0, NDIS_802_11_LENGTH_RATES_EX);
 	/*  get supported rates */
-	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_,
-		       WLAN_EID_SUPP_RATES,
-		       &ie_len,
+	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_SUPP_RATES, &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p) {
 		memcpy(support_rate, p + 2, ie_len);
@@ -831,10 +850,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	}
 
 	/* get ext_supported rates */
-	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_,
-		       WLAN_EID_EXT_SUPP_RATES,
-		       &ie_len,
-		       pbss_network->ie_length - _BEACON_IE_OFFSET_);
+	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_EXT_SUPP_RATES,
+		       &ie_len, pbss_network->ie_length - _BEACON_IE_OFFSET_);
 	if (p)
 		memcpy(support_rate + support_rate_num, p + 2, ie_len);
 
@@ -843,9 +860,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	rtw_set_supported_rate(pbss_network->supported_rates, network_type);
 
 	/* parsing ERP_IE */
-	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_,
-		       WLAN_EID_ERP_INFO,
-		       &ie_len,
+	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_ERP_INFO, &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0)
 		ERP_IE_handler(padapter, (struct ndis_80211_var_ie *)p);
@@ -859,22 +874,19 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	psecuritypriv->wpa_psk = 0;
 
 	/* wpa2 */
-	group_cipher = 0; pairwise_cipher = 0;
+	group_cipher = 0;
+	pairwise_cipher = 0;
 	psecuritypriv->wpa2_group_cipher = _NO_PRIVACY_;
 	psecuritypriv->wpa2_pairwise_cipher = _NO_PRIVACY_;
-	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_,
-		       WLAN_EID_RSN,
-		       &ie_len,
+	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_RSN, &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0) {
-		if (rtw_parse_wpa2_ie(p,
-				      ie_len + 2,
-				      &group_cipher,
-				      &pairwise_cipher,
-				      NULL) == _SUCCESS) {
-			psecuritypriv->dot11AuthAlgrthm = dot11AuthAlgrthm_8021X;
-
-			psecuritypriv->dot8021xalg = 1;/* psk,  todo:802.1x */
+		if (rtw_parse_wpa2_ie(p, ie_len + 2, &group_cipher,
+				      &pairwise_cipher, NULL) == _SUCCESS) {
+			psecuritypriv->dot11AuthAlgrthm =
+				dot11AuthAlgrthm_8021X;
+
+			psecuritypriv->dot8021xalg = 1; /* psk,  todo:802.1x */
 			psecuritypriv->wpa_psk |= BIT(1);
 
 			psecuritypriv->wpa2_group_cipher = group_cipher;
@@ -884,28 +896,29 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 	/* wpa */
 	ie_len = 0;
-	group_cipher = 0; pairwise_cipher = 0;
+	group_cipher = 0;
+	pairwise_cipher = 0;
 	psecuritypriv->wpa_group_cipher = _NO_PRIVACY_;
 	psecuritypriv->wpa_pairwise_cipher = _NO_PRIVACY_;
-	for (p = ie + _BEACON_IE_OFFSET_; ; p += (ie_len + 2)) {
-		p = rtw_get_ie(p,
-			       WLAN_EID_VENDOR_SPECIFIC,
-			       &ie_len,
-			       (pbss_network->ie_length - _BEACON_IE_OFFSET_ - (ie_len + 2)));
+	for (p = ie + _BEACON_IE_OFFSET_;; p += (ie_len + 2)) {
+		p = rtw_get_ie(p, WLAN_EID_VENDOR_SPECIFIC, &ie_len,
+			       (pbss_network->ie_length - _BEACON_IE_OFFSET_ -
+				(ie_len + 2)));
 		if ((p) && (!memcmp(p + 2, OUI1, 4))) {
-			if (rtw_parse_wpa_ie(p,
-					     ie_len + 2,
-					     &group_cipher,
+			if (rtw_parse_wpa_ie(p, ie_len + 2, &group_cipher,
 					     &pairwise_cipher,
 					     NULL) == _SUCCESS) {
-				psecuritypriv->dot11AuthAlgrthm = dot11AuthAlgrthm_8021X;
+				psecuritypriv->dot11AuthAlgrthm =
+					dot11AuthAlgrthm_8021X;
 
-				psecuritypriv->dot8021xalg = 1;/* psk,  todo:802.1x */
+				psecuritypriv->dot8021xalg =
+					1; /* psk,  todo:802.1x */
 
 				psecuritypriv->wpa_psk |= BIT(0);
 
 				psecuritypriv->wpa_group_cipher = group_cipher;
-				psecuritypriv->wpa_pairwise_cipher = pairwise_cipher;
+				psecuritypriv->wpa_pairwise_cipher =
+					pairwise_cipher;
 			}
 
 			break;
@@ -919,16 +932,15 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	ie_len = 0;
 	pmlmepriv->qospriv.qos_option = 0;
 	if (pregistrypriv->wmm_enable) {
-		for (p = ie + _BEACON_IE_OFFSET_; ; p += (ie_len + 2)) {
-			p = rtw_get_ie(p,
-				       WLAN_EID_VENDOR_SPECIFIC,
-				       &ie_len,
+		for (p = ie + _BEACON_IE_OFFSET_;; p += (ie_len + 2)) {
+			p = rtw_get_ie(p, WLAN_EID_VENDOR_SPECIFIC, &ie_len,
 				       (pbss_network->ie_length -
 					_BEACON_IE_OFFSET_ - (ie_len + 2)));
 			if ((p) && !memcmp(p + 2, WMM_PARA_IE, 6)) {
 				pmlmepriv->qospriv.qos_option = 1;
 
-				*(p + 8) |= BIT(7);/* QoS Info, support U-APSD */
+				*(p + 8) |=
+					BIT(7); /* QoS Info, support U-APSD */
 
 				/* disable all ACM bits since the WMM admission */
 				/* control is not supported */
@@ -946,13 +958,12 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	}
 
 	/* parsing HT_CAP_IE */
-	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_,
-		       WLAN_EID_HT_CAPABILITY,
-		       &ie_len,
+	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_HT_CAPABILITY, &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0) {
 		u8 max_rx_ampdu_factor = 0;
-		struct ieee80211_ht_cap *pht_cap = (struct ieee80211_ht_cap *)(p + 2);
+		struct ieee80211_ht_cap *pht_cap =
+			(struct ieee80211_ht_cap *)(p + 2);
 
 		ht_caps_ie = p;
 
@@ -962,38 +973,42 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 		rtw_ht_use_default_setting(padapter);
 
 		if (!pmlmepriv->htpriv.sgi_20m)
-			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
+			pht_cap->cap_info &=
+				cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
 
 		if (!pmlmepriv->htpriv.sgi_40m)
-			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
+			pht_cap->cap_info &=
+				cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))
-			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_LDPC_CODING));
+			pht_cap->cap_info &=
+				cpu_to_le16(~(IEEE80211_HT_CAP_LDPC_CODING));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.stbc_cap, STBC_HT_ENABLE_TX))
-			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_TX_STBC));
+			pht_cap->cap_info &=
+				cpu_to_le16(~(IEEE80211_HT_CAP_TX_STBC));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.stbc_cap, STBC_HT_ENABLE_RX))
-			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_RX_STBC_3R));
+			pht_cap->cap_info &=
+				cpu_to_le16(~(IEEE80211_HT_CAP_RX_STBC_3R));
 
 		pht_cap->ampdu_params_info &= ~(IEEE80211_HT_CAP_AMPDU_FACTOR |
 						IEEE80211_HT_CAP_AMPDU_DENSITY);
 
 		if ((psecuritypriv->wpa_pairwise_cipher & WPA_CIPHER_CCMP) ||
 		    (psecuritypriv->wpa2_pairwise_cipher & WPA_CIPHER_CCMP)) {
-			pht_cap->ampdu_params_info |= (IEEE80211_HT_CAP_AMPDU_DENSITY &
-						       (0x07 << 2));
+			pht_cap->ampdu_params_info |=
+				(IEEE80211_HT_CAP_AMPDU_DENSITY & (0x07 << 2));
 		} else {
-			pht_cap->ampdu_params_info |= (IEEE80211_HT_CAP_AMPDU_DENSITY &
-						       0x00);
+			pht_cap->ampdu_params_info |=
+				(IEEE80211_HT_CAP_AMPDU_DENSITY & 0x00);
 		}
 
-		rtw_hal_get_def_var(padapter,
-				    HW_VAR_MAX_RX_AMPDU_FACTOR,
+		rtw_hal_get_def_var(padapter, HW_VAR_MAX_RX_AMPDU_FACTOR,
 				    &max_rx_ampdu_factor);
 		/* set Max Rx AMPDU size to 64K */
-		pht_cap->ampdu_params_info |= (IEEE80211_HT_CAP_AMPDU_FACTOR &
-					       max_rx_ampdu_factor);
+		pht_cap->ampdu_params_info |=
+			(IEEE80211_HT_CAP_AMPDU_FACTOR & max_rx_ampdu_factor);
 
 		pht_cap->mcs.rx_mask[0] = 0xff;
 		pht_cap->mcs.rx_mask[1] = 0x0;
@@ -1002,9 +1017,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	}
 
 	/* parsing HT_INFO_IE */
-	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_,
-		       WLAN_EID_HT_OPERATION,
-		       &ie_len,
+	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_HT_OPERATION, &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0)
 		ht_info_ie = p;
@@ -1036,9 +1049,11 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 		if (pregistrypriv->ampdu_enable == 1)
 			pmlmepriv->htpriv.ampdu_enable = true;
 
-		HT_caps_handler(padapter, (struct ndis_80211_var_ie *)ht_caps_ie);
+		HT_caps_handler(padapter,
+				(struct ndis_80211_var_ie *)ht_caps_ie);
 
-		HT_info_handler(padapter, (struct ndis_80211_var_ie *)ht_info_ie);
+		HT_info_handler(padapter,
+				(struct ndis_80211_var_ie *)ht_info_ie);
 	}
 
 	pbss_network->length =
@@ -1050,7 +1065,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	/* alloc sta_info for ap itself */
 	psta = rtw_get_stainfo(&padapter->stapriv, pbss_network->mac_address);
 	if (!psta) {
-		psta = rtw_alloc_stainfo(&padapter->stapriv, pbss_network->mac_address);
+		psta = rtw_alloc_stainfo(&padapter->stapriv,
+					 pbss_network->mac_address);
 		if (!psta)
 			return _FAIL;
 	}
@@ -1061,7 +1077,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	psta->state |= WIFI_AP_STATE;
 	rtw_indicate_connect(padapter);
 
-	pmlmepriv->cur_network.join_res = true;/* for check if already set beacon */
+	pmlmepriv->cur_network.join_res =
+		true; /* for check if already set beacon */
 
 	return ret;
 }
@@ -1076,13 +1093,13 @@ void rtw_set_macaddr_acl(struct adapter *padapter, int mode)
 
 int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)
 {
-	struct list_head	*plist, *phead;
+	struct list_head *plist, *phead;
 	u8 added = false;
 	int i, ret = 0;
 	struct rtw_wlan_acl_node *paclnode;
 	struct sta_priv *pstapriv = &padapter->stapriv;
 	struct wlan_acl_pool *pacl_list = &pstapriv->acl_list;
-	struct __queue	*pacl_node_q = &pacl_list->acl_node_q;
+	struct __queue *pacl_node_q = &pacl_list->acl_node_q;
 
 	if ((NUM_ACL - 1) < pacl_list->num)
 		return (-1);
@@ -1118,7 +1135,8 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)
 
 			paclnode->valid = true;
 
-			list_add_tail(&paclnode->list, get_list_head(pacl_node_q));
+			list_add_tail(&paclnode->list,
+				      get_list_head(pacl_node_q));
 
 			pacl_list->num++;
 
@@ -1137,7 +1155,7 @@ void rtw_acl_remove_sta(struct adapter *padapter, u8 *addr)
 	struct rtw_wlan_acl_node *paclnode;
 	struct sta_priv *pstapriv = &padapter->stapriv;
 	struct wlan_acl_pool *pacl_list = &pstapriv->acl_list;
-	struct __queue	*pacl_node_q = &pacl_list->acl_node_q;
+	struct __queue *pacl_node_q = &pacl_list->acl_node_q;
 
 	spin_lock_bh(&pacl_node_q->lock);
 
@@ -1163,7 +1181,7 @@ void rtw_acl_remove_sta(struct adapter *padapter, u8 *addr)
 u8 rtw_ap_set_pairwise_key(struct adapter *padapter, struct sta_info *psta)
 {
 	struct cmd_obj *ph2c;
-	struct set_stakey_parm	*psetstakey_para;
+	struct set_stakey_parm *psetstakey_para;
 	struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
 	u8 res = _SUCCESS;
 
@@ -1195,10 +1213,7 @@ u8 rtw_ap_set_pairwise_key(struct adapter *padapter, struct sta_info *psta)
 	return res;
 }
 
-static int rtw_ap_set_key(struct adapter *padapter,
-			  u8 *key,
-			  u8 alg,
-			  int keyid,
+static int rtw_ap_set_key(struct adapter *padapter, u8 *key, u8 alg, int keyid,
 			  u8 set_tx)
 {
 	u8 keylen;
@@ -1245,7 +1260,7 @@ static int rtw_ap_set_key(struct adapter *padapter,
 
 	pcmd->cmdcode = _SetKey_CMD_;
 	pcmd->parmbuf = (u8 *)psetkeyparm;
-	pcmd->cmdsz =  (sizeof(struct setkey_parm));
+	pcmd->cmdsz = (sizeof(struct setkey_parm));
 	pcmd->rsp = NULL;
 	pcmd->rspsz = 0;
 
@@ -1263,10 +1278,7 @@ int rtw_ap_set_group_key(struct adapter *padapter, u8 *key, u8 alg, int keyid)
 	return rtw_ap_set_key(padapter, key, alg, keyid, 1);
 }
 
-int rtw_ap_set_wep_key(struct adapter *padapter,
-		       u8 *key,
-		       u8 keylen,
-		       int keyid,
+int rtw_ap_set_wep_key(struct adapter *padapter, u8 *key, u8 keylen, int keyid,
 		       u8 set_tx)
 {
 	u8 alg;
@@ -1302,18 +1314,17 @@ static void update_bcn_erpinfo_ie(struct adapter *padapter)
 		return;
 
 	/* parsing ERP_IE */
-	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_,
-		       WLAN_EID_ERP_INFO,
-		       &len,
+	p = rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_ERP_INFO, &len,
 		       (pnetwork->ie_length - _BEACON_IE_OFFSET_));
 	if (p && len > 0) {
 		struct ndis_80211_var_ie *ie = (struct ndis_80211_var_ie *)p;
 
 		if (pmlmepriv->num_sta_non_erp == 1)
-			ie->data[0] |= RTW_ERP_INFO_NON_ERP_PRESENT | RTW_ERP_INFO_USE_PROTECTION;
+			ie->data[0] |= RTW_ERP_INFO_NON_ERP_PRESENT |
+				       RTW_ERP_INFO_USE_PROTECTION;
 		else
 			ie->data[0] &= ~(RTW_ERP_INFO_NON_ERP_PRESENT |
-					  RTW_ERP_INFO_USE_PROTECTION);
+					 RTW_ERP_INFO_USE_PROTECTION);
 
 		if (pmlmepriv->num_sta_no_short_preamble > 0)
 			ie->data[0] |= RTW_ERP_INFO_BARKER_PREAMBLE_MODE;
@@ -1360,9 +1371,7 @@ static void update_bcn_wps_ie(struct adapter *padapter)
 	u32 ielen = pnetwork->ie_length;
 
 	pwps_ie = rtw_get_wps_ie(ie + _FIXED_IE_LENGTH_,
-				 ielen - _FIXED_IE_LENGTH_,
-				 NULL,
-				 &wps_ielen);
+				 ielen - _FIXED_IE_LENGTH_, NULL, &wps_ielen);
 
 	if (!pwps_ie || wps_ielen == 0)
 		return;
@@ -1378,9 +1387,10 @@ static void update_bcn_wps_ie(struct adapter *padapter)
 	remainder_ielen = ielen - wps_offset - wps_ielen;
 
 	if (remainder_ielen)
-		pbackup_remainder_ie = kmemdup(premainder_ie, remainder_ielen, GFP_ATOMIC);
+		pbackup_remainder_ie =
+			kmemdup(premainder_ie, remainder_ielen, GFP_ATOMIC);
 
-	wps_ielen = (unsigned int)pwps_ie_src[1];/* to get ie data len */
+	wps_ielen = (unsigned int)pwps_ie_src[1]; /* to get ie data len */
 	if ((wps_offset + wps_ielen + 2 + remainder_ielen) <= MAX_IE_SZ) {
 		memcpy(pwps_ie, pwps_ie_src, wps_ielen + 2);
 		pwps_ie += (wps_ielen + 2);
@@ -1389,7 +1399,8 @@ static void update_bcn_wps_ie(struct adapter *padapter)
 			memcpy(pwps_ie, pbackup_remainder_ie, remainder_ielen);
 
 		/* update ie_length */
-		pnetwork->ie_length = wps_offset + (wps_ielen + 2) + remainder_ielen;
+		pnetwork->ie_length =
+			wps_offset + (wps_ielen + 2) + remainder_ielen;
 	}
 
 	kfree(pbackup_remainder_ie);
@@ -1433,7 +1444,8 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
 	switch (ie_id) {
 	case 0xFF:
 
-		update_bcn_fixed_ie(padapter);/* 8: TimeStamp, 2: Beacon Interval 2:Capability */
+		update_bcn_fixed_ie(
+			padapter); /* 8: TimeStamp, 2: Beacon Interval 2:Capability */
 
 		break;
 
@@ -1509,14 +1521,12 @@ static int rtw_ht_operation_update(struct adapter *padapter)
 
 	if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
 	    pmlmepriv->num_sta_ht_no_gf) {
-		pmlmepriv->ht_op_mode |=
-			IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT;
+		pmlmepriv->ht_op_mode |= IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT;
 		op_mode_changes++;
 	} else if ((pmlmepriv->ht_op_mode &
 		    IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
 		   pmlmepriv->num_sta_ht_no_gf == 0) {
-		pmlmepriv->ht_op_mode &=
-			~IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT;
+		pmlmepriv->ht_op_mode &= ~IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT;
 		op_mode_changes++;
 	}
 
@@ -1527,8 +1537,7 @@ static int rtw_ht_operation_update(struct adapter *padapter)
 	} else if ((pmlmepriv->ht_op_mode &
 		    IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT) &&
 		   (pmlmepriv->num_sta_no_ht == 0 && !pmlmepriv->olbc_ht)) {
-		pmlmepriv->ht_op_mode &=
-			~IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT;
+		pmlmepriv->ht_op_mode &= ~IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT;
 		op_mode_changes++;
 	}
 
@@ -1563,7 +1572,7 @@ void associated_clients_update(struct adapter *padapter, u8 updated)
 {
 	/* update associated stations cap. */
 	if (updated) {
-		struct list_head	*phead, *plist;
+		struct list_head *phead, *plist;
 		struct sta_info *psta = NULL;
 		struct sta_priv *pstapriv = &padapter->stapriv;
 
@@ -1622,7 +1631,8 @@ void bss_cap_update_on_sta_join(struct adapter *padapter, struct sta_info *psta)
 
 			if (pmlmepriv->num_sta_non_erp == 1) {
 				beacon_updated = true;
-				update_beacon(padapter, WLAN_EID_ERP_INFO, NULL, true);
+				update_beacon(padapter, WLAN_EID_ERP_INFO, NULL,
+					      true);
 			}
 		}
 	} else {
@@ -1633,7 +1643,8 @@ void bss_cap_update_on_sta_join(struct adapter *padapter, struct sta_info *psta)
 
 			if (pmlmepriv->num_sta_non_erp == 0) {
 				beacon_updated = true;
-				update_beacon(padapter, WLAN_EID_ERP_INFO, NULL, true);
+				update_beacon(padapter, WLAN_EID_ERP_INFO, NULL,
+					      true);
 			}
 		}
 	}
@@ -1699,7 +1710,7 @@ void bss_cap_update_on_sta_join(struct adapter *padapter, struct sta_info *psta)
 	}
 
 	/* update associated stations cap. */
-	associated_clients_update(padapter,  beacon_updated);
+	associated_clients_update(padapter, beacon_updated);
 }
 
 u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta)
@@ -1715,7 +1726,7 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta)
 		psta->no_short_preamble_set = 0;
 		pmlmepriv->num_sta_no_short_preamble--;
 		if (pmlmeext->cur_wireless_mode > WIRELESS_11B &&
-		    pmlmepriv->num_sta_no_short_preamble == 0){
+		    pmlmepriv->num_sta_no_short_preamble == 0) {
 			beacon_updated = true;
 			update_beacon(padapter, 0xFF, NULL, true);
 		}
@@ -1734,7 +1745,7 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta)
 		psta->no_short_slot_time_set = 0;
 		pmlmepriv->num_sta_no_short_slot_time--;
 		if (pmlmeext->cur_wireless_mode > WIRELESS_11B &&
-		    pmlmepriv->num_sta_no_short_slot_time == 0){
+		    pmlmepriv->num_sta_no_short_slot_time == 0) {
 			beacon_updated = true;
 			update_beacon(padapter, 0xFF, NULL, true);
 		}
@@ -1763,9 +1774,7 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta)
 	return beacon_updated;
 }
 
-u8 ap_free_sta(struct adapter *padapter,
-	       struct sta_info *psta,
-	       bool active,
+u8 ap_free_sta(struct adapter *padapter, struct sta_info *psta, bool active,
 	       u16 reason)
 {
 	u8 beacon_updated = false;
@@ -1775,16 +1784,16 @@ u8 ap_free_sta(struct adapter *padapter,
 
 	if (active) {
 		/* tear down Rx AMPDU */
-		send_delba(padapter, 0, psta->hwaddr);/*  recipient */
+		send_delba(padapter, 0, psta->hwaddr); /*  recipient */
 
 		/* tear down TX AMPDU */
-		send_delba(padapter, 1, psta->hwaddr);/*  // originator */
+		send_delba(padapter, 1, psta->hwaddr); /*  // originator */
 
 		issue_deauth(padapter, psta->hwaddr, reason);
 	}
 
-	psta->htpriv.agg_enable_bitmap = 0x0;/* reset */
-	psta->htpriv.candidate_tid_bitmap = 0x0;/* reset */
+	psta->htpriv.agg_enable_bitmap = 0x0; /* reset */
+	psta->htpriv.candidate_tid_bitmap = 0x0; /* reset */
 
 	/* clear cam entry / key */
 	rtw_clearstakey_cmd(padapter, psta, true);
@@ -1811,7 +1820,7 @@ void rtw_sta_flush(struct adapter *padapter)
 	struct sta_priv *pstapriv = &padapter->stapriv;
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 	struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
-	u8 bc_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
+	u8 bc_addr[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
 
 	if ((pmlmeinfo->state & 0x03) != WIFI_FW_AP_STATE)
 		return;
@@ -1873,7 +1882,7 @@ void ap_sta_info_defer_update(struct adapter *padapter, struct sta_info *psta)
 		pmlmeinfo->FW_sta_info[psta->mac_id].psta = psta;
 
 		/* add ratid */
-		add_ratid(padapter, psta, 0);/* DM_RATR_STA_INIT */
+		add_ratid(padapter, psta, 0); /* DM_RATR_STA_INIT */
 	}
 }
 
@@ -1884,28 +1893,23 @@ void rtw_ap_restore_network(struct adapter *padapter)
 	struct sta_priv *pstapriv = &padapter->stapriv;
 	struct sta_info *psta;
 	struct security_priv *psecuritypriv = &padapter->securitypriv;
-	struct list_head	*phead, *plist;
+	struct list_head *phead, *plist;
 	u8 chk_alive_num = 0;
 	char chk_alive_list[NUM_STA];
 	int i;
 
 	rtw_setopmode_cmd(padapter, Ndis802_11APMode, false);
 
-	set_channel_bwmode(padapter,
-			   pmlmeext->cur_channel,
-			   pmlmeext->cur_ch_offset,
-			   pmlmeext->cur_bwmode);
+	set_channel_bwmode(padapter, pmlmeext->cur_channel,
+			   pmlmeext->cur_ch_offset, pmlmeext->cur_bwmode);
 
 	start_bss_network(padapter);
 
 	if ((padapter->securitypriv.dot11PrivacyAlgrthm == _TKIP_) ||
 	    (padapter->securitypriv.dot11PrivacyAlgrthm == _AES_)) {
 		/* restore group key, WEP keys is restored in ips_leave() */
-		rtw_set_key(padapter,
-			    psecuritypriv,
-			    psecuritypriv->dot118021XGrpKeyid,
-			    0,
-			    false);
+		rtw_set_key(padapter, psecuritypriv,
+			    psecuritypriv->dot118021XGrpKeyid, 0, false);
 	}
 
 	spin_lock_bh(&pstapriv->asoc_list_lock);
@@ -1999,14 +2003,13 @@ void stop_ap_mode(struct adapter *padapter)
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 	struct wlan_acl_pool *pacl_list = &pstapriv->acl_list;
-	struct __queue	*pacl_node_q = &pacl_list->acl_node_q;
+	struct __queue *pacl_node_q = &pacl_list->acl_node_q;
 
 	pmlmepriv->update_bcn = false;
 	pmlmeext->bstart_bss = false;
 
 	/* reset and init security priv , this can refine with rtw_reset_securitypriv */
-	memset((unsigned char *)&padapter->securitypriv,
-	       0,
+	memset((unsigned char *)&padapter->securitypriv, 0,
 	       sizeof(struct security_priv));
 	padapter->securitypriv.ndisauthtype = Ndis802_11AuthModeOpen;
 	padapter->securitypriv.ndisencryptstatus = Ndis802_11WEPDisabled;
drivers/staging/rtl8723bs/core/rtw_btcoex.c +2 -1
index 9e00424d00bdd..5eafc13286304 100644
@@ -38,7 +38,8 @@ void rtw_btcoex_reject_ap_aggregated_packet(struct adapter *padapter, u8 enable)
 	struct sta_info *psta;
 
 	pmlmeinfo = &padapter->mlmeextpriv.mlmext_info;
-	psta = rtw_get_stainfo(&padapter->stapriv, get_bssid(&padapter->mlmepriv));
+	psta = rtw_get_stainfo(&padapter->stapriv,
+			       get_bssid(&padapter->mlmepriv));
 
 	if (enable) {
 		pmlmeinfo->accept_addba_req = false;
drivers/staging/rtl8723bs/core/rtw_cmd.c +438 -316

1,379 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_efuse.c +30 -28

142 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_ieee80211.c +115 -83

457 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_io.c +2 -1
index c793ae7ea5c46..47f0f8a241d78 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +76 -44

120 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_mlme.c +577 -353

930 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +1446 -892

2,338 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +77 -50

127 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_recv.c +355 -196

551 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_security.c +448 -376

824 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +58 -45

103 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_wlan_util.c +260 -149

409 lines not on this page · raw message

drivers/staging/rtl8723bs/core/rtw_xmit.c +362 -211

573 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/Hal8723BReg.h +14 -14
index 0b327a70aa15c..26954c5a4a34d 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c +779 -806

1,585 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h +48 -46

94 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +962 -732

1,694 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.h +38 -36

74 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h +116 -132

248 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c +148 -360

508 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.h +6 -12
index 054acfe231b46..8f3e5918d52d7 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c +64 -131

195 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.h +2 -4
index 2508613259194..1eb6b0f58eeca 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c +233 -399

632 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.h +6 -12
index 7b4f399fcdff1..bcb612bd183d7 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/HalPhyRf.c +93 -68

161 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalPhyRf.h +6 -9
index bd9430db968f2..73282dc568d90 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +806 -576

1,382 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h +16 -33

49 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c +34 -36

70 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/Mp_Precomp.h +1 -1
index f08823a8dd7b3..5e9d23f1d8c94 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/hal_btcoex.c +73 -57

130 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/hal_com.c +123 -130

253 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +221 -183

404 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/hal_intf.c +32 -18

50 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/hal_pwr_seq.c +47 -74

121 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/hal_sdio.c +16 -16
index 1a865d4de8ac7..31a262286a0e8 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/odm.c +157 -145

302 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm.h +270 -281

551 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_CfoTracking.c +25 -34

59 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_CfoTracking.h +6 -7
index 8fa6d9ec58807..33d30d406c916 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/odm_DIG.c +173 -155

328 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_DIG.h +33 -42

75 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c +38 -16

54 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.h +2 -3
index 3ebbbfd1dd1fe..ef5172d204388 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/odm_DynamicTxPower.h +16 -16
index e2d244324ebe9..9ad2c9bcfde89 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/odm_EdcaTurboCheck.c +21 -18
index 578d5712645c8..21a352f87bb2b 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/odm_HWConfig.c +127 -80

207 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_HWConfig.h +33 -38

71 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_RegConfig8723B.c +39 -82

121 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_RegConfig8723B.h +14 -29

43 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_RegDefine11N.h +135 -135

270 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_interface.h +10 -10
index f79c3d57edffa..45948b2adc186 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/odm_precomp.h +9 -9
index 2987857a8761f..5acaa70c6dd0b 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/odm_reg.h +61 -61

122 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/odm_types.h +26 -18

44 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +225 -180

405 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +50 -44

94 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +768 -677

1,445 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +185 -149

334 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c +31 -22

53 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/rtl8723b_rxdesc.c +9 -6
index ac12496767944..164d50b03e769 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +80 -51

131 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +100 -75

175 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/sdio_halinit.c +137 -119

256 lines not on this page · raw message

drivers/staging/rtl8723bs/hal/sdio_ops.c +59 -79

138 lines not on this page · raw message

drivers/staging/rtl8723bs/include/Hal8192CPhyReg.h +117 -117

234 lines not on this page · raw message

drivers/staging/rtl8723bs/include/HalPwrSeqCmd.h +55 -62

117 lines not on this page · raw message

drivers/staging/rtl8723bs/include/basic_types.h +65 -90

155 lines not on this page · raw message

drivers/staging/rtl8723bs/include/cmd_osdep.h +4 -4
index 91d933d71945d..3d09242391ab2 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/drv_types.h +92 -91

183 lines not on this page · raw message

drivers/staging/rtl8723bs/include/drv_types_sdio.h +6 -6
index 25b3c3a39ee44..8ec4b4ed8f1eb 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/hal_btcoex.h +1 -1
index 525cce3574fe1..504aa40ce11fd 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/hal_com.h +66 -82

148 lines not on this page · raw message

drivers/staging/rtl8723bs/include/hal_com_h2c.h +6 -6
index a59d130905659..c6e167cf9d5fe 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/hal_com_phycfg.h +25 -25

50 lines not on this page · raw message

drivers/staging/rtl8723bs/include/hal_com_reg.h +339 -345

684 lines not on this page · raw message

drivers/staging/rtl8723bs/include/hal_data.h +108 -106

214 lines not on this page · raw message

drivers/staging/rtl8723bs/include/hal_intf.h +68 -51

119 lines not on this page · raw message

drivers/staging/rtl8723bs/include/hal_pg.h +24 -27

51 lines not on this page · raw message

drivers/staging/rtl8723bs/include/hal_phy.h +25 -28

53 lines not on this page · raw message

drivers/staging/rtl8723bs/include/hal_phy_cfg.h +18 -19
index 07bf0a8d019aa..3943c444cd15a 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/hal_phy_reg.h +1 -1
index 682cdd6655ab2..caa1f6ebdfcdd 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/hal_pwr_seq.h +825 -198

1,023 lines not on this page · raw message

drivers/staging/rtl8723bs/include/hal_sdio.h +7 -4
index 3fc8acb430e57..e0938a4894020 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/ieee80211.h +256 -259

515 lines not on this page · raw message

drivers/staging/rtl8723bs/include/ioctl_cfg80211.h +26 -11
index bc62b7285950f..f9fd4c8d76733 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/osdep_intf.h +1 -1
index 83a25598e9627..cdc4867798698 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/osdep_service.h +3 -6
index 2f5011a8210cd..4b03acb94bb94 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/osdep_service_linux.h +10 -8
index 2ec54f9e180c2..b53f6996789fe 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtl8192c_recv.h +5 -3
index 1f86654f04033..8c6649405835f 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtl8723b_cmd.h +127 -64

191 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtl8723b_hal.h +33 -33

66 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtl8723b_recv.h +59 -58

117 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtl8723b_rf.h +3 -5
index 525eb2facca06..b7b3271b96e01 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtl8723b_spec.h +113 -106

219 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtl8723b_xmit.h +427 -301

728 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_ap.h +7 -4
index 83e835eb6513f..b147ce36fb92b 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtw_btcoex.h +6 -5
index 7651034987898..48cb2a202ae7e 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtw_byteorder.h +1 -1
index c3a65f9717932..0d16ca4f69f15 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtw_cmd.h +153 -142

295 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_eeprom.h +33 -30

63 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_efuse.h +21 -20

41 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_event.h +14 -20
index 62e0dec249adb..ef40dc49202f9 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtw_ht.h +25 -20

45 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_io.h +15 -14
index 3c99a2bc19bd0..48633dac55b29 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtw_ioctl_set.h +12 -5
index c3a1d1a84f789..bc49214425663 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtw_mlme.h +113 -90

203 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +228 -179

407 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +77 -66

143 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_qos.h +4 -7
index 1f28837f6c27c..d6fbf9c37479e 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtw_recv.h +96 -100

196 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_rf.h +43 -44

87 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_security.h +146 -156

302 lines not on this page · raw message

drivers/staging/rtl8723bs/include/rtw_version.h +2 -2
index 55e907b097aef..008a74c2644ca 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/rtw_xmit.h +166 -161

327 lines not on this page · raw message

drivers/staging/rtl8723bs/include/sdio_ops.h +4 -3
index 252b0e1646e51..0f89e4765c3be 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/sdio_ops_linux.h +3 -3
index cd67a7201065f..c02c2d9e98caf 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/include/sta_info.h +89 -95

184 lines not on this page · raw message

drivers/staging/rtl8723bs/include/wifi.h +214 -216

430 lines not on this page · raw message

drivers/staging/rtl8723bs/include/wlan_bssdef.h +68 -81

149 lines not on this page · raw message

drivers/staging/rtl8723bs/include/xmit_osdep.h +8 -6
index 5b351652e31bd..aa6768d7ef9a5 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +624 -369

993 lines not on this page · raw message

drivers/staging/rtl8723bs/os_dep/os_intfs.c +83 -62

145 lines not on this page · raw message

drivers/staging/rtl8723bs/os_dep/osdep_service.c +6 -3
index 4cfdf7c623440..33b0989e3d396 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/os_dep/sdio_intf.c +38 -29

67 lines not on this page · raw message

drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c +6 -5
index e9a2f3f7ec747..3fc14f28cc53a 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/os_dep/wifi_regd.c +15 -19
index c48a1e3ba4acc..14f1eaf73d158 100644

Lines of this file are not shown. View the raw message.

drivers/staging/rtl8723bs/os_dep/xmit_linux.c +17 -13
index 4260ed5f4e974..a63ce84065eba 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.50.1 (Apple Git-155)

Part of the diff is not shown here. View the raw message.

maintainer
#1 lore raw
Quoted 8 lines · Aryan Krishnan

From: Aryan <[email protected]>

This patch formats the drivers/staging/rtl8723bs directory using clang-format, hence reducing the number of errors by 2, warnings by 66, and CHECKs by 4,685.

This is a purely mechanical, whitespace/formatting-only change with no functional impact.

Which, if we wanted to, we could have done already, but that's not the point here in staging. The point is to have a place where people can learn how to contribute to the kernel in an easy way. By just using an automated tool, no one learns much :(

As my bot says for this patch:

----------------

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause.

- It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/process/submitting-patches.rst for how to do this correctly.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

#2 lore raw

Hey Greg,

Thanks for the quick reply and for explaining the main goal in staging.

Initially, I just made this patch as a way for me to better understand git email,
alongside, of course, fixing some of the CHECKS.

I do agree with the point that automated tooling can sometimes reduce learning, and
that the patch was too large. Maybe instead of one big patch, I could format this as
we modify other files in the process.

That being said, I do have quite a few other patches that I could share that do work on
fixing some of the errors generated.

Thanks once again, and I will share some of these other patches in separate threads soon.
- Aryan