Skip to contentSkip to conversation

ARM: dts: BCM5301X: Add missing phy-mode and fixed-link to DSA switch ports

PATCH Applied Rosen Penev 2 participants 2 messages Jul 27 – Jul 30

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add missing phy-mode and fixed-link to DSA switch ports

Ports 5, 7 and 8 in the BCM5301x SRAB switch node carry an 'ethernet' property linking them to GMACs, but lack the required 'phy-mode' and 'fixed-link' properties. The DSA port schema (dsa-port.yaml) mandates that any port with an 'ethernet' property must also have 'phy-mode' and one of 'fixed-link', 'phy-handle', or 'managed'.

Add phy-mode = "internal" and a fixed-link subnode to ports 5, 7 and 8, matching the properties already present on their respective GMAC nodes (gmac0, gmac1, gmac2). This resolves dtbs_check schema validation warnings for all BCM5301x-based board DTBs.

Assisted-by Opencode:Big-Pickle
---
 arch/arm/boot/dts/broadcom/bcm-ns.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/arm/boot/dts/broadcom/bcm-ns.dtsi +13 -0
index 27a97c8122de..609f56ab936c 100644
@@ -439,16 +439,29 @@ port@4 {
 			port@5 {
 				reg = <5>;
 				ethernet = <&gmac0>;
+				phy-mode = "internal";
+
+				fixed-link {
+					speed = <1000>;
+					full-duplex;
+				};
 			};
 
 			port@7 {
 				reg = <7>;
 				ethernet = <&gmac1>;
+				phy-mode = "internal";
+
+				fixed-link {
+					speed = <1000>;
+					full-duplex;
+				};
 			};
 
 			port@8 {
 				reg = <8>;
 				ethernet = <&gmac2>;
+				phy-mode = "internal";
 
 				fixed-link {
 					speed = <1000>;
Signature · 1 line
2.55.0
maintainer Applied
#1 lore raw

From: Florian Fainelli <[email protected]>

Quoted 6 lines · Rosen Penev

Ports 5, 7 and 8 in the BCM5301x SRAB switch node carry an 'ethernet' property linking them to GMACs, but lack the required 'phy-mode' and 'fixed-link' properties. The DSA port schema (dsa-port.yaml) mandates that any port with an 'ethernet' property must also have 'phy-mode' and one of 'fixed-link', 'phy-handle', or 'managed'.

Quoted 8 lines

Add phy-mode = "internal" and a fixed-link subnode to ports 5, 7 and 8, matching the properties already present on their respective GMAC nodes (gmac0, gmac1, gmac2). This resolves dtbs_check schema validation warnings for all BCM5301x-based board DTBs.

Assisted-by Opencode:Big-Pickle

---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! --
Florian