hw/nvme: fix unintentional integer overflow in shift
PATCH v2 1/1 hw/nvme: fix unintentional integer overflow in shift
From: Klaus Jensen <[email protected]>
Fix potentially overflowing shift operation.
Resolves: Coverity CID 1663674
---
Changes in v2:
- use deposit64
- Link to v1: https://lore.kernel.org/qemu-devel/[email protected]
--- hw/nvme/ctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
hw/nvme/ctrl.c +2 -1
@@ -6622,7 +6622,8 @@ static uint16_t nvme_set_feature_fdp_events(NvmeCtrl *n, NvmeNamespace *ns,if (!shift && event_type) {continue ; } - event_mask |= (1 << nvme_fdp_evf_shifts[events[i]]); + event_mask = +deposit64 (event_mask, nvme_fdp_evf_shifts[events[i]],1 ,1 ); }if (enable) {
---
base-commit: 299e7557ed15a9a325620698add379a3ce2d1d95
change-id: 20260728-fix-shift-525e53c1df6f
Best regards,
Signature · 1 line
Klaus Jensen <[email protected]>
Quoted 10 lines · Klaus Jensen
From: Klaus Jensen <[email protected]>
Fix potentially overflowing shift operation.
Suggested-by Peter Maydell <[email protected]>Suggested-by Philippe Mathieu-Daudé <[email protected]>Resolves: Coverity CID 1663674
Fixes ec917cd49918 ("hw/nvme: fix FDP set FDP events")Signed-off-by Klaus Jensen <[email protected]>
Quoted 7 lines
---
Changes in v2:
- use deposit64
- Link to v1: https://lore.kernel.org/qemu-devel/[email protected]--- hw/nvme/ctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Please include "qemu/bitops.h" when applying (it is indirectly included but we rather explicit includes otherwise refactoring unrelated headers might break here), otherwise:
Quoted 19 lines · Philippe Mathieu-Daudé
Quoted 10 lines · Klaus Jensen
From: Klaus Jensen <[email protected]>
Fix potentially overflowing shift operation.
Suggested-by Peter Maydell <[email protected]>Suggested-by Philippe Mathieu-Daudé <[email protected]>Resolves: Coverity CID 1663674
Fixes ec917cd49918 ("hw/nvme: fix FDP set FDP events")Signed-off-by Klaus Jensen <[email protected]>Quoted 7 lines
---
Changes in v2:
- use deposit64
- Link to v1: https://lore.kernel.org/qemu-devel/[email protected]--- hw/nvme/ctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 4 lines
Please include "
qemu/bitops.h" when applying (it is indirectly included but we rather explicit includes otherwise refactoring unrelated headers might break here), otherwise:
Gotcha.
Quoted 2 lines
Reviewed-by Philippe Mathieu-Daudé <[email protected]>