Skip to contentSkip to conversation

drbd: fix typo in comment

PATCH NAK Guo Tenglong 2 participants 4 messages Jul 28 – Aug 10

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drbd: fix typo in comment

Correct "seperate" to "separate" in a comment.

---
 drivers/block/drbd/drbd_state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/drbd/drbd_state.c +1 -1
index adcba7f1d..98abd2351 100644
@@ -1339,7 +1339,7 @@ _drbd_set_state(struct drbd_device *device, union drbd_state ns,
 
 	remember_new_state(state_change);
 
-	/* put replicated vs not-replicated requests in seperate epochs */
+	/* put replicated vs not-replicated requests in separate epochs */
 	if (drbd_should_do_remote((union drbd_dev_state)os.i) !=
 	    drbd_should_do_remote((union drbd_dev_state)ns.i))
 		start_new_tl_epoch(connection);
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 drm/radeon: fix typo in comments

Correct "sucess" to "success" in function comments.

---
 drivers/gpu/drm/radeon/radeon_device.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/radeon/radeon_device.c +3 -3
index 705c012fc..fb79c990a 100644
@@ -777,7 +777,7 @@ bool radeon_boot_test_post_card(struct radeon_device *rdev)
  * Allocate the dummy page used by the driver (all asics).
  * This dummy page is used by the driver as a filler for gart entries
  * when pages are taken out of the GART
- * Returns 0 on sucess, -ENOMEM on failure.
+ * Returns 0 on success, -ENOMEM on failure.
  */
 int radeon_dummy_page_init(struct radeon_device *rdev)
 {
@@ -969,7 +969,7 @@ static uint32_t cail_ioreg_read(struct card_info *info, uint32_t reg)
  *
  * Initializes the driver info and register access callbacks for the
  * ATOM interpreter (r4xx+).
- * Returns 0 on sucess, -ENOMEM on failure.
+ * Returns 0 on success, -ENOMEM on failure.
  * Called at driver startup.
  */
 int radeon_atombios_init(struct radeon_device *rdev)
@@ -1045,7 +1045,7 @@ void radeon_atombios_fini(struct radeon_device *rdev)
  * @rdev: radeon_device pointer
  *
  * Initializes the driver info for combios (r1xx-r3xx).
- * Returns 0 on sucess.
+ * Returns 0 on success.
  * Called at driver startup.
  */
 int radeon_combios_init(struct radeon_device *rdev)
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH] drm/radeon: fix typo in comments

Am 28.07.26 um 11:05 schrieb Guo Tenglong:

Quoted 30 lines

Correct "sucess" to "success" in function comments.

---
 drivers/gpu/drm/radeon/radeon_device.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/radeon/radeon_device.c +2 -2
index 705c012fc..fb79c990a 100644
@@ -777,7 +777,7 @@ bool radeon_boot_test_post_card(struct radeon_device *rdev)
  * Allocate the dummy page used by the driver (all asics).
  * This dummy page is used by the driver as a filler for gart entries
  * when pages are taken out of the GART
- * Returns 0 on sucess, -ENOMEM on failure.
+ * Returns 0 on success, -ENOMEM on failure.
  */
 int radeon_dummy_page_init(struct radeon_device *rdev)
 {
@@ -969,7 +969,7 @@ static uint32_t cail_ioreg_read(struct card_info *info, uint32_t reg)
  *
  * Initializes the driver info and register access callbacks for the
  * ATOM interpreter (r4xx+).
- * Returns 0 on sucess, -ENOMEM on failure.
+ * Returns 0 on success, -ENOMEM on failure.
  * Called at driver startup.
  */
 int radeon_atombios_init(struct radeon_device *rdev)

drivers/gpu/drm/radeon/radeon_device.c void radeon_atombios_fini(struct radeon_device *rdev) · line 1051

Quoted 8 lines
drivers/gpu/drm/radeon/radeon_device.c +1 -1
@@ -1045,7 +1045,7 @@ void radeon_atombios_fini(struct radeon_device *rdev)
  * @rdev: radeon_device pointer
  *
  * Initializes the driver info for combios (r1xx-r3xx).
- * Returns 0 on sucess.
+ * Returns 0 on success.
  * Called at driver startup.
  */
 int radeon_combios_init(struct radeon_device *rdev)

This seems to have been sent to the wrong maintainers. But I suspect they would have the same reasoning as me about the usefulness of these fixes.

Signature · 3 lines
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA —  Disaster Recovery — Software defined Storage
maintainer NAK
#3 lore raw
In reply to Guo Tenglong

Am 28.07.26 um 11:05 schrieb Guo Tenglong:

Quoted 12 lines

Correct "seperate" to "separate" in a comment.

---
 drivers/block/drbd/drbd_state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/drbd/drbd_state.c +0 -0
index adcba7f1d..98abd2351 100644

drivers/block/drbd/drbd_state.c _drbd_set_state(struct drbd_device *device, union drbd_state ns, · line 1345

Quoted 8 lines
drivers/block/drbd/drbd_state.c +1 -1
@@ -1339,7 +1339,7 @@ _drbd_set_state(struct drbd_device *device, union drbd_state ns,
 
 	remember_new_state(state_change);
 
-	/* put replicated vs not-replicated requests in seperate epochs */
+	/* put replicated vs not-replicated requests in separate epochs */
 	if (drbd_should_do_remote((union drbd_dev_state)os.i) !=
 	    drbd_should_do_remote((union drbd_dev_state)ns.i))
 		start_new_tl_epoch(connection);

Thanks for the patch.
Typo fixes like this are generally only worth it if they come with a "real" fix in the same general reason. On their own, they just cause more work for the maintainers involved with no real benefit -- especially in this case, where I initially struggled to even see the difference.

NAK.

Signature · 3 lines
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA —  Disaster Recovery — Software defined Storage