staging: sm750fb: Align prototype parameter names to implementation
PATCH 1/1 staging: sm750fb: Align prototype parameter names to implementation
The declarations for sm750_hw_copyarea and sm750_hw_imageblit in sm750_accel.h use legacy CamelCase parameters, which do not match the snake_case names in the actual implementation in sm750_accel.c. The de_copyarea and de_imageblit function pointers in struct lynx_accel (sm750.h) also use outdated parameter names.
Rename these prototype parameters to match their implementation names.
--- drivers/staging/sm750fb/sm750.h | 10 +++++----- drivers/staging/sm750fb/sm750_accel.h | 12 ++++++------ 2 files changed, 11 insertions(+), 11 deletions(-)
drivers/staging/sm750fb/sm750.h +5 -5
@@ -57,17 +57,17 @@ struct lynx_accel { u32 color, u32 rop);int (*de_copyarea)(struct lynx_accel *accel, -u32 s_base,u32 s_pitch, +u32 source_base,u32 source_pitch,u32 sx,u32 sy, -u32 d_base,u32 d_pitch, +u32 dest_base,u32 dest_pitch,u32 bpp,u32 dx,u32 dy,u32 width,u32 height,u32 rop2); -int (*de_imageblit)(struct lynx_accel *accel,const char *p_srcbuf, -u32 src_delta,u32 start_bit,u32 d_base,u32 d_pitch, +int (*de_imageblit)(struct lynx_accel *accel,const char *src_buf, +u32 src_delta,u32 start_bit,u32 dest_base,u32 dest_pitch,u32 byte_per_pixel,u32 dx,u32 dy,u32 width, -u32 height,u32 f_color,u32 b_color,u32 rop2); +u32 height,u32 fg_color,u32 bg_color,u32 rop2); };
drivers/staging/sm750fb/sm750_accel.h +6 -6
@@ -210,9 +210,9 @@ int sm750_hw_fillrect(struct lynx_accel *accel,* @rop2: ROP value */ int sm750_hw_copyarea (struct lynx_accel *accel, -unsigned int sBase,unsigned int sPitch, +unsigned int source_base,unsigned int source_pitch,unsigned int sx,unsigned int sy, -unsigned int dBase,unsigned int dPitch, +unsigned int dest_base,unsigned int dest_pitch,unsigned int bpp,unsigned int dx,unsigned int dy,unsigned int width,unsigned int height,unsigned int rop2);
@@ -235,9 +235,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel,* @bColor: Background color (corresponding to a 0 in the monochrome data * @rop2: ROP value */ -int sm750_hw_imageblit (struct lynx_accel *accel,const char *pSrcbuf, -u32 srcDelta,u32 startBit,u32 dBase,u32 dPitch, -u32 bytePerPixel,u32 dx,u32 dy,u32 width, -u32 height,u32 fColor,u32 bColor,u32 rop2); +int sm750_hw_imageblit (struct lynx_accel *accel,const char *src_buf, +u32 src_delta,u32 start_bit,u32 dest_base,u32 dest_pitch, +u32 byte_per_pixel,u32 dx,u32 dy,u32 width, +u32 height,u32 fg_color,u32 bg_color,u32 rop2);#endif
Signature · 1 line
2.43.0
Greg Kroah-Hartman
maintainerQuoted 6 lines · Mohit Mishra
The declarations for
sm750_hw_copyareaandsm750_hw_imageblitinsm750_accel.huse legacy CamelCase parameters, which do not match thesnake_casenames in the actual implementation insm750_accel.c. Thede_copyareaandde_imageblitfunction pointers in structlynx_accel(sm750.h) also use outdated parameter names.
Quoted 7 lines
Rename these prototype parameters to match their implementation names.
Signed-off-by Mohit Mishra <[email protected]>--- drivers/staging/sm750fb/sm750.h | 10 +++++----- drivers/staging/sm750fb/sm750_accel.h | 12 ++++++------ 2 files changed, 11 insertions(+), 11 deletions(-)
Does not apply to the staging-testing branch :(