Skip to contentSkip to conversation

drm/amdgpu/gmc12.1: fix MMHUB0 check in pasid tlb flush

PATCH In review Alex Deucher 3 participants 4 messages Jul 28 – Aug 4

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu/gmc12.1: fix MMHUB0 check in pasid tlb flush

Check for mmhub0 rather than mmhub1. Looks like a copy paste typo.

Fixes d0c989a0aad3 ("drm/amd/amdgpu : Use the MES INV_TLBS API for tlb invalidation on gfx12_1")
Cc Shaoyun Liu <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c +1 -1
index 855cd29cbffaa..54a5e64f53b3b 100644
@@ -396,7 +396,7 @@ static void gmc_v12_1_flush_gpu_tlb_pasid(struct amdgpu_device *adev,
 
 		if (all_hub) {
 			/* invalidate mm_hub */
-			if (test_bit(AMDGPU_MMHUB1(0), adev->vmhubs_mask)) {
+			if (test_bit(AMDGPU_MMHUB0(0), adev->vmhubs_mask)) {
 				input.hub_id = AMDGPU_MMHUB0(0);
 				adev->mes.funcs->invalidate_tlbs_pasid(&adev->mes, &input);
 			}
Signature · 1 line
2.55.0
#1 lore raw

Ping?

Quoted 27 lines · Alex Deucher

Check for mmhub0 rather than mmhub1. Looks like a copy paste typo.

Fixes d0c989a0aad3 ("drm/amd/amdgpu : Use the MES INV_TLBS API for tlb invalidation on gfx12_1")
Cc Shaoyun Liu <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c +1 -2
index 855cd29cbffaa..54a5e64f53b3b 100644
@@ -396,7 +396,7 @@ static void gmc_v12_1_flush_gpu_tlb_pasid(struct amdgpu_device *adev,
 
                if (all_hub) {
                        /* invalidate mm_hub */
-                       if (test_bit(AMDGPU_MMHUB1(0), adev->vmhubs_mask)) {
+                       if (test_bit(AMDGPU_MMHUB0(0), adev->vmhubs_mask)) {
                                input.hub_id = AMDGPU_MMHUB0(0);
                                adev->mes.funcs->invalidate_tlbs_pasid(&adev->mes, &input);
                        }
--

2.55.0

#2 lore raw

Gentle ping?

Quoted 31 lines · Alex Deucher

Ping?

Quoted 27 lines · Alex Deucher

Check for mmhub0 rather than mmhub1. Looks like a copy paste typo.

Fixes d0c989a0aad3 ("drm/amd/amdgpu : Use the MES INV_TLBS API for tlb invalidation on gfx12_1")
Cc Shaoyun Liu <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c +1 -2
index 855cd29cbffaa..54a5e64f53b3b 100644
@@ -396,7 +396,7 @@ static void gmc_v12_1_flush_gpu_tlb_pasid(struct amdgpu_device *adev,
 
                if (all_hub) {
                        /* invalidate mm_hub */
-                       if (test_bit(AMDGPU_MMHUB1(0), adev->vmhubs_mask)) {
+                       if (test_bit(AMDGPU_MMHUB0(0), adev->vmhubs_mask)) {
                                input.hub_id = AMDGPU_MMHUB0(0);
                                adev->mes.funcs->invalidate_tlbs_pasid(&adev->mes, &input);
                        }
--

2.55.0

#3 lore raw

AMD General

Thanks to catch this .

RB : Shaoyun.liu <[email protected]>

Regards
Shaoyun.liu

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Tuesday, August 4, 2026 10:12 AM
To: Deucher, Alexander <[email protected]>
Cc: [email protected]; Liu, Shaoyun <[email protected]>
Subject: Re: [PATCH] drm/amdgpu/gmc12.1: fix MMHUB0 check in pasid tlb flush

Gentle ping?

Quoted 34 lines · Alex Deucher

Ping?

Quoted 30 lines · Alex Deucher

Check for mmhub0 rather than mmhub1. Looks like a copy paste typo.

Fixes d0c989a0aad3 ("drm/amd/amdgpu : Use the MES INV_TLBS API for

tlb invalidation on gfx12_1")

---
 drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gmc_v12_1.c +2 -2
index 855cd29cbffaa..54a5e64f53b3b 100644
@@ -396,7 +396,7 @@ static void gmc_v12_1_flush_gpu_tlb_pasid(struct
 amdgpu_device *adev,
 
                if (all_hub) {
                        /* invalidate mm_hub */
-                       if (test_bit(AMDGPU_MMHUB1(0), adev->vmhubs_mask)) {
+                       if (test_bit(AMDGPU_MMHUB0(0),
+ adev->vmhubs_mask)) {
                                input.hub_id = AMDGPU_MMHUB0(0);
                                adev->mes.funcs->invalidate_tlbs_pasid(&adev->mes, &input);
                        }
--

2.55.0