FAILED: patch "[PATCH] ipmi: fix refcount leak in i_ipmi_request()" failed to apply to 6.6-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 6.6-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y
git checkout FETCH_HEAD
git cherry-pick -x a3f3859cecacb64f18fd446271ece9a3b3f2d4de
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026072152-astute-spore-9b56@gregkh' --subject-prefix 'PATCH 6.6.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From a3f3859cecacb64f18fd446271ece9a3b3f2d4de Mon Sep 17 00:00:00 2001
From: Wentao Liang <[email protected]>
Date: Wed, 3 Jun 2026 12:06:34 +0000
Subject: [PATCH] ipmi: fix refcount leak in i_ipmi_request()
When a caller provides a supplied_recv message to i_ipmi_request(), the function increments the user's nr_msgs reference count. If an error occurs later, the out_err cleanup path only frees the recv_msg if the function allocated it itself (i.e., !supplied_recv). In the supplied_recv case the cleanup is skipped, leaving the reference count elevated. The caller ipmi_request_supply_msgs() does not release the supplied_recv on error, so the reference is permanently leaked.
Fix this by explicitly reverting the reference count operations when a supplied recv_msg with a valid user pointer is present in the error
path: decrement nr_msgs and drop the user's kref.
Message-ID: <[email protected]>
drivers/char/ipmi/ipmi_msghandler.c +8 -0
@@ -2345,6 +2345,10 @@ static int i_ipmi_request(struct ipmi_user *user,if (smi_msg ==NULL ) {if (!supplied_recv)ipmi_free_recv_msg (recv_msg); +else if (recv_msg->user) { +atomic_dec (&recv_msg->user->nr_msgs); +kref_put (&recv_msg->user->refcount, free_ipmi_user); + }return -ENOMEM ; } }
@@ -2418,6 +2422,10 @@ static int i_ipmi_request(struct ipmi_user *user,ipmi_free_smi_msg (smi_msg);if (!supplied_recv)ipmi_free_recv_msg (recv_msg); +else if (recv_msg->user) { +atomic_dec (&recv_msg->user->nr_msgs); +kref_put (&recv_msg->user->refcount, free_ipmi_user); + } }return rv; }
Sasha Levin
maintainerPATCH 1/1 ipmi: fix refcount leak in i_ipmi_request()
From: Wentao Liang <[email protected]>
[ Upstream commit a3f3859cecacb64f18fd446271ece9a3b3f2d4de ]
When a caller provides a supplied_recv message to i_ipmi_request(), the function increments the user's nr_msgs reference count. If an error occurs later, the out_err cleanup path only frees the recv_msg if the function allocated it itself (i.e., !supplied_recv). In the supplied_recv case the cleanup is skipped, leaving the reference count elevated. The caller ipmi_request_supply_msgs() does not release the supplied_recv on error, so the reference is permanently leaked.
Fix this by explicitly reverting the reference count operations when a supplied recv_msg with a valid user pointer is present in the error
path: decrement nr_msgs and drop the user's kref.
Message-ID: <[email protected]>
--- drivers/char/ipmi/ipmi_msghandler.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/char/ipmi/ipmi_msghandler.c +8 -0
@@ -2331,6 +2331,10 @@ static int i_ipmi_request(struct ipmi_user *user,if (smi_msg ==NULL ) {if (!supplied_recv)ipmi_free_recv_msg (recv_msg); +else if (recv_msg->user) { +atomic_dec (&recv_msg->user->nr_msgs); +kref_put (&recv_msg->user->refcount, free_user); + }return -ENOMEM ; } }
@@ -2373,6 +2377,10 @@ static int i_ipmi_request(struct ipmi_user *user,ipmi_free_smi_msg (smi_msg);if (!supplied_recv)ipmi_free_recv_msg (recv_msg); +else if (recv_msg->user) { +atomic_dec (&recv_msg->user->nr_msgs); +kref_put (&recv_msg->user->refcount, free_user); + } }else {dev_dbg (intf->si_dev,"Send: %*ph\n" , smi_msg->data_size, smi_msg->data);
Signature · 1 line
2.53.0