arm64: dts: freescale: fix reserved memory node names for remoteproc
Subsystems (2)
v2 cover arm64: dts: freescale: fix reserved memory node names for remoteproc
The imx_rproc driver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions. Several i.MX board dts files used incorrect node names (e.g. "vdevbuffer", "memory-rsc-table", "memory@..."), causing the driver to fail these checks.
This series renames the reserved memory nodes across all affected boards to use the expected names.
---
Changes in v2:
- Also fix vring, rsc-table, and dsp buffer node names in imx8dxl-evk, imx8qm-mek, imx8qxp-mek
- Add fixes for imx8dxl-sr-som, imx93-11x11-evk, imx95-15x15-frdm
- Update commit messages to reflect expanded scope
- Link to v1: https://patch.msgid.link/[email protected]
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Conor Dooley <[email protected]>
To: Frank Li <[email protected]>
To: Sascha Hauer <[email protected]>
To: Pengutronix Kernel Team <[email protected]>
To: Fabio Estevam <[email protected]>
To: Peng Fan <[email protected]>
Cc: Laurentiu Mihalcea <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Peng Fan (12):
arm64: dts: imx8dxl-evk: fix reserved memory node names for remoteproc
arm64: dts: imx8qm-mek: fix reserved memory node names for remoteproc
arm64: dts: imx8qm-mek: fix dsp reserved memory node names for remoteproc
arm64: dts: imx8qxp-mek: fix reserved memory node names for remoteproc
arm64: dts: imx8qxp-mek: fix dsp reserved memory node names for remoteproc
arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc
arm64: dts: imx93-11x11-frdm: fix reserved memory node names for remoteproc
arm64: dts: imx93-14x14-evk: fix reserved memory node names for remoteproc
arm64: dts: imx93-9x9-qsb: fix reserved memory node names for remoteproc
arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc
arm64: dts: imx93-11x11-evk: fix reserved memory node names for remoteproc
arm64: dts: imx95-15x15-frdm: fix reserved memory node names for remoteproc
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 14 +++++----- arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi | 14 +++++----- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 32 +++++++++++----------- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 20 +++++++------- arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 4 +-- .../boot/dts/freescale/imx93-11x11-evk-common.dtsi | 4 +-- arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts | 4 +-- arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts | 4 +-- arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts | 4 +-- arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts | 12 ++++---- 10 files changed, 56 insertions(+), 56 deletions(-)
---
base-commit: 0d33d21e47d9dc66f91e44da3fc9220c74d93df7
change-id: 20260728-rproc-dts-3f331df7ceaa
Best regards,
Signature · 1 line
Peng Fan <[email protected]>
PATCH v2 1/12 arm64: dts: imx8dxl-evk: fix reserved memory node names for remoteproc
From: Peng Fan <[email protected]>
The imx_rproc driver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions.
Rename the reserved memory nodes to use the expected names so the driver can correctly identify and handle each region.
--- arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts +7 -7
@@ -29,7 +29,7 @@ imx8dxl-cm4 { clocks = <&clk_dummy>; mbox-names = "tx", "rx", "rxdb"; mboxes = <&lsio_mu5 0 1 &lsio_mu5 1 1 &lsio_mu5 3 1>; - memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>; power-domains = <&pd IMX_SC_R_M4_0_PID0>, <&pd IMX_SC_R_M4_0_MU_1A>; fsl,resource-id = <IMX_SC_R_M4_0_PID0>;
@@ -65,32 +65,32 @@ linux,cma { linux,cma-default; }; - vdev0vring0: memory0@90000000 { + vdev0vring0: vdev0vring0@90000000 { reg = <0 0x90000000 0 0x8000>; no-map; }; - vdev0vring1: memory@90008000 { + vdev0vring1: vdev0vring1@90008000 { reg = <0 0x90008000 0 0x8000>; no-map; }; - vdev1vring0: memory@90010000 { + vdev1vring0: vdev1vring0@90010000 { reg = <0 0x90010000 0 0x8000>; no-map; }; - vdev1vring1: memory@90018000 { + vdev1vring1: vdev1vring1@90018000 { reg = <0 0x90018000 0 0x8000>; no-map; }; - rsc_table: memory-rsc-table@900ff000 { + rsc_table: rsc-table@900ff000 { reg = <0 0x900ff000 0 0x1000>; no-map; }; - vdevbuffer: memory-vdevbuffer@90400000 { + vdev0buffer: vdev0buffer@90400000 { compatible = "shared-dma-pool"; reg = <0 0x90400000 0 0x100000>; no-map;
Signature · 1 line
2.34.1
[email protected]
AI reviewRe: [PATCH v2 01/12] arm64: dts: imx8dxl-evk: fix reserved memory node names for remoteproc
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
New issues:
- [Medium] The newly introduced reserved-memory node names violate Devicetree naming conventions and schema.
Pre-existing issues:
- [High] Incomplete fix leaving remoteproc broken on sibling i.MX device trees. --
--- Patch [1]: [PATCH v2 01/12] arm64: dts: imx8dxl-evk: fix reserved memory node names for remoteproc --- commit e2a2dbe393a11711fef30985552292a1360dcdae
Author: Peng Fan <[email protected]>
arm64: dts: imx8dxl-evk: fix reserved memory node names for remoteproc
The imx_rproc driver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions.
Rename the reserved memory nodes to use the expected names so the driver can correctly identify and handle each region.
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts +0
-0
[Severity: High]
This isn't a bug introduced by this patch, but does this leave remoteproc broken on sibling i.MX device trees?
When the imx_rproc driver calls of_reserved_mem_region_to_resource(), it expects res.name to start with vdev or rsc-table. Unconditionally on boot, other i.MX boards still use generic memory@... node names. For example, in arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi under reserved-memory:
vdev0vring0: memory0@90000000 {
And similarly in arch/arm64/boot/dts/freescale/imx8qm-mek.dts:
vdev0vring0: memory@90000000 {
Could these sibling device trees be updated as well so virtio rings and buffers are mapped correctly instead of as regular memory carveouts?
[ ... ]
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts linux,cma { · line 68
Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts +1
-1@@ -65,32 +65,32 @@ linux,cma { linux,cma-default; }; - vdev0vring0: memory0@90000000 { + vdev0vring0: vdev0vring0@90000000 {
[Severity: Medium]
Do these new reserved-memory node names violate Devicetree naming conventions and schema validation?
Building the device tree with schema validation enabled triggers dtbs_check warnings because nodes like vdev0vring0@90000000 violate the strict reserved-memory regex: ^([a-z0-9-]+-)?(memory|sram|ram)(@[0-9a-f]+)?$
The underlying driver code in drivers/remoteproc/imx_rproc.c enforces this via hardcoded string matching:
imx_rproc_addr_init() {
...
if (strstarts(res.name, "vdev"))
continue;
...
}Could the node names append -memory (e.g., vdev0vring0-memory@90000000) to satisfy both the schema's optional prefix and the driver's strstarts() checks?
Alternatively, could the driver be updated to use memory-region-names via of_reserved_mem_region_to_resource_byname() while keeping the generic memory node names?
[ ... ]
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
PATCH v2 2/12 arm64: dts: imx8qm-mek: fix reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_rproc driver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions.
Rename the reserved memory nodes to use the expected names so the driver can correctly identify and handle each region.
--- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)
arch/arm64/boot/dts/freescale/imx8qm-mek.dts +13 -13
@@ -44,57 +44,57 @@ reserved-memory { #size-cells = <2>; ranges; - vdev0vring0: memory@90000000 { + vdev0vring0: vdev0vring0@90000000 { reg = <0 0x90000000 0 0x8000>; no-map; }; - vdev0vring1: memory@90008000 { + vdev0vring1: vdev0vring1@90008000 { reg = <0 0x90008000 0 0x8000>; no-map; }; - vdev1vring0: memory@90010000 { + vdev1vring0: vdev1vring0@90010000 { reg = <0 0x90010000 0 0x8000>; no-map; }; - vdev1vring1: memory@90018000 { + vdev1vring1: vdev1vring1@90018000 { reg = <0 0x90018000 0 0x8000>; no-map; }; - rsc_table0: memory@900ff000 { + rsc_table0: rsc-table@900ff000 { reg = <0 0x900ff000 0 0x1000>; no-map; }; - vdev2vring0: memory@90100000 { + vdev2vring0: vdev2vring0@90100000 { reg = <0 0x90100000 0 0x8000>; no-map; }; - vdev2vring1: memory@90108000 { + vdev2vring1: vdev2vring1@90108000 { reg = <0 0x90108000 0 0x8000>; no-map; }; - vdev3vring0: memory@90110000 { + vdev3vring0: vdev3vring0@90110000 { reg = <0 0x90110000 0 0x8000>; no-map; }; - vdev3vring1: memory@90118000 { + vdev3vring1: vdev3vring1@90118000 { reg = <0 0x90118000 0 0x8000>; no-map; }; - rsc_table1: memory@901ff000 { + rsc_table1: rsc-table@901ff000 { reg = <0 0x901ff000 0 0x1000>; no-map; }; - vdevbuffer: memory@90400000 { + vdev0buffer: vdev0buffer@90400000 { compatible = "shared-dma-pool"; reg = <0 0x90400000 0 0x100000>; no-map;
@@ -456,7 +456,7 @@ imx8qm-cm4-0 { mboxes = <&lsio_mu5 0 1 &lsio_mu5 1 1 &lsio_mu5 3 1>; - memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&vdev1vring0>, <&vdev1vring1>, <&rsc_table0>; power-domains = <&pd IMX_SC_R_M4_0_PID0>, <&pd IMX_SC_R_M4_0_MU_1A>;
@@ -471,7 +471,7 @@ imx8qm-cm4-1 { mboxes = <&lsio_mu6 0 1 &lsio_mu6 1 1 &lsio_mu6 3 1>; - memory-region = <&vdevbuffer>, <&vdev2vring0>, <&vdev2vring1>, + memory-region = <&vdev0buffer>, <&vdev2vring0>, <&vdev2vring1>, <&vdev3vring0>, <&vdev3vring1>, <&rsc_table1>; power-domains = <&pd IMX_SC_R_M4_1_PID0>, <&pd IMX_SC_R_M4_1_MU_1A>;
Signature · 1 line
2.34.1
[email protected]
AI reviewRe: [PATCH v2 02/12] arm64: dts: imx8qm-mek: fix reserved memory node names for remoteproc
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Pre-existing issues:
- [High] Renaming the vring memory nodes for cm4-1 to vdev2vring0 and vdev3vring0 breaks static vring matching in the remoteproc core, causing a fallback to dynamic allocation and breaking IPC.
- [High] The DSP's vdev buffer and vring nodes in imx8qm-mek.dts were missed during the rename, leaving them with the generic memory node name, which breaks the driver's memory region parsing and IPC. --
--- Patch [2]: [PATCH v2 02/12] arm64: dts: imx8qm-mek: fix reserved memory node names for remoteproc --- commit b33c57fd7f12629e7e4a66a20b899d545ad3c226
Author: Peng Fan <[email protected]>
arm64: dts: imx8qm-mek: fix reserved memory node names for remoteproc
The imx_rproc driver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions.
Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8qm-mek.dts +0
-0@@ -44,57 +44,57 @@ reserved-memory { #size-cells = <2>; ranges;
[ ... ]
arch/arm64/boot/dts/freescale/imx8qm-mek.dts reserved-memory { · line 72
Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8qm-mek.dts +1
-1- vdev2vring0: memory@90100000 { + vdev2vring0: vdev2vring0@90100000 {
[Severity: High]
This isn't a bug introduced by this patch, but will this renaming actually work for the cm4-1 remoteproc instance?
Since imx8qm-cm4-1 is an independent rproc instance, its first virtio device index is 0. Looking at the remoteproc core, rproc_alloc_vring() searches for vring carveouts using the format string "vdev%dvring%d".
Because of this, won't the core search for "vdev0vring0" and "vdev0vring1" instead of "vdev2vring0"? If so, the mismatch would cause rproc_alloc_vring() to fail finding the carveout and fall back to dynamic allocation, potentially breaking IPC.
arch/arm64/boot/dts/freescale/imx8qm-mek.dts reserved-memory { · line 75
Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8qm-mek.dts +0
-0reg = <0 0x90100000 0 0x8000>; no-map; };
[ ... ]
[Severity: High]
This is a pre-existing issue, but were the DSP vdev buffer and vring nodes missed during this rename?
Looking at dsp_vdev0buffer in the same file (which currently remains as memory@94300000), the imx_dsp_rproc driver will fail to skip the node because it evaluates strstarts(res.name, "vdev0buffer").
Since the node name remains "memory", won't remoteproc_virtio fall back to dynamic allocation from system memory and break IPC for the DSP?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
PATCH v2 3/12 arm64: dts: imx8qm-mek: fix dsp reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_dsp_rproc driver checks for the name "vdev0buffer" to skip mapping the vdev buffer region, as it is handled by rproc_add_virtio_dev. With the node named "memory", the check fails and the region gets unnecessarily mapped.
Rename the DSP reserved memory nodes to use proper names for consistency with other remoteproc reserved memory regions and to ensure the vdev0buffer check works correctly.
Rename the DSP reserved memory nodes to use the expected names so the driver can correctly identify and handle each region.
--- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8qm-mek.dts +3 -3
@@ -105,17 +105,17 @@ dsp_reserved: memory@92400000 { no-map; }; - dsp_vdev0vring0: memory@942f0000 { + dsp_vdev0vring0: vdev0vring0@942f0000 { reg = <0 0x942f0000 0 0x8000>; no-map; }; - dsp_vdev0vring1: memory@942f8000 { + dsp_vdev0vring1: vdev0vring1@942f8000 { reg = <0 0x942f8000 0 0x8000>; no-map; }; - dsp_vdev0buffer: memory@94300000 { + dsp_vdev0buffer: vdev0buffer@94300000 { compatible = "shared-dma-pool"; reg = <0 0x94300000 0 0x100000>; no-map;
Signature · 1 line
2.34.1
[email protected]
AI reviewRe: [PATCH v2 03/12] arm64: dts: imx8qm-mek: fix dsp reserved memory node names for remoteproc
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missing cancellation of rproc_work leads to Use-After-Free on driver unbind. --
--- Patch [3]: [PATCH v2 03/12] arm64: dts: imx8qm-mek: fix dsp reserved memory node names for remoteproc --- commit ccca82516c9f0cb91d5a0dd4d02b6d18ce2a6c7e
Author: Peng Fan <[email protected]>
arm64: dts: imx8qm-mek: fix dsp reserved memory node names for remoteproc
The imx_dsp_rproc driver checks for the name "vdev0buffer" to skip mapping the vdev buffer region, as it is handled by rproc_add_virtio_dev. With the node named "memory", the check fails and the region gets unnecessarily mapped.
Rename the DSP reserved memory nodes to use proper names for consistency with other remoteproc reserved memory regions and to ensure the vdev0buffer check works correctly.
Rename the DSP reserved memory nodes to use the expected names so the driver can correctly identify and handle each region.
Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8qm-mek.dts +0
-0
[ ... ]
arch/arm64/boot/dts/freescale/imx8qm-mek.dts dsp_reserved: memory@92400000 { · line 121
Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8qm-mek.dts +1
-1- dsp_vdev0buffer: memory@94300000 { + dsp_vdev0buffer: vdev0buffer@94300000 { compatible = "shared-dma-pool"; reg = <0 0x94300000 0 0x100000>; no-map;
[Severity: High]
This isn't a bug introduced by this patch, but is there a missing cancellation of rproc_work in the imx_dsp_rproc driver that could lead to a use-after-free on driver unbind?
In drivers/remoteproc/imx_dsp_rproc.c:imx_dsp_rproc_probe():
INIT_WORK(&priv->rproc_work, imx_dsp_rproc_vq_work);
And later in imx_dsp_rproc_rx_tx_callback(), the work is scheduled:
default: schedule_work(&priv->rproc_work); break;
Because the driver does not define a remove callback and relies entirely on devres cleanup, the work is never explicitly cancelled (e.g., via cancel_work_sync()).
During driver unbind, devm_rproc_alloc teardown will free the rproc structure, along with its embedded priv. If the scheduled work executes concurrently or is pending on the system workqueue, it will access the freed priv->rproc, leading to a use-after-free.
Could a devres action be added to properly flush and destroy this workqueue before the rproc is freed?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
PATCH v2 4/12 arm64: dts: imx8qxp-mek: fix reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_rproc driver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions.
Rename the reserved memory nodes to use the expected names so the driver can correctly identify and handle each region.
--- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +7 -7
@@ -27,7 +27,7 @@ imx8x_cm4: imx8x-cm4 { mboxes = <&lsio_mu5 0 1 &lsio_mu5 1 1 &lsio_mu5 3 1>; - memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>; power-domains = <&pd IMX_SC_R_M4_0_PID0>, <&pd IMX_SC_R_M4_0_MU_1A>;
@@ -242,32 +242,32 @@ reserved-memory { #size-cells = <2>; ranges; - vdev0vring0: memory@90000000 { + vdev0vring0: vdev0vring0@90000000 { reg = <0 0x90000000 0 0x8000>; no-map; }; - vdev0vring1: memory@90008000 { + vdev0vring1: vdev0vring1@90008000 { reg = <0 0x90008000 0 0x8000>; no-map; }; - vdev1vring0: memory@90010000 { + vdev1vring0: vdev1vring0@90010000 { reg = <0 0x90010000 0 0x8000>; no-map; }; - vdev1vring1: memory@90018000 { + vdev1vring1: vdev1vring1@90018000 { reg = <0 0x90018000 0 0x8000>; no-map; }; - rsc_table: memory@900ff000 { + rsc_table: rsc-table@900ff000 { reg = <0 0x900ff000 0 0x1000>; no-map; }; - vdevbuffer: memory@90400000 { + vdev0buffer: vdev0buffer@90400000 { compatible = "shared-dma-pool"; reg = <0 0x90400000 0 0x100000>; no-map;
Signature · 1 line
2.34.1
PATCH v2 5/12 arm64: dts: imx8qxp-mek: fix dsp reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_dsp_rproc driver checks for the name "vdev0buffer" to skip mapping the vdev buffer region, as it is handled by rproc_add_virtio_dev. With the node named "memory", the check fails and the region gets unnecessarily mapped.
Rename the DSP reserved memory nodes to use proper names for consistency with other remoteproc reserved memory regions and to ensure the vdev0buffer check works correctly.
Rename the DSP reserved memory nodes to use the expected names so the driver can correctly identify and handle each region.
--- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +3 -3
@@ -273,17 +273,17 @@ vdev0buffer: vdev0buffer@90400000 { no-map; }; - dsp_vdev0vring0: memory@942f0000 { + dsp_vdev0vring0: vdev0vring0@942f0000 { reg = <0 0x942f0000 0 0x8000>; no-map; }; - dsp_vdev0vring1: memory@942f8000 { + dsp_vdev0vring1: vdev0vring1@942f8000 { reg = <0 0x942f8000 0 0x8000>; no-map; }; - dsp_vdev0buffer: memory@94300000 { + dsp_vdev0buffer: vdev0buffer@94300000 { compatible = "shared-dma-pool"; reg = <0 0x94300000 0 0x100000>; no-map;
Signature · 1 line
2.34.1
PATCH v2 6/12 arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_rproc driver checks for the name "vdev0buffer" to skip mapping the vdev buffer region, as it is handled by rproc_add_virtio_dev. With the node named "vdevbuffer", the check fails and the region gets unnecessarily mapped. Rename it to "vdev0buffer" to match what the driver expects.
--- arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8ulp-evk.dts +2 -2
@@ -67,7 +67,7 @@ vdev1vring1: vdev1vring1@aff18000 { no-map; }; - vdevbuffer: vdevbuffer@a8400000 { + vdev0buffer: vdev0buffer@a8400000 { compatible = "shared-dma-pool"; reg = <0 0xa8400000 0 0x100000>; no-map;
@@ -126,7 +126,7 @@ &cm33 { mboxes = <&mu 0 1>, <&mu 1 1>, <&mu 3 1>; - memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>; status = "okay"; };
Signature · 1 line
2.34.1
[email protected]
AI reviewRe: [PATCH v2 06/12] arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [Medium] Incomplete fix: The patch resolves a bug where the vdev buffer is unnecessarily mapped by renaming the device tree node from vdevbuffer to vdev0buffer. However, this renaming was only applied to a subset of i.MX8 device trees, leaving the exact same bug unresolved in numerous other Freescale device trees (e.g., i.MX93, i.MX8MM). --
--- Patch [6]: [PATCH v2 06/12] arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc --- commit 1515907215de5459529c9efcc4af91b85ac7ba38
Author: Peng Fan <[email protected]>
arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc
This commit renames the vdevbuffer node to vdev0buffer in the imx8ulp-evk device tree. This prevents the imx_rproc driver from unnecessarily mapping the vdev buffer region during initialization.
arch/arm64/boot/dts/freescale/imx8ulp-evk.dts vdev1vring1: vdev1vring1@aff18000 { · line 70
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8ulp-evk.dts +1
-1@@ -67,7 +67,7 @@ vdev1vring1: vdev1vring1@aff18000 { no-map; }; - vdevbuffer: vdevbuffer@a8400000 { + vdev0buffer: vdev0buffer@a8400000 {
[Severity: Medium]
This is a pre-existing issue, but this patch only partially fixes the problem.
There are other Freescale device trees that still define the node as vdevbuffer, which will continue to trigger the unnecessary mapping in imx_rproc_prepare(). For example:
arch/arm64/boot/dts/freescale/imx93-11x11-evk-common.dtsi:
vdevbuffer: vdevbuffer@a4020000 {arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:
vdevbuffer: vdevbuffer@b8400000 {The driver uses a hardcoded string check:
drivers/remoteproc/imx_rproc.c:imx_rproc_prepare() {
...
if (strstarts(res.name, "vdev0buffer"))
continue;
...
}Should the nodes in the other affected device trees also be renamed, or could the driver check be updated to handle both names to prevent this issue across all boards?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
PATCH v2 7/12 arm64: dts: imx93-11x11-frdm: fix reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_rproc driver checks for the name "vdev0buffer" to skip mapping the vdev buffer region, as it is handled by rproc_add_virtio_dev. With the node named "vdevbuffer", the check fails and the region gets unnecessarily mapped. Rename it to "vdev0buffer" to match what the driver expects.
--- arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts +2 -2
@@ -114,7 +114,7 @@ vdev1vring1: vdev1vring1@a4018000 { no-map; }; - vdevbuffer: vdevbuffer@a4020000 { + vdev0buffer: vdev0buffer@a4020000 { compatible = "shared-dma-pool"; reg = <0 0xa4020000 0 0x100000>; no-map;
@@ -148,7 +148,7 @@ &cm33 { <&mu1 1 1>, <&mu1 3 1>; mbox-names = "tx", "rx", "rxdb"; - memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>; status = "okay"; };
Signature · 1 line
2.34.1
PATCH v2 8/12 arm64: dts: imx93-14x14-evk: fix reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_rproc driver checks for the name "vdev0buffer" to skip mapping the vdev buffer region, as it is handled by rproc_add_virtio_dev. With the node named "vdevbuffer", the check fails and the region gets unnecessarily mapped. Rename it to "vdev0buffer" to match what the driver expects.
--- arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts +2 -2
@@ -75,7 +75,7 @@ rsc_table: rsc-table@2021e000 { no-map; }; - vdevbuffer: vdevbuffer@a4020000 { + vdev0buffer: vdev0buffer@a4020000 { compatible = "shared-dma-pool"; reg = <0 0xa4020000 0 0x100000>; no-map;
@@ -222,7 +222,7 @@ &cm33 { mboxes = <&mu1 0 1>, <&mu1 1 1>, <&mu1 3 1>; - memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>; status = "okay"; };
Signature · 1 line
2.34.1
PATCH v2 9/12 arm64: dts: imx93-9x9-qsb: fix reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_rproc driver checks for the name "vdev0buffer" to skip mapping the vdev buffer region, as it is handled by rproc_add_virtio_dev. With the node named "vdevbuffer", the check fails and the region gets unnecessarily mapped. Rename it to "vdev0buffer" to match what the driver expects.
--- arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts +2 -2
@@ -76,7 +76,7 @@ rsc_table: rsc-table@2021e000 { no-map; }; - vdevbuffer: vdevbuffer@a4020000 { + vdev0buffer: vdev0buffer@a4020000 { compatible = "shared-dma-pool"; reg = <0 0xa4020000 0 0x100000>; no-map;
@@ -212,7 +212,7 @@ &cm33 { mboxes = <&mu1 0 1>, <&mu1 1 1>, <&mu1 3 1>; - memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>; status = "okay"; };
Signature · 1 line
2.34.1
PATCH v2 10/12 arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_rproc driver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions.
Rename the reserved memory nodes to use the expected names so the driver can correctly identify and handle each region.
--- arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi +7 -7
@@ -26,7 +26,7 @@ imx8dxl-cm4 { clocks = <&clk_dummy>; mboxes = <&lsio_mu5 0 1 &lsio_mu5 1 1 &lsio_mu5 3 1>; mbox-names = "tx", "rx", "rxdb"; - memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>; power-domains = <&pd IMX_SC_R_M4_0_PID0>, <&pd IMX_SC_R_M4_0_MU_1A>; fsl,entry-address = <0x34fe0000>;
@@ -103,32 +103,32 @@ linux,cma { linux,cma-default; }; - vdev0vring0: memory0@90000000 { + vdev0vring0: vdev0vring0@90000000 { reg = <0 0x90000000 0 0x8000>; no-map; }; - vdev0vring1: memory@90008000 { + vdev0vring1: vdev0vring1@90008000 { reg = <0 0x90008000 0 0x8000>; no-map; }; - vdev1vring0: memory@90010000 { + vdev1vring0: vdev1vring0@90010000 { reg = <0 0x90010000 0 0x8000>; no-map; }; - vdev1vring1: memory@90018000 { + vdev1vring1: vdev1vring1@90018000 { reg = <0 0x90018000 0 0x8000>; no-map; }; - rsc_table: memory-rsc-table@900ff000 { + rsc_table: rsc-table@900ff000 { reg = <0 0x900ff000 0 0x1000>; no-map; }; - vdevbuffer: memory-vdevbuffer@90400000 { + vdev0buffer: vdev0buffer@90400000 { compatible = "shared-dma-pool"; reg = <0 0x90400000 0 0x100000>; no-map;
Signature · 1 line
2.34.1
[email protected]
AI reviewRe: [PATCH v2 10/12] arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The patch replaces generic Device Tree node names with non-generic, specific names (e.g.…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch replaces generic Device Tree node names with non-generic, specific names (e.g., vdev0vring0@90000000) to satisfy hardcoded string matching in the imx_rproc driver. This violates the DT specification rule that node names should be generic. --
--- Patch [10]: [PATCH v2 10/12] arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc --- commit 1d32457a00ef15e201f5eccc0be6be161bf05b59
Author: Peng Fan <[email protected]>
arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc
This patch renames reserved memory nodes in the device tree to use specific names like vdev0vring0 to satisfy hardcoded string matches in the imx_rproc driver.
Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi +0
-0
[ ... ]
arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi linux,cma { · line 106
Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi +1
-1@@ -103,32 +103,32 @@ linux,cma { linux,cma-default; }; - vdev0vring0: memory0@90000000 { + vdev0vring0: vdev0vring0@90000000 {
[Severity: Low]
Does replacing generic node names with driver-specific names violate the Device Tree specification rule requiring generic node names?
The specification states that node names should be generic (e.g., memory@...) and reflect the hardware class, not a specific driver or programming model.
Could the imx_rproc driver be updated to use the standard memory-region-names property to identify these regions, rather than working around the driver's expectations by introducing non-generic node names into the DTS?
Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi +0
-0reg = <0 0x90000000 0 0x8000>; no-map; };
[ ... ]
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10
PATCH v2 11/12 arm64: dts: imx93-11x11-evk: fix reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_rproc driver checks for the name "vdev0buffer" to skip mapping the vdev buffer region, as it is handled by rproc_add_virtio_dev. With the node named "vdevbuffer", the check fails and the region gets unnecessarily mapped. Rename it to "vdev0buffer" to match what the driver expects.
--- arch/arm64/boot/dts/freescale/imx93-11x11-evk-common.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx93-11x11-evk-common.dtsi +2 -2
@@ -67,7 +67,7 @@ rsc_table: rsc-table@2021e000 { no-map; }; - vdevbuffer: vdevbuffer@a4020000 { + vdev0buffer: vdev0buffer@a4020000 { compatible = "shared-dma-pool"; reg = <0 0xa4020000 0 0x100000>; no-map;
@@ -170,7 +170,7 @@ &cm33 { mboxes = <&mu1 0 1>, <&mu1 1 1>, <&mu1 3 1>; - memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, + memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>; status = "okay"; };
Signature · 1 line
2.34.1
PATCH v2 12/12 arm64: dts: imx95-15x15-frdm: fix reserved memory node names for remoteproc
In reply to Peng Fan (OSS)From: Peng Fan <[email protected]>
The imx_rproc driver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions.
Rename the reserved memory nodes to use the expected names so the driver can correctly identify and handle each region.
--- arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts +6 -6
@@ -188,33 +188,33 @@ linux_cma: linux,cma { linux,cma-default; }; - vdev0vring0: memory@88000000 { + vdev0vring0: vdev0vring0@88000000 { reg = <0 0x88000000 0 0x8000>; no-map; }; - vdev0vring1: memory@88008000 { + vdev0vring1: vdev0vring1@88008000 { reg = <0 0x88008000 0 0x8000>; no-map; }; - vdev1vring0: memory@88010000 { + vdev1vring0: vdev1vring0@88010000 { reg = <0 0x88010000 0 0x8000>; no-map; }; - vdev1vring1: memory@88018000 { + vdev1vring1: vdev1vring1@88018000 { reg = <0 0x88018000 0 0x8000>; no-map; }; - vdevbuffer: memory@88020000 { + vdev0buffer: vdev0buffer@88020000 { compatible = "shared-dma-pool"; reg = <0 0x88020000 0 0x100000>; no-map; }; - rsc_table: memory@88220000 { + rsc_table: rsc-table@88220000 { reg = <0 0x88220000 0 0x1000>; no-map; };
Signature · 1 line
2.34.1
Quoted 10 lines · Peng Fan (OSS)
The
imx_rprocdriver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions. Several i.MX board dts files used incorrect node names (e.g. "vdevbuffer", "memory-rsc-table", "memory@..."), causing the driver to fail these checks.This series renames the reserved memory nodes across all affected boards to use the expected names.
Quoted 7 lines
Signed-off-by Peng Fan <[email protected]>---
Changes in v2:
- Also fix vring, rsc-table, and dsp buffer node names in imx8dxl-evk, imx8qm-mek, imx8qxp-mek
- Add fixes for imx8dxl-sr-som, imx93-11x11-evk, imx95-15x15-frdm
- Update commit messages to reflect expanded scope
- Link to v1: https://patch.msgid.link/[email protected]
I hope Laurentiu Mihalcea's
https://lore.kernel.org/imx/[email protected]/
move forwards, by use memory-region-names to fix these problem
Frank
Quoted 50 lines
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Conor Dooley <[email protected]>
To: Frank Li <[email protected]>
To: Sascha Hauer <[email protected]>
To: Pengutronix Kernel Team <[email protected]>
To: Fabio Estevam <[email protected]>
To: Peng Fan <[email protected]>
Cc: Laurentiu Mihalcea <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]---
Peng Fan (12):
arm64: dts: imx8dxl-evk: fix reserved memory node names for remoteproc
arm64: dts: imx8qm-mek: fix reserved memory node names for remoteproc
arm64: dts: imx8qm-mek: fix dsp reserved memory node names for remoteproc
arm64: dts: imx8qxp-mek: fix reserved memory node names for remoteproc
arm64: dts: imx8qxp-mek: fix dsp reserved memory node names for remoteproc
arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc
arm64: dts: imx93-11x11-frdm: fix reserved memory node names for remoteproc
arm64: dts: imx93-14x14-evk: fix reserved memory node names for remoteproc
arm64: dts: imx93-9x9-qsb: fix reserved memory node names for remoteproc
arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc
arm64: dts: imx93-11x11-evk: fix reserved memory node names for remoteproc
arm64: dts: imx95-15x15-frdm: fix reserved memory node names for remoteprocarch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 14 +++++----- arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi | 14 +++++----- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 32 +++++++++++----------- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 20 +++++++------- arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 4 +-- .../boot/dts/freescale/imx93-11x11-evk-common.dtsi | 4 +-- arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts | 4 +-- arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts | 4 +-- arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts | 4 +-- arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts | 12 ++++---- 10 files changed, 56 insertions(+), 56 deletions(-)---
base-commit:0d33d21e47d9dc66f91e44da3fc9220c74d93df7
change-id: 20260728-rproc-dts-3f331df7ceaaBest regards,
--
Peng Fan <[email protected]>
Quoted 24 lines
Subject: Re: [PATCH v2 00/12] arm64: dts: freescale: fix reserved memory node names for remoteproc
Quoted 1 line · Peng Fan (OSS)
The
imx_rprocdriver uses node names to identify reserved memoryregions.
Quoted 10 lines
It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions. Several i.MX board dts files used incorrect node names (e.g. "vdevbuffer", "memory-rsc-table", "memory@..."), causing the driver to fail these checks.
This series renames the reserved memory nodes across all affected boards to use the expected names.
Signed-off-by Peng Fan <[email protected]>Quoted 8 lines
---
Changes in v2:
- Also fix vring, rsc-table, and dsp buffer node names in imx8dxl-evk, imx8qm-mek, imx8qxp-mek
- Add fixes for imx8dxl-sr-som, imx93-11x11-evk, imx95-15x15-frdm
- Update commit messages to reflect expanded scope
- Link to v1:
https://patch.msgid.link/20260729-rproc-dts-v1-0-
Quoted 7 lines
I hope Laurentiu Mihalcea's
https://lore.kernel.org/imx/20260605113621.1479-1-
[email protected]/move forwards, by use memory-region-names to fix these problem
I thought DT maintainers rejected the idea to use
memory-region-names.
Regards
Peng.
Quoted 68 lines
Frank
Quoted 15 lines
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Conor Dooley <[email protected]>
To: Frank Li <[email protected]>
To: Sascha Hauer <[email protected]>
To: Pengutronix Kernel Team <[email protected]>
To: Fabio Estevam <[email protected]>
To: Peng Fan <[email protected]>
Cc: Laurentiu Mihalcea <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]Quoted 3 lines
---
Peng Fan (12):
arm64: dts: imx8dxl-evk: fix reserved memory node names forremoteproc
Quoted 1 line
arm64: dts: imx8qm-mek: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx8qm-mek: fix dsp reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx8qxp-mek: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx8qxp-mek: fix dsp reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx8ulp-evk: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx93-11x11-frdm: fix reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx93-14x14-evk: fix reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx93-9x9-qsb: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx8dxl-sr-som: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx93-11x11-evk: fix reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx95-15x15-frdm: fix reserved memory node names
for
Quoted 5 lines
remoteproc
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 14 +++++----- arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi | 14 +++++----- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 32+++++++++++-----------
Quoted 1 line
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 20 +++++++-------
Quoted 16 lines
arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 4 +-- .../boot/dts/freescale/imx93-11x11-evk-common.dtsi | 4 +-- arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts | 4 +-- arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts | 4 +-- arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts | 4 +-- arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts | 12 ++++---- 10 files changed, 56 insertions(+), 56 deletions(-)---
base-commit:0d33d21e47d9dc66f91e44da3fc9220c74d93df7
change-id: 20260728-rproc-dts-3f331df7ceaaBest regards,
--
Peng Fan <[email protected]>
Quoted 26 lines · Peng Fan
Quoted 26 lines
Subject: Re: [PATCH v2 00/12] arm64: dts: freescale: fix reserved memory node names for remoteproc
Quoted 1 line · Peng Fan (OSS)
The
imx_rprocdriver uses node names to identify reserved memoryregions.
Quoted 10 lines
It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions. Several i.MX board dts files used incorrect node names (e.g. "vdevbuffer", "memory-rsc-table", "memory@..."), causing the driver to fail these checks.
This series renames the reserved memory nodes across all affected boards to use the expected names.
Signed-off-by Peng Fan <[email protected]>Quoted 8 lines
---
Changes in v2:
- Also fix vring, rsc-table, and dsp buffer node names in imx8dxl-evk, imx8qm-mek, imx8qxp-mek
- Add fixes for imx8dxl-sr-som, imx93-11x11-evk, imx95-15x15-frdm
- Update commit messages to reflect expanded scope
- Link to v1:
https://patch.msgid.link/20260729-rproc-dts-v1-0-
Quoted 8 lines
Quoted 5 lines
I hope Laurentiu Mihalcea's
https://lore.kernel.org/imx/20260605113621.1479-1-
[email protected]/move forwards, by use memory-region-names to fix these problem
I thought DT maintainers rejected the idea to use
memory-region-names.
They agree we wrong use node name as ABI. but commit message need be improved. wait for larentiu post new version.
Frank
Quoted 72 lines
Regards
Peng.Quoted 68 lines
Frank
Quoted 15 lines
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Conor Dooley <[email protected]>
To: Frank Li <[email protected]>
To: Sascha Hauer <[email protected]>
To: Pengutronix Kernel Team <[email protected]>
To: Fabio Estevam <[email protected]>
To: Peng Fan <[email protected]>
Cc: Laurentiu Mihalcea <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]Quoted 3 lines
---
Peng Fan (12):
arm64: dts: imx8dxl-evk: fix reserved memory node names forremoteproc
Quoted 1 line
arm64: dts: imx8qm-mek: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx8qm-mek: fix dsp reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx8qxp-mek: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx8qxp-mek: fix dsp reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx8ulp-evk: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx93-11x11-frdm: fix reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx93-14x14-evk: fix reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx93-9x9-qsb: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx8dxl-sr-som: fix reserved memory node names for
remoteproc
Quoted 1 line
arm64: dts: imx93-11x11-evk: fix reserved memory node names
for remoteproc
Quoted 1 line
arm64: dts: imx95-15x15-frdm: fix reserved memory node names
for
Quoted 5 lines
remoteproc
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 14 +++++----- arch/arm64/boot/dts/freescale/imx8dxl-sr-som.dtsi | 14 +++++----- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 32+++++++++++-----------
Quoted 1 line
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 20 +++++++-------
Quoted 16 lines
arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 4 +-- .../boot/dts/freescale/imx93-11x11-evk-common.dtsi | 4 +-- arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts | 4 +-- arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts | 4 +-- arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts | 4 +-- arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts | 12 ++++---- 10 files changed, 56 insertions(+), 56 deletions(-)---
base-commit:0d33d21e47d9dc66f91e44da3fc9220c74d93df7
change-id: 20260728-rproc-dts-3f331df7ceaaBest regards,
--
Peng Fan <[email protected]>
[email protected]
AppliedFrom: Frank Li <[email protected]>
Quoted 8 lines · Peng Fan (OSS)
The
imx_rprocdriver uses node names to identify reserved memory regions. It checks for "vdev0buffer" to skip mapping, "rsc-table" to locate the resource table, and "vdev" prefix to filter vdev regions. Several i.MX board dts files used incorrect node names (e.g. "vdevbuffer", "memory-rsc-table", "memory@..."), causing the driver to fail these checks.[...]
Applied, thanks!
[01/12] arm64: dts: imx8dxl-evk: fix reserved memory node names for remoteproc
commit: c4e5f1a143799651aba2c4f66860b63b56786306
[02/12] arm64: dts: imx8qm-mek: fix reserved memory node names for remoteproc
commit: c712a46c10d38ce7869a9d81d7986e844a4e9f24
[03/12] arm64: dts: imx8qm-mek: fix dsp reserved memory node names for remoteproc
commit: 2cd565bde7e872409fa468fb9410e539fb5969e4
[04/12] arm64: dts: imx8qxp-mek: fix reserved memory node names for remoteproc
commit: a9f3cf4354022ca0b4a0d12eab7af9858f71c9f7
[05/12] arm64: dts: imx8qxp-mek: fix dsp reserved memory node names for remoteproc
commit: 715f8f8877d03025a2af98b4128c83441617eb74
[06/12] arm64: dts: imx8ulp-evk: fix reserved memory node names for remoteproc
commit: f55e49b75c65c3e38e7bbe1d735f79128a50126e
[07/12] arm64: dts: imx93-11x11-frdm: fix reserved memory node names for remoteproc
commit: ab6fc27a020a18a765e17bc445b64ee18b6244de
[08/12] arm64: dts: imx93-14x14-evk: fix reserved memory node names for remoteproc
commit: e62f7ef5320d05361ee7f665568d05361b0c59d9
[09/12] arm64: dts: imx93-9x9-qsb: fix reserved memory node names for remoteproc
commit: 475a58b82921cc89805b31e0bc1df91681124a3d
[10/12] arm64: dts: imx8dxl-sr-som: fix reserved memory node names for remoteproc
commit: d8aa7355f91ed71502f588d33200a211f24f58ef
[11/12] arm64: dts: imx93-11x11-evk: fix reserved memory node names for remoteproc
commit: 7e92e62246c472418230b48c05e9296835b26b07
[12/12] arm64: dts: imx95-15x15-frdm: fix reserved memory node names for remoteproc
commit: 5cae743b988da033a709bfa10739b1d34fe57e71Best regards,
Signature · 1 line
Frank Li <[email protected]>