Skip to contentSkip to conversation

riscv: dts: spacemit: Make dtschema recognize the etherent PHY correctly on K3 pico-itx board

PATCH Applied Inochi Amaoto 2 participants 5 messages Jul 29 – Aug 2

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 riscv: dts: spacemit: Make dtschema recognize the etherent PHY correctly on K3 pico-itx board

Since the previous commit does not change the phy node name, the dtschema can not recognize the type of the ethernet phy, so the following error is produced:

/arch/riscv/boot/dts/spacemit/k3-pico-itx.dtb: phy@1 (ethernet-phy-id001c.c916): $nodename:0: 'phy@1' does not match '^ethernet-phy(@[a-f0-9]+)?$'
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml
/arch/riscv/boot/dts/spacemit/k3-pico-itx.dtb: phy@1 (ethernet-phy-id001c.c916): Unevaluated properties are not allowed ('reg', 'reset-assert-us', 're set-deassert-us', 'reset-gpios' were unexpected)
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml

Change the nodename to make the dtschema can recognize the right PHY type.

Fixes 6d6536c880fe ("riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board")
---
 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +1 -1
index d78416f3118e..e91a4712f2db 100644
@@ -195,7 +195,7 @@ &eth0 {
 	status = "okay";
 
 	mdio {
-		phy0: phy@1 {
+		phy0: ethernet-phy@1 {
 			compatible = "ethernet-phy-id001c.c916";
 			reg = <1>;
 			reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.55.0
#1 lore raw

PATCH 2/2 riscv: dts: spacemit: Make dtschema recognize the etherent PHY correctly on K3 com260 board

Since the previous commit does not change the phy node name, the dtschema can not recognize the type of the ethernet phy, so the following error is produced:

/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dtb: phy@1 (ethernet-phy-id001c.c916): $nodename:0: 'phy@1' does not match '^ethernet-phy(@[a-f0-9]+)?$'
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml
/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dtb: phy@1 (ethernet-phy-id001c.c916): Unevaluated properties are not allowed ('reg', 'reset-assert-us', ' reset-deassert-us', 'reset-gpios' were unexpected)
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml

Change the nodename to make the dtschema can recognize the right PHY type.

Fixes 9db839d52ccd ("riscv: dts: spacemit: Fix phy id check for the phy on com260 board")
---
 arch/riscv/boot/dts/spacemit/k3-com260.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k3-com260.dtsi +1 -1
index 2a07cd8f2a56..c7a04a338d08 100644
@@ -173,7 +173,7 @@ &eth1 {
 	status = "okay";
 
 	mdio {
-		phy1: phy@1 {
+		phy1: ethernet-phy@1 {
 			compatible = "ethernet-phy-id001c.c916";
 			reg = <1>;
 			reset-gpios = <&gpio 1 5 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.55.0
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] riscv: dts: spacemit: Make dtschema recognize the etherent PHY correctly on K3 com260 board

Quoted 10 lines · Inochi Amaoto

Since the previous commit does not change the phy node name, the dtschema can not recognize the type of the ethernet phy, so the following error is produced:

/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dtb: phy@1 (ethernet-phy-id001c.c916): $nodename:0: 'phy@1' does not match '^ethernet-phy(@[a-f0-9]+)?$'
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml
/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dtb: phy@1 (ethernet-phy-id001c.c916): Unevaluated properties are not allowed ('reg', 'reset-assert-us', ' reset-deassert-us', 'reset-gpios' were unexpected)
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml

Quoted 5 lines

Change the nodename to make the dtschema can recognize the right PHY type.

Fixes 9db839d52ccd ("riscv: dts: spacemit: Fix phy id check for the phy on com260 board")

Also, with my R-B

Signature · 1 line
Yixun Lan (dlan)
maintainer Reviewed-by on v1 1/2
#3 lore raw
In reply to Inochi Amaoto

Hi Inochi,
lacking cover letter, although it's not a really big problem..

Quoted 10 lines · Inochi Amaoto

Since the previous commit does not change the phy node name, the dtschema can not recognize the type of the ethernet phy, so the following error is produced:

/arch/riscv/boot/dts/spacemit/k3-pico-itx.dtb: phy@1 (ethernet-phy-id001c.c916): $nodename:0: 'phy@1' does not match '^ethernet-phy(@[a-f0-9]+)?$'
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml
/arch/riscv/boot/dts/spacemit/k3-pico-itx.dtb: phy@1 (ethernet-phy-id001c.c916): Unevaluated properties are not allowed ('reg', 'reset-assert-us', 're set-deassert-us', 'reset-gpios' were unexpected)
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml

Quoted 5 lines

Change the nodename to make the dtschema can recognize the right PHY type.

Fixes 6d6536c880fe ("riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board")

Looks good, thanks for the fix

Quoted 20 lines
---
 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts +1 -1
index d78416f3118e..e91a4712f2db 100644
@@ -195,7 +195,7 @@ &eth0 {
 	status = "okay";
 
 	mdio {
-		phy0: phy@1 {
+		phy0: ethernet-phy@1 {
 			compatible = "ethernet-phy-id001c.c916";
 			reg = <1>;
 			reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.55.0
Signature · 1 line
Yixun Lan (dlan)
maintainer Applied
#4 lore raw
In reply to Inochi Amaoto
Quoted 11 lines · Inochi Amaoto

Since the previous commit does not change the phy node name, the dtschema can not recognize the type of the ethernet phy, so the following error is produced:

/arch/riscv/boot/dts/spacemit/k3-pico-itx.dtb: phy@1 (ethernet-phy-id001c.c916): $nodename:0: 'phy@1' does not match '^ethernet-phy(@[a-f0-9]+)?$'
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml
/arch/riscv/boot/dts/spacemit/k3-pico-itx.dtb: phy@1 (ethernet-phy-id001c.c916): Unevaluated properties are not allowed ('reg', 'reset-assert-us', 're set-deassert-us', 'reset-gpios' were unexpected)
from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml

[...]

Applied, thanks!

[1/2] riscv: dts: spacemit: Make dtschema recognize the etherent PHY correctly on K3 pico-itx board

      https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=9b371a8b13fd0e8e6f3b12f4ef7e58927d6f62ee
[2/2] riscv: dts: spacemit: Make dtschema recognize the etherent PHY correctly on K3 com260 board
      https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=bff5af3c934740481a316c5ae1cd4a09a43134d0

Best regards,

Signature · 1 line
Yixun Lan <[email protected]>