media: stm32: csi: unregister async notifier on cleanup
Subsystems (4)
PATCH 1/1 media: stm32: csi: unregister async notifier on cleanup
stm32_csi_parse_dt() registers the async notifier before probe finishes. If a later operation fails, the error path only cleans up the notifier's connections. It does not unregister the notifier, leaving its entry on the global notifier list after the devm-allocated csidev is freed.
The remove path has the same problem. A later async operation can then walk the stale notifier entry and access freed memory.
Unregister the notifier before cleaning up its resources on both paths.
Fixes dcb0f4c16be5 ("media: stm32: csi: addition of the STM32 CSI driver")
Co-developed-by Ijae Kim <[email protected]>
Signed-off-by Ijae Kim <[email protected]>
Signed-off-by Myeonghun Pak <[email protected]>
--- drivers/media/platform/st/stm32/stm32-csi.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/media/platform/st/stm32/stm32-csi.c +3 -0
@@ -1059,6 +1059,7 @@ static int stm32_csi_probe(struct platform_device *pdev)return 0 ; err_cleanup: +v4l2_async_nf_unregister (&csidev->notifier);v4l2_async_nf_cleanup (&csidev->notifier);return ret; }
@@ -1068,6 +1069,8 @@ static void stm32_csi_remove(struct platform_device *pdev)struct stm32_csi_dev *csidev =platform_get_drvdata (pdev); +v4l2_async_nf_unregister (&csidev->notifier); +v4l2_async_nf_cleanup (&csidev->notifier);v4l2_async_unregister_subdev (&csidev->sd);pm_runtime_disable (&pdev->dev); }
Signature · 1 line
2.50.1